Re: [Qemu-devel] [PATCH 4/4] virtio-gpu: remove useless 'waiting' field

[Philippe Mathieu-Daudé]

On 2/21/19 12:43 PM, Marc-André Lureau wrote:
> Let's check renderer_blocked instead directly.
> 
> Signed-off-by: Marc-André Lureau 

Reviewed-by: Philippe Mathieu-Daudé 

> ---
>  include/hw/virtio/virtio-gpu.h | 1 -
>  hw/display/virtio-gpu.c| 4 +---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
> index f8cd8ee96f..26a6698266 100644
> --- a/include/hw/virtio/virtio-gpu.h
> +++ b/include/hw/virtio/virtio-gpu.h
> @@ -81,7 +81,6 @@ struct virtio_gpu_ctrl_command {
>  VirtQueue *vq;
>  struct virtio_gpu_ctrl_hdr cmd_hdr;
>  uint32_t error;
> -bool waiting;
>  bool finished;
>  QTAILQ_ENTRY(virtio_gpu_ctrl_command) next;
>  };
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 7ada4b83ac..0baa9ac0ad 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -889,8 +889,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g)
>  while (!QTAILQ_EMPTY(>cmdq)) {
>  cmd = QTAILQ_FIRST(>cmdq);
>  
> -cmd->waiting = g->renderer_blocked;
> -if (cmd->waiting) {
> +if (g->renderer_blocked) {
>  break;
>  }
>  
> @@ -939,7 +938,6 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev, 
> VirtQueue *vq)
>  cmd->vq = vq;
>  cmd->error = 0;
>  cmd->finished = false;
> -cmd->waiting = false;
>  QTAILQ_INSERT_TAIL(>cmdq, cmd, next);
>  cmd = virtqueue_pop(vq, sizeof(struct virtio_gpu_ctrl_command));
>  }
> 

Re: [Qemu-devel] [PATCH 4/4] virtio-gpu: remove useless 'waiting' field

[Christophe Fergeau]

Reviewed-by: Christophe Fergeau 

On Thu, Feb 21, 2019 at 12:43:30PM +0100, Marc-André Lureau wrote:
> Let's check renderer_blocked instead directly.
> 
> Signed-off-by: Marc-André Lureau 
> ---
>  include/hw/virtio/virtio-gpu.h | 1 -
>  hw/display/virtio-gpu.c| 4 +---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
> index f8cd8ee96f..26a6698266 100644
> --- a/include/hw/virtio/virtio-gpu.h
> +++ b/include/hw/virtio/virtio-gpu.h
> @@ -81,7 +81,6 @@ struct virtio_gpu_ctrl_command {
>  VirtQueue *vq;
>  struct virtio_gpu_ctrl_hdr cmd_hdr;
>  uint32_t error;
> -bool waiting;
>  bool finished;
>  QTAILQ_ENTRY(virtio_gpu_ctrl_command) next;
>  };
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 7ada4b83ac..0baa9ac0ad 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -889,8 +889,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g)
>  while (!QTAILQ_EMPTY(>cmdq)) {
>  cmd = QTAILQ_FIRST(>cmdq);
>  
> -cmd->waiting = g->renderer_blocked;
> -if (cmd->waiting) {
> +if (g->renderer_blocked) {
>  break;
>  }
>  
> @@ -939,7 +938,6 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev, 
> VirtQueue *vq)
>  cmd->vq = vq;
>  cmd->error = 0;
>  cmd->finished = false;
> -cmd->waiting = false;
>  QTAILQ_INSERT_TAIL(>cmdq, cmd, next);
>  cmd = virtqueue_pop(vq, sizeof(struct virtio_gpu_ctrl_command));
>  }
> -- 
> 2.21.0.rc1
> 
> 


signature.asc
Description: PGP signature

[Qemu-devel] [PATCH 4/4] virtio-gpu: remove useless 'waiting' field

[Marc-André Lureau]

Let's check renderer_blocked instead directly.

Signed-off-by: Marc-André Lureau 
---
 include/hw/virtio/virtio-gpu.h | 1 -
 hw/display/virtio-gpu.c| 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index f8cd8ee96f..26a6698266 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -81,7 +81,6 @@ struct virtio_gpu_ctrl_command {
 VirtQueue *vq;
 struct virtio_gpu_ctrl_hdr cmd_hdr;
 uint32_t error;
-bool waiting;
 bool finished;
 QTAILQ_ENTRY(virtio_gpu_ctrl_command) next;
 };
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 7ada4b83ac..0baa9ac0ad 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -889,8 +889,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g)
 while (!QTAILQ_EMPTY(>cmdq)) {
 cmd = QTAILQ_FIRST(>cmdq);
 
-cmd->waiting = g->renderer_blocked;
-if (cmd->waiting) {
+if (g->renderer_blocked) {
 break;
 }
 
@@ -939,7 +938,6 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev, 
VirtQueue *vq)
 cmd->vq = vq;
 cmd->error = 0;
 cmd->finished = false;
-cmd->waiting = false;
 QTAILQ_INSERT_TAIL(>cmdq, cmd, next);
 cmd = virtqueue_pop(vq, sizeof(struct virtio_gpu_ctrl_command));
 }
-- 
2.21.0.rc1