Re: [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server
On 09/11/2015 07:09 AM, Daniel P. Berrange wrote: >> Apologies for not (re-)reviewing sooner, but I have comments on (at >> least) patch 1, so I'm not sure this series should be merged just yet. > > Ok, please make sure you re-review this series, and not the earlier > v6 posting, as a few things have been fixed here. Okay, I've gone through the rest of the pull request, and nothing else jumped out at me beyond patch 2, although it was superficial enough that I'm not comfortable with re-adding R-b on the patches where you dropped it. At this point, I'm trusting you as maintainer sending a valid pullreq for your part of the tree. I'm adding Markus in cc to make sure he is aware that your v2 pullreq will affect introspection refactoring. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
[Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server
The following changes since commit 7b9c09f7d486647784c605739d69b708a7249c9b: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-09-10-tag' into staging (2015-09-10 18:25:52 +0100) are available in the git repository at: git://github.com/berrange/qemu.git tags/vnc-crypto-v7-for-upstream for you to fetch changes up to 432e19d71ff43a7c8e06567975675a5f8598e6c3: ui: convert VNC server to use QCryptoTLSSession (2015-09-11 11:54:29 +0100) Merge vnc-crypto-v7 Daniel P. Berrange (11): qapi: allow override of default enum prefix naming tests: remove repetition in unit test object deps crypto: move crypto objects out of libqemuutil.la qom: allow QOM to be linked into tools binaries crypto: introduce new base module for TLS credentials crypto: introduce new module for TLS anonymous credentials crypto: introduce new module for TLS x509 credentials crypto: add sanity checking of TLS x509 credentials crypto: introduce new module for handling TLS sessions ui: fix return type for VNC I/O functions to be ssize_t ui: convert VNC server to use QCryptoTLSSession Makefile| 10 +- Makefile.objs | 10 +- Makefile.target |4 + configure | 53 +- crypto/Makefile.objs| 14 +- crypto/tlscreds.c | 251 +++ crypto/tlscredsanon.c | 223 +++ crypto/tlscredspriv.h | 42 ++ crypto/tlscredsx509.c | 809 ++ crypto/tlssession.c | 574 docs/qapi-code-gen.txt |8 + include/crypto/tlscreds.h | 68 ++ include/crypto/tlscredsanon.h | 112 include/crypto/tlscredsx509.h | 113 include/crypto/tlssession.h | 322 + qapi-schema.json|3 + qapi/crypto.json| 21 + qemu-options.hx | 75 ++- qom/Makefile.objs |7 +- scripts/qapi-types.py | 16 +- scripts/qapi.py | 10 +- tests/.gitignore|7 + tests/Makefile | 106 +-- tests/crypto-tls-x509-helpers.c | 485 ++ tests/crypto-tls-x509-helpers.h | 133 tests/pkix_asn1_tab.c | 1104 +++ tests/qapi-schema/enum-bad-prefix.err |1 + tests/qapi-schema/enum-bad-prefix.exit |1 + tests/qapi-schema/enum-bad-prefix.json |2 + tests/qapi-schema/enum-bad-prefix.out |0 tests/qapi-schema/qapi-schema-test.json |5 + tests/qapi-schema/qapi-schema-test.out |2 + tests/test-crypto-tlscredsx509.c| 731 tests/test-crypto-tlssession.c | 535 +++ trace-events| 18 + ui/Makefile.objs|2 +- ui/vnc-auth-sasl.c | 36 +- ui/vnc-auth-vencrypt.c | 80 ++- ui/vnc-tls.c| 474 - ui/vnc-tls.h| 69 -- ui/vnc-ws.c | 84 +-- ui/vnc-ws.h |2 - ui/vnc.c| 362 ++ ui/vnc.h| 21 +- 44 files changed, 6124 insertions(+), 881 deletions(-) create mode 100644 crypto/tlscreds.c create mode 100644 crypto/tlscredsanon.c create mode 100644 crypto/tlscredspriv.h create mode 100644 crypto/tlscredsx509.c create mode 100644 crypto/tlssession.c create mode 100644 include/crypto/tlscreds.h create mode 100644 include/crypto/tlscredsanon.h create mode 100644 include/crypto/tlscredsx509.h create mode 100644 include/crypto/tlssession.h create mode 100644 qapi/crypto.json create mode 100644 tests/crypto-tls-x509-helpers.c create mode 100644 tests/crypto-tls-x509-helpers.h create mode 100644 tests/pkix_asn1_tab.c create mode 100644 tests/qapi-schema/enum-bad-prefix.err create mode 100644 tests/qapi-schema/enum-bad-prefix.exit create mode 100644 tests/qapi-schema/enum-bad-prefix.json create mode 100644 tests/qapi-schema/enum-bad-prefix.out create mode 100644 tests/test-crypto-tlscredsx509.c create mode 100644 tests/test-crypto-tlssession.c delete mode 100644 ui/vnc-tls.c delete mode 100644 ui/vnc-tls.h -- 2.4.3
Re: [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server
On Fri, Sep 11, 2015 at 06:38:06AM -0600, Eric Blake wrote: > On 09/11/2015 06:10 AM, Daniel P. Berrange wrote: > > The following changes since commit 7b9c09f7d486647784c605739d69b708a7249c9b: > > > > Merge remote-tracking branch > > 'remotes/sstabellini/tags/xen-2015-09-10-tag' into staging (2015-09-10 > > 18:25:52 +0100) > > > > are available in the git repository at: > > > > git://github.com/berrange/qemu.git tags/vnc-crypto-v7-for-upstream > > > > for you to fetch changes up to 432e19d71ff43a7c8e06567975675a5f8598e6c3: > > > > ui: convert VNC server to use QCryptoTLSSession (2015-09-11 11:54:29 > > +0100) > > > > > > Merge vnc-crypto-v7 > > > > > > Daniel P. Berrange (11): > > qapi: allow override of default enum prefix naming > > tests: remove repetition in unit test object deps > > crypto: move crypto objects out of libqemuutil.la > > qom: allow QOM to be linked into tools binaries > > crypto: introduce new base module for TLS credentials > > crypto: introduce new module for TLS anonymous credentials > > crypto: introduce new module for TLS x509 credentials > > crypto: add sanity checking of TLS x509 credentials > > crypto: introduce new module for handling TLS sessions > > ui: fix return type for VNC I/O functions to be ssize_t > > ui: convert VNC server to use QCryptoTLSSession > > Apologies for not (re-)reviewing sooner, but I have comments on (at > least) patch 1, so I'm not sure this series should be merged just yet. Ok, please make sure you re-review this series, and not the earlier v6 posting, as a few things have been fixed here. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Re: [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server
On 09/11/2015 06:10 AM, Daniel P. Berrange wrote: > The following changes since commit 7b9c09f7d486647784c605739d69b708a7249c9b: > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-09-10-tag' > into staging (2015-09-10 18:25:52 +0100) > > are available in the git repository at: > > git://github.com/berrange/qemu.git tags/vnc-crypto-v7-for-upstream > > for you to fetch changes up to 432e19d71ff43a7c8e06567975675a5f8598e6c3: > > ui: convert VNC server to use QCryptoTLSSession (2015-09-11 11:54:29 +0100) > > > Merge vnc-crypto-v7 > > > Daniel P. Berrange (11): > qapi: allow override of default enum prefix naming > tests: remove repetition in unit test object deps > crypto: move crypto objects out of libqemuutil.la > qom: allow QOM to be linked into tools binaries > crypto: introduce new base module for TLS credentials > crypto: introduce new module for TLS anonymous credentials > crypto: introduce new module for TLS x509 credentials > crypto: add sanity checking of TLS x509 credentials > crypto: introduce new module for handling TLS sessions > ui: fix return type for VNC I/O functions to be ssize_t > ui: convert VNC server to use QCryptoTLSSession Apologies for not (re-)reviewing sooner, but I have comments on (at least) patch 1, so I'm not sure this series should be merged just yet. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
