Re: [Qemu-devel] [PATCH RFC 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

[Stefano Stabellini]

On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote:
 However the init routines assume that on errors the return
 code is -1 (as the libxc API is) - while those xen_host_* routines follow
 another paradigm - negative errno on return, 0 on success.
 
 Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com

  hw/xen/xen_pt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
 index 706e3d9..ea1ceda 100644
 --- a/hw/xen/xen_pt.c
 +++ b/hw/xen/xen_pt.c
 @@ -716,7 +716,7 @@ static int xen_pt_initfn(PCIDevice *d)
  
  /* Initialize virtualized PCI configuration (Extended 256 Bytes) */
  if (xen_host_pci_get_block(s-real_device, 0, d-config,
 -   PCI_CONFIG_SPACE_SIZE) == -1) {
 +   PCI_CONFIG_SPACE_SIZE)  0) {
  xen_host_pci_device_put(s-real_device);
  return -1;
  }
 -- 
 2.1.0
 

[Qemu-devel] [PATCH RFC 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

[Konrad Rzeszutek Wilk]

However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.

Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com
---
 hw/xen/xen_pt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 706e3d9..ea1ceda 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -716,7 +716,7 @@ static int xen_pt_initfn(PCIDevice *d)
 
 /* Initialize virtualized PCI configuration (Extended 256 Bytes) */
 if (xen_host_pci_get_block(s-real_device, 0, d-config,
-   PCI_CONFIG_SPACE_SIZE) == -1) {
+   PCI_CONFIG_SPACE_SIZE)  0) {
 xen_host_pci_device_put(s-real_device);
 return -1;
 }
-- 
2.1.0