Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Thanks, applied to the block branch. Kevin
Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
于 2013-5-31 21:19, Luiz Capitulino 写道: On Fri, 31 May 2013 21:04:10 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf kw...@redhat.com It seems nothing need change, Kevin, do you think it can be merged? This serial blocks mine and Pavel's work, anything need to be improved? Respin with -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...) +typedef int (*fprintf_function)(void *out, const char *fmt, ...) ? As far as my review is concerned, I'm OK with your current version. Thanks Luiz. This series does code moves, so it have big chance to get conflict when upstream changes, hope it not hang out too long... sorry for pushing many times. -- Best Regards Wenchao Xia
Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf kw...@redhat.com It seems nothing need change, Kevin, do you think it can be merged? This serial blocks mine and Pavel's work, anything need to be improved? Respin with -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...) +typedef int (*fprintf_function)(void *out, const char *fmt, ...) ? -- Best Regards Wenchao Xia
Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
On Fri, 31 May 2013 21:04:10 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf kw...@redhat.com It seems nothing need change, Kevin, do you think it can be merged? This serial blocks mine and Pavel's work, anything need to be improved? Respin with -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...) +typedef int (*fprintf_function)(void *out, const char *fmt, ...) ? As far as my review is concerned, I'm OK with your current version.
Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf kw...@redhat.com It seems nothing need change, Kevin, do you think it can be merged? -- Best Regards Wenchao Xia
Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf kw...@redhat.com
[Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. v2: Squash code moving patches since they are reviewed in v1. Drop bdrv_snapshot_find() function change patch, since it related to snapshot logic which should be changed together with Pavel's serial. Use a parameter in message_printf() to tell where to print, instead of use global variable cur_mon inside. v3: Address Stefan's comments: 2/4: do not move bdrv_is_snapshot(). 4/4: reuse fprintf_function function pointer instead of a new function. Stefan Hajnoczi (1): 1 block: drop bs_snapshots global variable Wenchao Xia (3): 2 block: move snapshot code in block.c to block/snapshot.c 3 block: move qmp and info dump related code to block/qapi.c 4 block: dump snapshot and image info to specified output block.c | 313 -- block/Makefile.objs |1 + block/qapi.c | 366 + block/snapshot.c | 157 +++ include/block/block.h | 28 + include/block/block_int.h |1 + include/block/qapi.h | 43 ++ include/block/snapshot.h | 53 +++ qemu-img.c| 163 +--- savevm.c | 40 ++--- 10 files changed, 646 insertions(+), 519 deletions(-) create mode 100644 block/qapi.c create mode 100644 block/snapshot.c create mode 100644 include/block/qapi.h create mode 100644 include/block/snapshot.h
