Re: [Qemu-devel] [PATCH for-2.5] iotests: drop thread spun work-around

2016-10-10 Thread Max Reitz
On 10.10.2016 04:57, Michael S. Tsirkin wrote:
> We've disabled the warning, there should be no need for test to work
> around it.
> 
> Signed-off-by: Michael S. Tsirkin 
> ---
> 
> This is on top of
> main-loop: suppress warnings under qtest
> 
> I just tested this by running make check.
> Is this enough?

It should be, but I'm not sure why you want this patch for 2.5. Anyway:

Reviewed-by: Max Reitz 

>  tests/qemu-iotests/common.filter | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/common.filter 
> b/tests/qemu-iotests/common.filter
> index cfdb633..49217b0 100644
> --- a/tests/qemu-iotests/common.filter
> +++ b/tests/qemu-iotests/common.filter
> @@ -164,7 +164,6 @@ _filter_qemu()
>  {
>  sed -e "s#\\(^\\|(qemu) \\)$(basename $QEMU_PROG):#\1QEMU_PROG:#" \
>  -e 's#^QEMU [0-9]\+\.[0-9]\+\.[0-9]\+ monitor#QEMU X.Y.Z monitor#' \
> --e '/main-loop: WARNING: I\/O thread spun for [0-9]\+ iterations/d' \
>  -e $'s#\r##' # QEMU monitor uses \r\n line endings
>  }
>  
> 




signature.asc
Description: OpenPGP digital signature


[Qemu-devel] [PATCH for-2.5] iotests: drop thread spun work-around

2016-10-09 Thread Michael S. Tsirkin
We've disabled the warning, there should be no need for test to work
around it.

Signed-off-by: Michael S. Tsirkin 
---

This is on top of
main-loop: suppress warnings under qtest

I just tested this by running make check.
Is this enough?

 tests/qemu-iotests/common.filter | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index cfdb633..49217b0 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
@@ -164,7 +164,6 @@ _filter_qemu()
 {
 sed -e "s#\\(^\\|(qemu) \\)$(basename $QEMU_PROG):#\1QEMU_PROG:#" \
 -e 's#^QEMU [0-9]\+\.[0-9]\+\.[0-9]\+ monitor#QEMU X.Y.Z monitor#' \
--e '/main-loop: WARNING: I\/O thread spun for [0-9]\+ iterations/d' \
 -e $'s#\r##' # QEMU monitor uses \r\n line endings
 }
 
-- 
MST