Re: [Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Cédric Le Goater
On 08/09/2017 08:28 AM, Andrew Jeffery wrote:
> This is required to configure differences in behaviour between the
> AST2400 and AST2500 watchdog IPs.
> 
> Signed-off-by: Andrew Jeffery 

Reviewed-by: Cédric Le Goater 

> ---
>  hw/arm/aspeed_soc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
> index 3034849c80bf..79804e1ee652 100644
> --- a/hw/arm/aspeed_soc.c
> +++ b/hw/arm/aspeed_soc.c
> @@ -183,6 +183,8 @@ static void aspeed_soc_init(Object *obj)
>  object_initialize(>wdt[i], sizeof(s->wdt[i]), TYPE_ASPEED_WDT);
>  object_property_add_child(obj, "wdt[*]", OBJECT(>wdt[i]), NULL);
>  qdev_set_parent_bus(DEVICE(>wdt[i]), sysbus_get_default());
> +qdev_prop_set_uint32(DEVICE(>wdt[i]), "silicon-rev",
> +sc->info->silicon_rev);
>  }
>  
>  object_initialize(>ftgmac100, sizeof(s->ftgmac100), TYPE_FTGMAC100);
> 




Re: [Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Andrew Jeffery
Ugh, disregard this one; I changed the subject and reissued `git
format-patch`, which naturally doesn't overwrite any existing patch in
the output directory and so the old one got sent as well.

Andrew

On Wed, 2017-08-09 at 15:58 +0930, Andrew Jeffery wrote:
> This is required to configure differences in behaviour between the
> AST2400 and AST2500 watchdog IPs.
> 
> Signed-off-by: Andrew Jeffery 
> ---
>  hw/arm/aspeed_soc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
> index 3034849c80bf..79804e1ee652 100644
> --- a/hw/arm/aspeed_soc.c
> +++ b/hw/arm/aspeed_soc.c
> @@ -183,6 +183,8 @@ static void aspeed_soc_init(Object *obj)
>  object_initialize(>wdt[i], sizeof(s->wdt[i]),
> TYPE_ASPEED_WDT);
>  object_property_add_child(obj, "wdt[*]", OBJECT(>wdt[i]), 
> NULL);
>  qdev_set_parent_bus(DEVICE(>wdt[i]),
> sysbus_get_default());
> +qdev_prop_set_uint32(DEVICE(>wdt[i]), "silicon-rev",
> +sc->info->silicon_rev);
>  }
>  
>  object_initialize(>ftgmac100, sizeof(s->ftgmac100),
> TYPE_FTGMAC100);

signature.asc
Description: This is a digitally signed message part


[Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Andrew Jeffery
This is required to configure differences in behaviour between the
AST2400 and AST2500 watchdog IPs.

Signed-off-by: Andrew Jeffery 
---
 hw/arm/aspeed_soc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
index 3034849c80bf..79804e1ee652 100644
--- a/hw/arm/aspeed_soc.c
+++ b/hw/arm/aspeed_soc.c
@@ -183,6 +183,8 @@ static void aspeed_soc_init(Object *obj)
 object_initialize(>wdt[i], sizeof(s->wdt[i]), TYPE_ASPEED_WDT);
 object_property_add_child(obj, "wdt[*]", OBJECT(>wdt[i]), NULL);
 qdev_set_parent_bus(DEVICE(>wdt[i]), sysbus_get_default());
+qdev_prop_set_uint32(DEVICE(>wdt[i]), "silicon-rev",
+sc->info->silicon_rev);
 }
 
 object_initialize(>ftgmac100, sizeof(s->ftgmac100), TYPE_FTGMAC100);
-- 
2.11.0