Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 04:41:05PM -0300, Luiz Capitulino wrote:
> Converting the screendump command is simple and shouldn't take more than
> or or two patches, the complicated part is to report all errors correctly.
> 
> I hope I didn't go too far there, but at least this series does the right
> thing (or is very near to).
> 

Reviewed-by: Alon Levy 

>  console.c|   7 ++--
>  console.h|   5 +--
>  cutils.c | 100 
> +++
>  hmp-commands.hx  |   5 ++-
>  hmp.c|   9 +
>  hmp.h|   1 +
>  hw/blizzard.c|   4 +--
>  hw/g364fb.c  |  51 
>  hw/omap_lcdc.c   |  60 +++--
>  hw/qxl.c |   7 ++--
>  hw/tcx.c |  96 
>  hw/vga.c |  38 +
>  hw/vga_int.h |   3 +-
>  hw/vmware_vga.c  |   7 ++--
>  monitor.c|   6 
>  qapi-schema.json |  24 +
>  qemu-common.h|   7 
>  qerror.c |  28 ++--
>  qerror.h |  22 ++--
>  qmp-commands.hx  |   5 +--
>  20 files changed, 390 insertions(+), 95 deletions(-)



[Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump

2012-05-25 Thread Luiz Capitulino
Converting the screendump command is simple and shouldn't take more than
or or two patches, the complicated part is to report all errors correctly.

I hope I didn't go too far there, but at least this series does the right
thing (or is very near to).

 console.c|   7 ++--
 console.h|   5 +--
 cutils.c | 100 +++
 hmp-commands.hx  |   5 ++-
 hmp.c|   9 +
 hmp.h|   1 +
 hw/blizzard.c|   4 +--
 hw/g364fb.c  |  51 
 hw/omap_lcdc.c   |  60 +++--
 hw/qxl.c |   7 ++--
 hw/tcx.c |  96 
 hw/vga.c |  38 +
 hw/vga_int.h |   3 +-
 hw/vmware_vga.c  |   7 ++--
 monitor.c|   6 
 qapi-schema.json |  24 +
 qemu-common.h|   7 
 qerror.c |  28 ++--
 qerror.h |  22 ++--
 qmp-commands.hx  |   5 +--
 20 files changed, 390 insertions(+), 95 deletions(-)