[Qemu-devel] [PATCH qom-cpu-next] spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu()

2013-02-15 Thread Andreas Färber 
The helper functions all access ppc-specific fields only so don't bother
to change arguments to PowerPCCPU and use env_ptr instead.

No functional change.

Signed-off-by: Andreas Färber afaer...@suse.de
---
 hw/spapr_hcall.c |   11 +++
 1 Datei geändert, 3 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-)

diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
index af1db6e..7b89594 100644
--- a/hw/spapr_hcall.c
+++ b/hw/spapr_hcall.c
@@ -469,16 +469,11 @@ static target_ulong h_register_vpa(PowerPCCPU *cpu, 
sPAPREnvironment *spapr,
 CPUPPCState *tenv;
 CPUState *tcpu;
 
-for (tenv = first_cpu; tenv; tenv = tenv-next_cpu) {
-tcpu = CPU(ppc_env_get_cpu(tenv));
-if (tcpu-cpu_index == procno) {
-break;
-}
-}
-
-if (!tenv) {
+tcpu = qemu_get_cpu(procno);
+if (!tcpu) {
 return H_PARAMETER;
 }
+tenv = tcpu-env_ptr;
 
 switch (flags) {
 case FLAGS_REGISTER_VPA:
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH qom-cpu-next] spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu()

2013-02-15 Thread Alexander Graf 

On 15.02.2013, at 16:49, Andreas Färber wrote:

 The helper functions all access ppc-specific fields only so don't bother
 to change arguments to PowerPCCPU and use env_ptr instead.
 
 No functional change.
 
 Signed-off-by: Andreas Färber afaer...@suse.de

Acked-by: Alexander Graf ag...@suse.de


Alex

 ---
 hw/spapr_hcall.c |   11 +++
 1 Datei geändert, 3 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-)
 
 diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
 index af1db6e..7b89594 100644
 --- a/hw/spapr_hcall.c
 +++ b/hw/spapr_hcall.c
 @@ -469,16 +469,11 @@ static target_ulong h_register_vpa(PowerPCCPU *cpu, 
 sPAPREnvironment *spapr,
 CPUPPCState *tenv;
 CPUState *tcpu;
 
 -for (tenv = first_cpu; tenv; tenv = tenv-next_cpu) {
 -tcpu = CPU(ppc_env_get_cpu(tenv));
 -if (tcpu-cpu_index == procno) {
 -break;
 -}
 -}
 -
 -if (!tenv) {
 +tcpu = qemu_get_cpu(procno);
 +if (!tcpu) {
 return H_PARAMETER;
 }
 +tenv = tcpu-env_ptr;
 
 switch (flags) {
 case FLAGS_REGISTER_VPA:
 -- 
 1.7.10.4

Re: [Qemu-devel] [PATCH qom-cpu-next] spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu()

2013-02-15 Thread Andreas Färber 
Am 15.02.2013 17:44, schrieb Alexander Graf:
 
 On 15.02.2013, at 16:49, Andreas Färber wrote:
 
 The helper functions all access ppc-specific fields only so don't bother
 to change arguments to PowerPCCPU and use env_ptr instead.

 No functional change.

 Signed-off-by: Andreas Färber afaer...@suse.de
 
 Acked-by: Alexander Graf ag...@suse.de

Thanks, applied to qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg