Re: [Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:52 +0200
Andreas Färber afaer...@suse.de wrote:

 Hello,
 
 This series is an alternative to patches previously queued or posted,
 based on virgin master.
 
 As requested by Paolo, this replaces Kate's previous memory_mapping split
 and my follow-ups and instead goes directly for moving things to CPUState.
 
 All knowledge about dump / memory mapping are moved away from configure.
 
 v3 adds an additional patch proposing a semantic change to facilitate CPU
 handling and it prepends another bugfix to avoid merge conflicts.

I had some minor comments, but series looks good to me.

Also, Andreas, I'm going to cherry-pick mine and Qiao's fixes into QMP
tree so that they're included in my today's pull request.

 
 Regards,
 Andreas
 
 v2 - v3:
 * Incorporate Luiz' x86 bugfix.
 * Append a patch to resolve the open-coded CPU loops.
 * Massage CONFIG_HAVE_* commit messages (they were previously reordered).
 
 v1 - v2:
 * Dropped Kate's memory_mapping split
 * Dropped target_ulong cleanup and replaced with typedef
 * Amended CPUArchState cleanups with introducing hooks in CPUClass
 * Drop memory_memory stubs instead of moving them
 
 Cc: Wen Congyang we...@cn.fujitsu.com
 Cc: Qiao Nuohan qiaonuo...@cn.fujitsu.com
 Cc: Jens Freimann jf...@linux.vnet.ibm.com
 Cc: Vincent Rabin ra...@rab.in
 Cc: Paolo Bonzini pbonz...@redhat.com
 Cc: Luiz Capitulino lcapitul...@redhat.com
 
 Andreas Färber (7):
   dump: Move stubs into libqemustub.a
   cpu: Turn cpu_paging_enabled() into a CPUState hook
   memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h
   cpu: Turn cpu_get_memory_mapping() into a CPUState hook
   memory_mapping: Drop qemu_get_memory_mapping() stub
   dump: Unconditionally compile
   memory_mapping: Change qemu_get_guest_memory_mapping() semantics
 
 Luiz Capitulino (1):
   target-i386: walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE
 addresses
 
 Qiao Nuohan (1):
   target-i386: Fix mask of pte index in memory mapping
 
  Makefile.target   |  8 ++--
  configure |  8 
  hmp-commands.hx   |  2 --
  include/qemu/typedefs.h   |  2 ++
  include/qom/cpu.h | 21 
  include/sysemu/memory_mapping.h   |  8 +++-
  memory_mapping-stub.c | 33 --
  memory_mapping.c  | 42 
 +--
  qom/cpu.c | 27 +
  stubs/Makefile.objs   |  1 +
  dump-stub.c = stubs/dump.c   |  8 
  target-i386/arch_memory_mapping.c | 23 +++--
  target-i386/cpu-qom.h |  2 ++
  target-i386/cpu.c | 12 +--
  14 files changed, 103 insertions(+), 94 deletions(-)
  delete mode 100644 memory_mapping-stub.c
  rename dump-stub.c = stubs/dump.c (65%)
 




[Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone

2013-05-30 Thread Andreas Färber
Hello,

This series is an alternative to patches previously queued or posted,
based on virgin master.

As requested by Paolo, this replaces Kate's previous memory_mapping split
and my follow-ups and instead goes directly for moving things to CPUState.

All knowledge about dump / memory mapping are moved away from configure.

v3 adds an additional patch proposing a semantic change to facilitate CPU
handling and it prepends another bugfix to avoid merge conflicts.

Regards,
Andreas

v2 - v3:
* Incorporate Luiz' x86 bugfix.
* Append a patch to resolve the open-coded CPU loops.
* Massage CONFIG_HAVE_* commit messages (they were previously reordered).

v1 - v2:
* Dropped Kate's memory_mapping split
* Dropped target_ulong cleanup and replaced with typedef
* Amended CPUArchState cleanups with introducing hooks in CPUClass
* Drop memory_memory stubs instead of moving them

Cc: Wen Congyang we...@cn.fujitsu.com
Cc: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Cc: Jens Freimann jf...@linux.vnet.ibm.com
Cc: Vincent Rabin ra...@rab.in
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Luiz Capitulino lcapitul...@redhat.com

Andreas Färber (7):
  dump: Move stubs into libqemustub.a
  cpu: Turn cpu_paging_enabled() into a CPUState hook
  memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h
  cpu: Turn cpu_get_memory_mapping() into a CPUState hook
  memory_mapping: Drop qemu_get_memory_mapping() stub
  dump: Unconditionally compile
  memory_mapping: Change qemu_get_guest_memory_mapping() semantics

Luiz Capitulino (1):
  target-i386: walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE
addresses

Qiao Nuohan (1):
  target-i386: Fix mask of pte index in memory mapping

 Makefile.target   |  8 ++--
 configure |  8 
 hmp-commands.hx   |  2 --
 include/qemu/typedefs.h   |  2 ++
 include/qom/cpu.h | 21 
 include/sysemu/memory_mapping.h   |  8 +++-
 memory_mapping-stub.c | 33 --
 memory_mapping.c  | 42 +--
 qom/cpu.c | 27 +
 stubs/Makefile.objs   |  1 +
 dump-stub.c = stubs/dump.c   |  8 
 target-i386/arch_memory_mapping.c | 23 +++--
 target-i386/cpu-qom.h |  2 ++
 target-i386/cpu.c | 12 +--
 14 files changed, 103 insertions(+), 94 deletions(-)
 delete mode 100644 memory_mapping-stub.c
 rename dump-stub.c = stubs/dump.c (65%)

-- 
1.8.1.4