Re: [Qemu-devel] [PATCH v1 08/12] net: cadence_gem: Announce 64bit addressing support

2018-10-04 Thread Alistair 

On 10/03/2018 08:07 AM, Edgar E. Iglesias wrote:

From: "Edgar E. Iglesias" 

Announce 64bit addressing support.

Signed-off-by: Edgar E. Iglesias 


Reviewed-by: Alistair Francis 

Alistair


---
  hw/net/cadence_gem.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index f93cd8e..fc81fb5 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -142,6 +142,7 @@
  #define GEM_DESCONF4  (0x028C/4)
  #define GEM_DESCONF5  (0x0290/4)
  #define GEM_DESCONF6  (0x0294/4)
+#define GEM_DESCONF6_64B_MASK (1U << 23)
  #define GEM_DESCONF7  (0x0298/4)
  
  #define GEM_INT_Q1_STATUS   (0x0400 / 4)

@@ -1300,7 +1301,7 @@ static void gem_reset(DeviceState *d)
  s->regs[GEM_DESCONF] = 0x02500111;
  s->regs[GEM_DESCONF2] = 0x2ab13fff;
  s->regs[GEM_DESCONF5] = 0x002f2045;
-s->regs[GEM_DESCONF6] = 0x0;
+s->regs[GEM_DESCONF6] = GEM_DESCONF6_64B_MASK;
  
  queues_mask = MAKE_64BIT_MASK(1, s->num_priority_queues - 1);

  s->regs[GEM_DESCONF6] |= queues_mask;

[Qemu-devel] [PATCH v1 08/12] net: cadence_gem: Announce 64bit addressing support

2018-10-03 Thread Edgar E. Iglesias 
From: "Edgar E. Iglesias" 

Announce 64bit addressing support.

Signed-off-by: Edgar E. Iglesias 
---
 hw/net/cadence_gem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index f93cd8e..fc81fb5 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -142,6 +142,7 @@
 #define GEM_DESCONF4  (0x028C/4)
 #define GEM_DESCONF5  (0x0290/4)
 #define GEM_DESCONF6  (0x0294/4)
+#define GEM_DESCONF6_64B_MASK (1U << 23)
 #define GEM_DESCONF7  (0x0298/4)
 
 #define GEM_INT_Q1_STATUS   (0x0400 / 4)
@@ -1300,7 +1301,7 @@ static void gem_reset(DeviceState *d)
 s->regs[GEM_DESCONF] = 0x02500111;
 s->regs[GEM_DESCONF2] = 0x2ab13fff;
 s->regs[GEM_DESCONF5] = 0x002f2045;
-s->regs[GEM_DESCONF6] = 0x0;
+s->regs[GEM_DESCONF6] = GEM_DESCONF6_64B_MASK;
 
 queues_mask = MAKE_64BIT_MASK(1, s->num_priority_queues - 1);
 s->regs[GEM_DESCONF6] |= queues_mask;
-- 
2.7.4