Re: [Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability

2017-09-08 Thread Greg Kurz 
On Mon,  4 Sep 2017 12:07:45 -0400
Pradeep Jagadeesh  wrote:

> This patch creates a throttle initialization function to maximize the
> code reusability. The same code is also used by fsdev.
> 

s/is also/will also be/

> Acked-by: Dr. David Alan Gilbert 
> Signed-off-by: Pradeep Jagadeesh 
> ---

Reviewed-by: Greg Kurz 

>  hmp.c | 19 +--
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/hmp.c b/hmp.c
> index fd80dce..2dbfb80 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1758,20 +1758,27 @@ void hmp_change(Monitor *mon, const QDict *qdict)
>  hmp_handle_error(mon, );
>  }
>  
> +static void hmp_initialize_io_throttle(IOThrottle *iot, const QDict *qdict)
> +{
> +iot->bps = qdict_get_int(qdict, "bps");
> +iot->bps_rd = qdict_get_int(qdict, "bps_rd");
> +iot->bps_wr = qdict_get_int(qdict, "bps_wr");
> +iot->iops = qdict_get_int(qdict, "iops");
> +iot->iops_rd = qdict_get_int(qdict, "iops_rd");
> +iot->iops_wr = qdict_get_int(qdict, "iops_wr");
> +}
> +
>  void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict)
>  {
>  Error *err = NULL;
> +IOThrottle *iothrottle;
>  BlockIOThrottle throttle = {
>  .has_device = true,
>  .device = (char *) qdict_get_str(qdict, "device"),
> -.bps = qdict_get_int(qdict, "bps"),
> -.bps_rd = qdict_get_int(qdict, "bps_rd"),
> -.bps_wr = qdict_get_int(qdict, "bps_wr"),
> -.iops = qdict_get_int(qdict, "iops"),
> -.iops_rd = qdict_get_int(qdict, "iops_rd"),
> -.iops_wr = qdict_get_int(qdict, "iops_wr"),
>  };
>  
> +iothrottle = qapi_BlockIOThrottle_base();
> +hmp_initialize_io_throttle(iothrottle, qdict);
>  qmp_block_set_io_throttle(, );
>  hmp_handle_error(mon, );
>  }



pgpNRkG1odGWX.pgp
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability

2017-09-05 Thread Alberto Garcia 
On Mon 04 Sep 2017 06:07:45 PM CEST, Pradeep Jagadeesh wrote:
> This patch creates a throttle initialization function to maximize the
> code reusability. The same code is also used by fsdev.
>
> Acked-by: Dr. David Alan Gilbert 
> Signed-off-by: Pradeep Jagadeesh 

I had already reviewed this patch when you sent v8 -the first v8 :)-

Reviewed-by: Alberto Garcia 

Berto

[Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability

2017-09-04 Thread Pradeep Jagadeesh 
This patch creates a throttle initialization function to maximize the
code reusability. The same code is also used by fsdev.

Acked-by: Dr. David Alan Gilbert 
Signed-off-by: Pradeep Jagadeesh 
---
 hmp.c | 19 +--
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/hmp.c b/hmp.c
index fd80dce..2dbfb80 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1758,20 +1758,27 @@ void hmp_change(Monitor *mon, const QDict *qdict)
 hmp_handle_error(mon, );
 }
 
+static void hmp_initialize_io_throttle(IOThrottle *iot, const QDict *qdict)
+{
+iot->bps = qdict_get_int(qdict, "bps");
+iot->bps_rd = qdict_get_int(qdict, "bps_rd");
+iot->bps_wr = qdict_get_int(qdict, "bps_wr");
+iot->iops = qdict_get_int(qdict, "iops");
+iot->iops_rd = qdict_get_int(qdict, "iops_rd");
+iot->iops_wr = qdict_get_int(qdict, "iops_wr");
+}
+
 void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict)
 {
 Error *err = NULL;
+IOThrottle *iothrottle;
 BlockIOThrottle throttle = {
 .has_device = true,
 .device = (char *) qdict_get_str(qdict, "device"),
-.bps = qdict_get_int(qdict, "bps"),
-.bps_rd = qdict_get_int(qdict, "bps_rd"),
-.bps_wr = qdict_get_int(qdict, "bps_wr"),
-.iops = qdict_get_int(qdict, "iops"),
-.iops_rd = qdict_get_int(qdict, "iops_rd"),
-.iops_wr = qdict_get_int(qdict, "iops_wr"),
 };
 
+iothrottle = qapi_BlockIOThrottle_base();
+hmp_initialize_io_throttle(iothrottle, qdict);
 qmp_block_set_io_throttle(, );
 hmp_handle_error(mon, );
 }
-- 
1.8.3.1