Re: [Qemu-devel] [PATCH v2] qemu-progress.c: printf isn't signal safe

2011-04-29 Thread Kevin Wolf
Am 28.04.2011 13:58, schrieb jes.soren...@redhat.com:
 From: Jes Sorensen jes.soren...@redhat.com
 
 Change the signal handling to indicate a signal is pending, rather
 then printing directly from the signal handler.
 
 In addition make the signal prints go to stderr, rather than stdout.
 
 Signed-off-by: Jes Sorensen jes.soren...@redhat.com

Thanks, applied to the block branch.

Kevin



[Qemu-devel] [PATCH v2] qemu-progress.c: printf isn't signal safe

2011-04-28 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com

Change the signal handling to indicate a signal is pending, rather
then printing directly from the signal handler.

In addition make the signal prints go to stderr, rather than stdout.

Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
 qemu-progress.c |7 ++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/qemu-progress.c b/qemu-progress.c
index e1feb89..a4894c0 100644
--- a/qemu-progress.c
+++ b/qemu-progress.c
@@ -37,6 +37,7 @@ struct progress_state {
 };
 
 static struct progress_state state;
+static volatile sig_atomic_t print_pending;
 
 /*
  * Simple progress print function.
@@ -63,12 +64,16 @@ static void progress_simple_init(void)
 #ifdef CONFIG_POSIX
 static void sigusr_print(int signal)
 {
-printf((%3.2f/100%%)\n, state.current);
+print_pending = 1;
 }
 #endif
 
 static void progress_dummy_print(void)
 {
+if (print_pending) {
+fprintf(stderr, (%3.2f/100%%)\n, state.current);
+print_pending = 0;
+}
 }
 
 static void progress_dummy_end(void)
-- 
1.7.4.4




Re: [Qemu-devel] [PATCH v2] qemu-progress.c: printf isn't signal safe

2011-04-28 Thread Markus Armbruster
jes.soren...@redhat.com writes:

 From: Jes Sorensen jes.soren...@redhat.com

 Change the signal handling to indicate a signal is pending, rather
 then printing directly from the signal handler.

 In addition make the signal prints go to stderr, rather than stdout.

Looks good now.