Re: [Qemu-devel] [PATCH v2 0/2] Recursive op blockers
On Mon, Sep 22, 2014 at 09:00:50PM +0200, Benoît Canet wrote: in v2: Added a base parameters [Kevin] Remove multiple blockers [Kevin] Addressed Kevin's comments except BLOCK_OP_TYPE_MIRROR_REPLACE relaxing and You need to unblock all of the BDSes that are going to be removed. Aren't you unblocking more than that here?. pass ./check -qcow2 Benoît Canet (2): block: Rename BLOCK_OP_TYPE_REPLACE to BLOCK_OP_TYPE_MIRROR_REPLACE block: Make op blockers recursive block-migration.c | 4 +- block.c | 123 ++ block/blkverify.c | 21 block/commit.c| 2 + block/mirror.c| 26 +++--- block/quorum.c| 29 +++ block/stream.c| 2 + block/vmdk.c | 32 blockjob.c| 6 +-- include/block/block.h | 14 -- include/block/block_int.h | 10 11 files changed, 242 insertions(+), 27 deletions(-) -- 2.1.0 Hello people, Gentle ping, I would really like these patches to get rev-by and merged for the next release since they actually fix QEMU. Under the new rule of code review I choose Markus or Jeff to do the initial revision. I could nag Kevin into reviewing it but it's not the process anymore. Best regards Benoît
[Qemu-devel] [PATCH v2 0/2] Recursive op blockers
in v2: Added a base parameters [Kevin] Remove multiple blockers [Kevin] Addressed Kevin's comments except BLOCK_OP_TYPE_MIRROR_REPLACE relaxing and You need to unblock all of the BDSes that are going to be removed. Aren't you unblocking more than that here?. pass ./check -qcow2 Benoît Canet (2): block: Rename BLOCK_OP_TYPE_REPLACE to BLOCK_OP_TYPE_MIRROR_REPLACE block: Make op blockers recursive block-migration.c | 4 +- block.c | 123 ++ block/blkverify.c | 21 block/commit.c| 2 + block/mirror.c| 26 +++--- block/quorum.c| 29 +++ block/stream.c| 2 + block/vmdk.c | 32 blockjob.c| 6 +-- include/block/block.h | 14 -- include/block/block_int.h | 10 11 files changed, 242 insertions(+), 27 deletions(-) -- 2.1.0
[Qemu-devel] [PATCH v2 0/2] Recursive op blockers
in v2: Added a base parameters [Kevin] Remove multiple blockers [Kevin] Addressed Kevin's comments except BLOCK_OP_TYPE_MIRROR_REPLACE relaxing and You need to unblock all of the BDSes that are going to be removed. Aren't you unblocking more than that here?. pass ./check -qcow2 Benoît Canet (2): block: Rename BLOCK_OP_TYPE_REPLACE to BLOCK_OP_TYPE_MIRROR_REPLACE block: Make op blockers recursive block-migration.c | 4 +- block.c | 123 ++ block/blkverify.c | 21 block/commit.c| 2 + block/mirror.c| 26 +++--- block/quorum.c| 29 +++ block/stream.c| 2 + block/vmdk.c | 32 blockjob.c| 6 +-- include/block/block.h | 14 -- include/block/block_int.h | 10 11 files changed, 242 insertions(+), 27 deletions(-) -- 2.1.0
