Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180410120222.31845-1-tournier.e...@gmail.com
Subject: [Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for
virglrenderer.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
1e7e92e2ef..fb4fe32d5b master -> master
* [new tag]
patchew/20180410120222.31845-1-tournier.e...@gmail.com ->
patchew/20180410120222.31845-1-tournier.e...@gmail.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
fa8911b71b sdl: Allow OpenGL ES context creation
6bbe6ad468 qapi: Parameter gl of DisplayType now accept an enum
=== OUTPUT BEGIN ===
Checking PATCH 1/2: qapi: Parameter gl of DisplayType now accept an enum...
Checking PATCH 2/2: sdl: Allow OpenGL ES context creation...
WARNING: line over 80 characters
#44: FILE: ui/sdl2-gl.c:143:
+if (scon->gl_mode == DISPLAYGL_MODE_ON || scon->gl_mode ==
DISPLAYGL_MODE_CORE)
ERROR: suspect code indent for conditional statements (4, 7)
#44: FILE: ui/sdl2-gl.c:143:
+if (scon->gl_mode == DISPLAYGL_MODE_ON || scon->gl_mode ==
DISPLAYGL_MODE_CORE)
+ SDL_GL_SetAttribute(SDL_GL_CONTEXT_PROFILE_MASK,
ERROR: suspect code indent for conditional statements (4, 7)
#47: FILE: ui/sdl2-gl.c:146:
+else if (scon->gl_mode == DISPLAYGL_MODE_ES)
+ SDL_GL_SetAttribute(SDL_GL_CONTEXT_PROFILE_MASK,
ERROR: suspect code indent for conditional statements (4, 7)
#58: FILE: ui/sdl2-gl.c:157:
+if (!ctx && scon->gl_mode == DISPLAYGL_MODE_ON) {
+ SDL_GL_SetAttribute(SDL_GL_CONTEXT_PROFILE_MASK,
total: 3 errors, 1 warnings, 59 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
