Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution - You can click Advanced Settings, then List All Modes at the bottom, you get all the modes (i.e. four of each resolution, one for each orientation) Ah, ok. The driver seems to handle portrait and swap x+y when creating a displaysurface. At least I get a 600x800 display upright. I can't see a difference between Landscape + Landscape (flipped). Likewise Portrait + Portrait (flipped). Is there any? I couldn't see any visible change when using 6.1.0.1015, so I still have no idea. I'm sure it was supposed to flip upside down. Perhaps the driver doesn't support it and the gui doesn't acknowledge it. There are two changes after applying the change rom size to 8192 patch: - there is no longer an Orientation option - the modes listed under List All Modes reduce as expected Ok, so we loose the Portrait mode. Changes to the second patch: - no orientations except the normal Keeping orientation 0+1 (and dropping the flipped 2+3 versions) should make the mode list small enougth that it fits while maintaining support for the portrait mode. Sending a patch with this change. I think it would also be good to fix the driver to ignore everything with or How about that? - hard code 8192 bytes rom size - assert if the required size is larger Good. cheers, Gerd
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
On Thu, Jan 17, 2013 at 02:02:26PM +0100, Gerd Hoffmann wrote: On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution - You can click Advanced Settings, then List All Modes at the bottom, you get all the modes (i.e. four of each resolution, one for each orientation) Ah, ok. The driver seems to handle portrait and swap x+y when creating a displaysurface. At least I get a 600x800 display upright. I can't see a difference between Landscape + Landscape (flipped). Likewise Portrait + Portrait (flipped). Is there any? I can't actually get the (flipped) modes (both portrait and landscape) to work, I get an error message Unable to save display settings. How did you manage to get them to work? which driver, qemu command line, qemu version did you use? There are two changes after applying the change rom size to 8192 patch: - there is no longer an Orientation option - the modes listed under List All Modes reduce as expected Ok, so we loose the Portrait mode. Changes to the second patch: - no orientations except the normal Keeping orientation 0+1 (and dropping the flipped 2+3 versions) should make the mode list small enougth that it fits while maintaining support for the portrait mode. That's what I'm going to send. I think it would also be good to fix the driver to ignore everything with or How about that? - hard code 8192 bytes rom size - assert if the required size is larger Good. cheers, Gerd
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
Hi, I can't see a difference between Landscape + Landscape (flipped). Likewise Portrait + Portrait (flipped). Is there any? I can't actually get the (flipped) modes (both portrait and landscape) to work, I get an error message Unable to save display settings. How did you manage to get them to work? which driver, qemu command line, qemu version did you use? upstream qemu, qxl.rev set to 3, qxl driver 4.5.something (i.e. not the latest 5.x). cheers, Gerd
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution - You can click Advanced Settings, then List All Modes at the bottom, you get all the modes (i.e. four of each resolution, one for each orientation) Ah, ok. The driver seems to handle portrait and swap x+y when creating a displaysurface. At least I get a 600x800 display upright. I can't see a difference between Landscape + Landscape (flipped). Likewise Portrait + Portrait (flipped). Is there any? There are two changes after applying the change rom size to 8192 patch: - there is no longer an Orientation option - the modes listed under List All Modes reduce as expected Ok, so we loose the Portrait mode. Changes to the second patch: - no orientations except the normal Keeping orientation 0+1 (and dropping the flipped 2+3 versions) should make the mode list small enougth that it fits while maintaining support for the portrait mode. I think it would also be good to fix the driver to ignore everything with or How about that? - hard code 8192 bytes rom size - assert if the required size is larger Good. cheers, Gerd
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
- Original Message - On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution - You can click Advanced Settings, then List All Modes at the bottom, you get all the modes (i.e. four of each resolution, one for each orientation) Ah, ok. The driver seems to handle portrait and swap x+y when creating a displaysurface. At least I get a 600x800 display upright. I can't see a difference between Landscape + Landscape (flipped). Likewise Portrait + Portrait (flipped). Is there any? There are two changes after applying the change rom size to 8192 patch: - there is no longer an Orientation option - the modes listed under List All Modes reduce as expected Ok, so we loose the Portrait mode. Changes to the second patch: - no orientations except the normal Keeping orientation 0+1 (and dropping the flipped 2+3 versions) should make the mode list small enougth that it fits while maintaining support for the portrait mode. I'll test if this changes anything for a windows guest linux guest. I think it would also be good to fix the driver to ignore everything with or ... what was the end of that sentence? How about that? - hard code 8192 bytes rom size - assert if the required size is larger Good. cheers, Gerd
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
Hi, I think it would also be good to fix the driver to ignore everything with or ... what was the end of that sentence? .. orientation != 0, then registers every mode with the orientations it wants, so orientation becomes unused with newer drivers (and we keep orientation=0,1 for old driver compatibility). But maybe this isn't worth the trouble. cheers, Gerd
[Qemu-devel] [PATCH v2 0/2] fix two revision related errors
Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution - You can click Advanced Settings, then List All Modes at the bottom, you get all the modes (i.e. four of each resolution, one for each orientation) There are two changes after applying the change rom size to 8192 patch: - there is no longer an Orientation option - the modes listed under List All Modes reduce as expected Changes to the second patch: - no orientations except the normal - hard code 8192 bytes rom size - assert if the required size is larger Alon Levy (2): qxl: stop using non revision 4 rom fields for revision 4 qxl: change rom size to 8192 hw/qxl.c | 25 ++--- trace-events | 2 ++ 2 files changed, 20 insertions(+), 7 deletions(-) -- 1.8.0.1
