Re: [Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability
Hi Marcel, On 8/18/2018 12:18 AM, Marcel Apfelbaum wrote: Hi Jing, On 08/16/2018 12:28 PM, Jing Liu wrote: This patch serial is about PCI resource reserve capability. First patch refactors the resource reserve fields in GenPCIERoorPort structure out to another new structure, called "PCIResReserve". Modify the parameter list of pci_bridge_qemu_reserve_cap_init(). Then we add the teardown function called pci_bridge_qemu_reserve_cap_uninit(). Last we enable the resource reserve capability for legacy PCI bridge so that firmware can reserve additional resources for the bridge. The series looks good to me, please see some minor comments in the patches. Thanks very much for your reviewing. I will improve the codes and send new version then. Can you please point me to the SeaBIOS / OVMF counterpart? Sure. SeaBIOS patch serial is here: https://patchew.org/Seabios/1534386737-8131-1-git-send-email-jing2@linux.intel.com/ Thanks, Jing Thanks, Marcel Change Log: v2 -> v1 * add refactoring patch * add teardown function * some other fixes Jing Liu (3): hw/pci: factor PCI reserve resources to a separate structure hw/pci: add teardown function for PCI resource reserve capability hw/pci: add PCI resource reserve capability to legacy PCI bridge hw/pci-bridge/gen_pcie_root_port.c | 32 +- hw/pci-bridge/pci_bridge_dev.c | 25 hw/pci/pci_bridge.c | 47 +- include/hw/pci/pci_bridge.h | 18 +++ 4 files changed, 80 insertions(+), 42 deletions(-)
Re: [Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability
Hi Jing, On 08/16/2018 12:28 PM, Jing Liu wrote: This patch serial is about PCI resource reserve capability. First patch refactors the resource reserve fields in GenPCIERoorPort structure out to another new structure, called "PCIResReserve". Modify the parameter list of pci_bridge_qemu_reserve_cap_init(). Then we add the teardown function called pci_bridge_qemu_reserve_cap_uninit(). Last we enable the resource reserve capability for legacy PCI bridge so that firmware can reserve additional resources for the bridge. The series looks good to me, please see some minor comments in the patches. Can you please point me to the SeaBIOS / OVMF counterpart? Thanks, Marcel Change Log: v2 -> v1 * add refactoring patch * add teardown function * some other fixes Jing Liu (3): hw/pci: factor PCI reserve resources to a separate structure hw/pci: add teardown function for PCI resource reserve capability hw/pci: add PCI resource reserve capability to legacy PCI bridge hw/pci-bridge/gen_pcie_root_port.c | 32 +- hw/pci-bridge/pci_bridge_dev.c | 25 hw/pci/pci_bridge.c| 47 +- include/hw/pci/pci_bridge.h| 18 +++ 4 files changed, 80 insertions(+), 42 deletions(-)
Re: [Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability
Hi Laszlo, Thanks very much for your reminder. Looking forward to comments from all! Thanks, Jing On 8/17/2018 12:17 AM, Laszlo Ersek wrote: Hi, On 08/16/18 11:28, Jing Liu wrote: This patch serial is about PCI resource reserve capability. First patch refactors the resource reserve fields in GenPCIERoorPort structure out to another new structure, called "PCIResReserve". Modify the parameter list of pci_bridge_qemu_reserve_cap_init(). Then we add the teardown function called pci_bridge_qemu_reserve_cap_uninit(). Last we enable the resource reserve capability for legacy PCI bridge so that firmware can reserve additional resources for the bridge. Change Log: v2 -> v1 * add refactoring patch * add teardown function * some other fixes Jing Liu (3): hw/pci: factor PCI reserve resources to a separate structure hw/pci: add teardown function for PCI resource reserve capability hw/pci: add PCI resource reserve capability to legacy PCI bridge hw/pci-bridge/gen_pcie_root_port.c | 32 +- hw/pci-bridge/pci_bridge_dev.c | 25 hw/pci/pci_bridge.c| 47 +- include/hw/pci/pci_bridge.h| 18 +++ 4 files changed, 80 insertions(+), 42 deletions(-) just some meta comments for now: - I've added Marcel; please keep him CC'd on this set (and the SeaBIOS counterpart, [SeaBIOS] [PATCH v2 0/3] pci: resource reserve capability found) - my task queue has blown up and I'm unsure when I'll get to reviewing this set. The same applies to the SeaBIOS counterpart. This is just to say that you should feel free to go ahead and work with the (sub)maintainers; I'll try to get back to this as time allows, but don't wait for me. If further versions are necessary, I'd appreciate being CC'd on those, just so I know what to look at when I find the time again. Thanks! Laszlo
Re: [Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability
Hi, On 08/16/18 11:28, Jing Liu wrote: > This patch serial is about PCI resource reserve capability. > > First patch refactors the resource reserve fields in GenPCIERoorPort > structure out to another new structure, called "PCIResReserve". Modify > the parameter list of pci_bridge_qemu_reserve_cap_init(). > > Then we add the teardown function called pci_bridge_qemu_reserve_cap_uninit(). > > Last we enable the resource reserve capability for legacy PCI bridge > so that firmware can reserve additional resources for the bridge. > > Change Log: > v2 -> v1 > * add refactoring patch > * add teardown function > * some other fixes > > Jing Liu (3): > hw/pci: factor PCI reserve resources to a separate structure > hw/pci: add teardown function for PCI resource reserve capability > hw/pci: add PCI resource reserve capability to legacy PCI bridge > > hw/pci-bridge/gen_pcie_root_port.c | 32 +- > hw/pci-bridge/pci_bridge_dev.c | 25 > hw/pci/pci_bridge.c| 47 > +- > include/hw/pci/pci_bridge.h| 18 +++ > 4 files changed, 80 insertions(+), 42 deletions(-) > just some meta comments for now: - I've added Marcel; please keep him CC'd on this set (and the SeaBIOS counterpart, [SeaBIOS] [PATCH v2 0/3] pci: resource reserve capability found) - my task queue has blown up and I'm unsure when I'll get to reviewing this set. The same applies to the SeaBIOS counterpart. This is just to say that you should feel free to go ahead and work with the (sub)maintainers; I'll try to get back to this as time allows, but don't wait for me. If further versions are necessary, I'd appreciate being CC'd on those, just so I know what to look at when I find the time again. Thanks! Laszlo
[Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability
This patch serial is about PCI resource reserve capability. First patch refactors the resource reserve fields in GenPCIERoorPort structure out to another new structure, called "PCIResReserve". Modify the parameter list of pci_bridge_qemu_reserve_cap_init(). Then we add the teardown function called pci_bridge_qemu_reserve_cap_uninit(). Last we enable the resource reserve capability for legacy PCI bridge so that firmware can reserve additional resources for the bridge. Change Log: v2 -> v1 * add refactoring patch * add teardown function * some other fixes Jing Liu (3): hw/pci: factor PCI reserve resources to a separate structure hw/pci: add teardown function for PCI resource reserve capability hw/pci: add PCI resource reserve capability to legacy PCI bridge hw/pci-bridge/gen_pcie_root_port.c | 32 +- hw/pci-bridge/pci_bridge_dev.c | 25 hw/pci/pci_bridge.c| 47 +- include/hw/pci/pci_bridge.h| 18 +++ 4 files changed, 80 insertions(+), 42 deletions(-) -- 1.8.3.1
