Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes

[Markus Armbruster]

Eduardo Habkost  writes:

> This fixes the following bugs in error reporting:
>
>   $ qemu-system-x86_64 -icount rr=x -vnc :0
>   qemu-system-x86_64: -vnc :0: Invalid icount rr option: x
>
>   $ qemu-system-x86_64 -m size= -vnc :0
>   qemu-system-x86_64: -vnc :0: missing 'size' option value
>
> The last command-line option (-vnc) is being shown in the error
> message, instead of the -m or -icount options.
>
> This also includes a patch submitted previously by Marcel, to
> ensure there are no ordering conflicts when applying the patches.
> Marcel's patch fixes the following bug:
>
>   $ qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22
>   qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type
>   Use -machine help to list supported machines

Applied to error-next, thanks!

Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes

[Markus Armbruster]

Eduardo Habkost  writes:

> This fixes the following bugs in error reporting:
>
>   $ qemu-system-x86_64 -icount rr=x -vnc :0
>   qemu-system-x86_64: -vnc :0: Invalid icount rr option: x
>
>   $ qemu-system-x86_64 -m size= -vnc :0
>   qemu-system-x86_64: -vnc :0: missing 'size' option value
>
> The last command-line option (-vnc) is being shown in the error
> message, instead of the -m or -icount options.
>
> This also includes a patch submitted previously by Marcel, to
> ensure there are no ordering conflicts when applying the patches.
> Marcel's patch fixes the following bug:
>
>   $ qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22
>   qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type
>   Use -machine help to list supported machines

I have two minor suggestions.  Regardless:
Reviewed-by: Markus Armbruster 

I can take the series through my tree.  Of course, Paolo merging it
through his would also be fine.

[Qemu-devel] [PATCH v2 0/4] Error location reporting fixes

[Eduardo Habkost]

This fixes the following bugs in error reporting:

  $ qemu-system-x86_64 -icount rr=x -vnc :0
  qemu-system-x86_64: -vnc :0: Invalid icount rr option: x

  $ qemu-system-x86_64 -m size= -vnc :0
  qemu-system-x86_64: -vnc :0: missing 'size' option value

The last command-line option (-vnc) is being shown in the error
message, instead of the -m or -icount options.

This also includes a patch submitted previously by Marcel, to
ensure there are no ordering conflicts when applying the patches.
Marcel's patch fixes the following bug:

  $ qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22
  qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type
  Use -machine help to list supported machines

Eduardo Habkost (3):
  vl: Reset location after handling command-line arguments
  replay: Set error location properly when parsing options
  vl: Set error location when parsing memory options

Marcel Apfelbaum (1):
  vl.c: Fix regression in machine error message

 replay/replay.c | 10 ++
 vl.c| 47 ++-
 2 files changed, 44 insertions(+), 13 deletions(-)

-- 
2.1.0