Re: [Qemu-devel] [PATCH v2 00/10] Cleanup bitops vs host-utils
Thanks, applied. On Thu, Feb 14, 2013 at 1:47 AM, Richard Henderson wrote: > Version 1 merely tried to adjust bitops_flsl, here I instead eliminate > it all from bitops.h, and standardizes on the routines from host-utils.h. > > > r~ > > > Richard Henderson (10): > host-utils: Add host long specific aliases for clz, ctz, ctpop > host-utils: Fix coding style and add comments > hbitmap: Use non-bitops ctzl > bitops: Use non-bitops ctzl > memory: Use non-bitops ctzl > bitops: Write bitops_flsl in terms of clzl > target-i386: Inline bitops_flsl > bitops: Inline bitops_flsl > bitops: Replace bitops_ctol with ctzl > bitops: Remove routines redundant with host-utils > > include/qemu/bitops.h | 75 - > include/qemu/hbitmap.h| 3 +- > include/qemu/host-utils.h | 119 > +++--- > memory.c | 4 +- > target-i386/topology.h| 6 +-- > util/bitops.c | 6 +-- > util/hbitmap.c| 3 +- > 7 files changed, 112 insertions(+), 104 deletions(-) > > -- > 1.8.1.2 >
Re: [Qemu-devel] [PATCH v2 00/10] Cleanup bitops vs host-utils
On 02/14/2013 01:43 AM, Peter Maydell wrote: > I was hoping we'd be able to get rid of host-utils.h instead, > since "Utility compute operations used by translated code" is > now a completely irrelevant categorisation... I suppose an 11th patch could move the code back to bitops.h, but I much prefer the function names used in host-utils.h. r~
Re: [Qemu-devel] [PATCH v2 00/10] Cleanup bitops vs host-utils
On 02/13/2013 06:47 PM, Richard Henderson wrote: > Version 1 merely tried to adjust bitops_flsl, here I instead eliminate > it all from bitops.h, and standardizes on the routines from host-utils.h. > > > r~ > > > Richard Henderson (10): > host-utils: Add host long specific aliases for clz, ctz, ctpop > host-utils: Fix coding style and add comments > hbitmap: Use non-bitops ctzl > bitops: Use non-bitops ctzl > memory: Use non-bitops ctzl > bitops: Write bitops_flsl in terms of clzl > target-i386: Inline bitops_flsl > bitops: Inline bitops_flsl > bitops: Replace bitops_ctol with ctzl > bitops: Remove routines redundant with host-utils > > include/qemu/bitops.h | 75 - > include/qemu/hbitmap.h| 3 +- > include/qemu/host-utils.h | 119 > +++--- > memory.c | 4 +- > target-i386/topology.h| 6 +-- > util/bitops.c | 6 +-- > util/hbitmap.c| 3 +- > 7 files changed, 112 insertions(+), 104 deletions(-) Series: Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v2 00/10] Cleanup bitops vs host-utils
On 14 February 2013 01:47, Richard Henderson wrote: > Version 1 merely tried to adjust bitops_flsl, here I instead eliminate > it all from bitops.h, and standardizes on the routines from host-utils.h. I was hoping we'd be able to get rid of host-utils.h instead, since "Utility compute operations used by translated code" is now a completely irrelevant categorisation... -- PMM
[Qemu-devel] [PATCH v2 00/10] Cleanup bitops vs host-utils
Version 1 merely tried to adjust bitops_flsl, here I instead eliminate it all from bitops.h, and standardizes on the routines from host-utils.h. r~ Richard Henderson (10): host-utils: Add host long specific aliases for clz, ctz, ctpop host-utils: Fix coding style and add comments hbitmap: Use non-bitops ctzl bitops: Use non-bitops ctzl memory: Use non-bitops ctzl bitops: Write bitops_flsl in terms of clzl target-i386: Inline bitops_flsl bitops: Inline bitops_flsl bitops: Replace bitops_ctol with ctzl bitops: Remove routines redundant with host-utils include/qemu/bitops.h | 75 - include/qemu/hbitmap.h| 3 +- include/qemu/host-utils.h | 119 +++--- memory.c | 4 +- target-i386/topology.h| 6 +-- util/bitops.c | 6 +-- util/hbitmap.c| 3 +- 7 files changed, 112 insertions(+), 104 deletions(-) -- 1.8.1.2
