Re: [Qemu-devel] [PATCH v2 07/27] target/arm: Decode PAuth within disas_data_proc_1src

[Peter Maydell]

On Fri, 14 Dec 2018 at 05:24, Richard Henderson
 wrote:
>
> Signed-off-by: Richard Henderson 
> ---
>  target/arm/translate-a64.c | 146 +
>  1 file changed, 146 insertions(+)
>
Reviewed-by: Peter Maydell 

thanks
-- PMM

[Qemu-devel] [PATCH v2 07/27] target/arm: Decode PAuth within disas_data_proc_1src

[Richard Henderson]

Signed-off-by: Richard Henderson 
---
 target/arm/translate-a64.c | 146 +
 1 file changed, 146 insertions(+)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index c5ec430b42..7ba4c996cf 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -4564,6 +4564,7 @@ static void handle_rev16(DisasContext *s, unsigned int sf,
 static void disas_data_proc_1src(DisasContext *s, uint32_t insn)
 {
 unsigned int sf, opcode, opcode2, rn, rd;
+TCGv_i64 tcg_rd;
 
 if (extract32(insn, 29, 1)) {
 unallocated_encoding(s);
@@ -4602,7 +4603,152 @@ static void disas_data_proc_1src(DisasContext *s, 
uint32_t insn)
 case MAP(1, 0x00, 0x05):
 handle_cls(s, sf, rn, rd);
 break;
+case MAP(1, 0x01, 0x00): /* PACIA */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacia(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x01): /* PACIB */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacib(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x02): /* PACDA */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacda(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x03): /* PACDB */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacdb(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x04): /* AUTIA */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_autia(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x05): /* AUTIB */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_autib(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x06): /* AUTDA */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_autda(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x07): /* AUTDB */
+if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_autdb(tcg_rd, cpu_env, tcg_rd, cpu_reg_sp(s, rn));
+} else if (!dc_isar_feature(aa64_pauth, s)) {
+goto do_unallocated;
+}
+break;
+case MAP(1, 0x01, 0x08): /* PACIZA */
+if (!dc_isar_feature(aa64_pauth, s) || rn != 31) {
+goto do_unallocated;
+} else if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacia(tcg_rd, cpu_env, tcg_rd, new_tmp_a64_zero(s));
+}
+break;
+case MAP(1, 0x01, 0x09): /* PACIZB */
+if (!dc_isar_feature(aa64_pauth, s) || rn != 31) {
+goto do_unallocated;
+} else if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacib(tcg_rd, cpu_env, tcg_rd, new_tmp_a64_zero(s));
+}
+break;
+case MAP(1, 0x01, 0x0a): /* PACDZA */
+if (!dc_isar_feature(aa64_pauth, s) || rn != 31) {
+goto do_unallocated;
+} else if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacda(tcg_rd, cpu_env, tcg_rd, new_tmp_a64_zero(s));
+}
+break;
+case MAP(1, 0x01, 0x0b): /* PACDZB */
+if (!dc_isar_feature(aa64_pauth, s) || rn != 31) {
+goto do_unallocated;
+} else if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_pacdb(tcg_rd, cpu_env, tcg_rd, new_tmp_a64_zero(s));
+}
+break;
+case MAP(1, 0x01, 0x0c): /* AUTIZA */
+if (!dc_isar_feature(aa64_pauth, s) || rn != 31) {
+goto do_unallocated;
+} else if (s->pauth_active) {
+tcg_rd = cpu_reg(s, rd);
+gen_helper_autia(tcg_rd, cpu_env, tcg_rd, new_tmp_a64_zero(s));
+}
+break;
+case MAP(1, 0x01, 0x0d): /* AUTIZB */
+if (!dc_isar_feature(aa64_pauth, s) || rn != 31) {
+goto do_unallocated;
+} else if (s->pauth_active) {
+tcg_rd =