Re: [Qemu-devel] [PATCH v2 12/28] s390x/tcg: MVST: Check for specification exceptions

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote:
> Bit position 32-55 of general register 0 must be zero.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  target/s390x/mem_helper.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Richard Henderson 

r~




[Qemu-devel] [PATCH v2 12/28] s390x/tcg: MVST: Check for specification exceptions

2019-09-06 Thread David Hildenbrand
Bit position 32-55 of general register 0 must be zero.

Signed-off-by: David Hildenbrand 
---
 target/s390x/mem_helper.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index de5e69b500..afcd452a00 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -699,6 +699,9 @@ uint64_t HELPER(mvst)(CPUS390XState *env, uint64_t c, 
uint64_t d, uint64_t s)
 uintptr_t ra = GETPC();
 uint32_t len;
 
+if (c & 0xff00ull) {
+s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, ra);
+}
 c = c & 0xff;
 d = wrap_address(env, d);
 s = wrap_address(env, s);
-- 
2.21.0