Re: [Qemu-devel] [PATCH v2 3/3] xenfb: remove out_cons in xenfb_handle_events

[Stefano Stabellini]

On Tue, 12 Apr 2016, Wei Liu wrote:
> The variable out_cons was only used to temporarily hold the consumer
> index. Use cons directly to simplify code a bit.
> 
> No functional change introduced.
> 
> Signed-off-by: Wei Liu 

Except for the fact that it is based on patch #2, which is wrong, this
looks OK.

Acked-by: Stefano Stabellini 


> Cc: Stefano Stabellini 
> Cc: Anthony Perard 
> ---
>  hw/display/xenfb.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index 7f4fad7..7d50efb 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -770,16 +770,16 @@ static void xenfb_invalidate(void *opaque)
>  
>  static void xenfb_handle_events(struct XenFB *xenfb)
>  {
> -uint32_t prod, cons, out_cons;
> +uint32_t prod, cons;
>  struct xenfb_page *page = xenfb->c.page;
>  
>  prod = page->out_prod;
> -out_cons = page->out_cons;
> +cons = page->out_cons;
>  xen_rmb();
> -if (prod - out_cons > XENFB_OUT_RING_LEN) {
> +if (prod - cons > XENFB_OUT_RING_LEN) {
>  return;
>  }
> -for (cons = out_cons; cons != prod; cons++) {
> +for ( ; cons != prod; cons++) {
>   union xenfb_out_event *event = _OUT_RING_REF(page, cons);
>  uint8_t type = event->type;
>   int x, y, w, h;
> -- 
> 2.1.4
> 

[Qemu-devel] [PATCH v2 3/3] xenfb: remove out_cons in xenfb_handle_events

[Wei Liu]

The variable out_cons was only used to temporarily hold the consumer
index. Use cons directly to simplify code a bit.

No functional change introduced.

Signed-off-by: Wei Liu 
---
Cc: Stefano Stabellini 
Cc: Anthony Perard 
---
 hw/display/xenfb.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index 7f4fad7..7d50efb 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -770,16 +770,16 @@ static void xenfb_invalidate(void *opaque)
 
 static void xenfb_handle_events(struct XenFB *xenfb)
 {
-uint32_t prod, cons, out_cons;
+uint32_t prod, cons;
 struct xenfb_page *page = xenfb->c.page;
 
 prod = page->out_prod;
-out_cons = page->out_cons;
+cons = page->out_cons;
 xen_rmb();
-if (prod - out_cons > XENFB_OUT_RING_LEN) {
+if (prod - cons > XENFB_OUT_RING_LEN) {
 return;
 }
-for (cons = out_cons; cons != prod; cons++) {
+for ( ; cons != prod; cons++) {
union xenfb_out_event *event = _OUT_RING_REF(page, cons);
 uint8_t type = event->type;
int x, y, w, h;
-- 
2.1.4