Re: [Qemu-devel] [PATCH v2 4/6] mips: Express dependencies of the Boston machine with kconfig

2019-02-28 Thread Paul Burton
On Mon, Feb 04, 2019 at 09:26:07PM +0100, Philippe Mathieu-Daudé wrote:
> Boston is built around a Xilinx FPGA, which includes a PCIe root port
> and an UART. An Intel EG20T PCH connects the I/O peripherals, but only
> the SATA bus is emulated.
> 
> Signed-off-by: Philippe Mathieu-Daudé 

Reviewed-by: Paul Burton 

Thanks,
Paul

> ---
>  default-configs/mips64el-softmmu.mak | 4 
>  hw/mips/Kconfig  | 5 +
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/default-configs/mips64el-softmmu.mak 
> b/default-configs/mips64el-softmmu.mak
> index 23445cfcf9..c6f1f9c9aa 100644
> --- a/default-configs/mips64el-softmmu.mak
> +++ b/default-configs/mips64el-softmmu.mak
> @@ -4,8 +4,4 @@ include mips-softmmu-common.mak
>  CONFIG_IDE_VIA=y
>  CONFIG_FULONG=y
>  CONFIG_VT82C686=y
> -CONFIG_AHCI=y
>  CONFIG_MIPS_BOSTON=y
> -CONFIG_FITLOADER=y
> -CONFIG_PCI_EXPRESS=y
> -CONFIG_PCI_EXPRESS_XILINX=y
> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
> index ee6290d497..2940ff39ab 100644
> --- a/hw/mips/Kconfig
> +++ b/hw/mips/Kconfig
> @@ -49,3 +49,8 @@ config MIPS_CPS
>  
>  config MIPS_BOSTON
>  bool
> +select FITLOADER
> +select MIPS_CPS
> +select PCI_EXPRESS_XILINX
> +select AHCI
> +select SERIAL
> -- 
> 2.20.1
> 



Re: [Qemu-devel] [PATCH v2 4/6] mips: Express dependencies of the Boston machine with kconfig

2019-02-04 Thread Thomas Huth
On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
> Boston is built around a Xilinx FPGA, which includes a PCIe root port
> and an UART. An Intel EG20T PCH connects the I/O peripherals, but only
> the SATA bus is emulated.
> 
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
>  default-configs/mips64el-softmmu.mak | 4 
>  hw/mips/Kconfig  | 5 +
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/default-configs/mips64el-softmmu.mak 
> b/default-configs/mips64el-softmmu.mak
> index 23445cfcf9..c6f1f9c9aa 100644
> --- a/default-configs/mips64el-softmmu.mak
> +++ b/default-configs/mips64el-softmmu.mak
> @@ -4,8 +4,4 @@ include mips-softmmu-common.mak
>  CONFIG_IDE_VIA=y
>  CONFIG_FULONG=y
>  CONFIG_VT82C686=y
> -CONFIG_AHCI=y
>  CONFIG_MIPS_BOSTON=y
> -CONFIG_FITLOADER=y
> -CONFIG_PCI_EXPRESS=y
> -CONFIG_PCI_EXPRESS_XILINX=y
> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
> index ee6290d497..2940ff39ab 100644
> --- a/hw/mips/Kconfig
> +++ b/hw/mips/Kconfig
> @@ -49,3 +49,8 @@ config MIPS_CPS
>  
>  config MIPS_BOSTON
>  bool
> +select FITLOADER
> +select MIPS_CPS
> +select PCI_EXPRESS_XILINX
> +select AHCI
> +select SERIAL

Reviewed-by: Thomas Huth 



[Qemu-devel] [PATCH v2 4/6] mips: Express dependencies of the Boston machine with kconfig

2019-02-04 Thread Philippe Mathieu-Daudé
Boston is built around a Xilinx FPGA, which includes a PCIe root port
and an UART. An Intel EG20T PCH connects the I/O peripherals, but only
the SATA bus is emulated.

Signed-off-by: Philippe Mathieu-Daudé 
---
 default-configs/mips64el-softmmu.mak | 4 
 hw/mips/Kconfig  | 5 +
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/default-configs/mips64el-softmmu.mak 
b/default-configs/mips64el-softmmu.mak
index 23445cfcf9..c6f1f9c9aa 100644
--- a/default-configs/mips64el-softmmu.mak
+++ b/default-configs/mips64el-softmmu.mak
@@ -4,8 +4,4 @@ include mips-softmmu-common.mak
 CONFIG_IDE_VIA=y
 CONFIG_FULONG=y
 CONFIG_VT82C686=y
-CONFIG_AHCI=y
 CONFIG_MIPS_BOSTON=y
-CONFIG_FITLOADER=y
-CONFIG_PCI_EXPRESS=y
-CONFIG_PCI_EXPRESS_XILINX=y
diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
index ee6290d497..2940ff39ab 100644
--- a/hw/mips/Kconfig
+++ b/hw/mips/Kconfig
@@ -49,3 +49,8 @@ config MIPS_CPS
 
 config MIPS_BOSTON
 bool
+select FITLOADER
+select MIPS_CPS
+select PCI_EXPRESS_XILINX
+select AHCI
+select SERIAL
-- 
2.20.1