Re: [Qemu-devel] [PATCH v2 7/7] spapr: fix possible memory leak

[Gonglei (Arei)]

Hi,

> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Monday, July 28, 2014 6:45 PM
> Subject: Re: [PATCH v2 7/7] spapr: fix possible memory leak
> 
> 
> On 25.07.14 08:52, arei.gong...@huawei.com wrote:
> > From: Gonglei 
> >
> > get_boot_devices_list() will malloc memory, spapr_finalize_fdt
> > doesn't free it.
> >
> > Signed-off-by: Chenliang 
> > Signed-off-by: Gonglei 
> 
> Thanks, applied to ppc-next-2.2.
> 
Thanks, Alex.

Then I will not include this patch in my next version of the
patch serials about bootindex.

Best regards,
-Gonglei

Re: [Qemu-devel] [PATCH v2 7/7] spapr: fix possible memory leak

[Alexander Graf]

On 25.07.14 08:52, arei.gong...@huawei.com wrote:

From: Gonglei 

get_boot_devices_list() will malloc memory, spapr_finalize_fdt
doesn't free it.

Signed-off-by: Chenliang 
Signed-off-by: Gonglei 


Thanks, applied to ppc-next-2.2.


Alex

[Qemu-devel] [PATCH v2 7/7] spapr: fix possible memory leak

[arei.gonglei]

From: Gonglei 

get_boot_devices_list() will malloc memory, spapr_finalize_fdt
doesn't free it.

Signed-off-by: Chenliang 
Signed-off-by: Gonglei 
---
 hw/ppc/spapr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index d01978f..edff5ce 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -745,6 +745,7 @@ static void spapr_finalize_fdt(sPAPREnvironment *spapr,
 
 cpu_physical_memory_write(fdt_addr, fdt, fdt_totalsize(fdt));
 
+g_free(bootlist);
 g_free(fdt);
 }
 
-- 
1.7.12.4