Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum
Am 10.02.2012 19:31, schrieb Jan Kiszka: Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644 --- a/pc-bios/optionrom/optionrom.h +++ b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw%ax, %ds; #define OPTION_ROM_END \ -.align 512, 0; \ + .byte 0; \ + .align 512, 0; \ Tabs. Andreas _end: #define BOOT_ROM_END \ -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum
On 2012-02-11 12:46, Andreas Färber wrote: Am 10.02.2012 19:31, schrieb Jan Kiszka: Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644 --- a/pc-bios/optionrom/optionrom.h +++ b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw%ax, %ds; #define OPTION_ROM_END \ -.align 512, 0; \ +.byte 0; \ +.align 512, 0; \ Tabs. For sure, like in the whole file. If a codestyle fix is desired, I'll post one for all assembly files. But I guess there are different views on such changes. Jan signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11.02.2012 13:45, schrieb Jan Kiszka: On 2012-02-11 12:46, Andreas Färber wrote: Am 10.02.2012 19:31, schrieb Jan Kiszka: Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644 --- a/pc-bios/optionrom/optionrom.h +++ b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw%ax, %ds; #define OPTION_ROM_END \ -.align 512, 0; \ + .byte 0; \ + .align 512, 0; \ Tabs. For sure, like in the whole file. No, as we can see in this patch, .align above and _align below use 4 spaces, so this looks inconsistent in Thunderbird. I don't really mind, just noticed and thought you might want to fix. Andreas If a codestyle fix is desired, I'll post one for all assembly files. But I guess there are different views on such changes. Jan - -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBAgAGBQJPNmQ2AAoJEPou0S0+fgE/nnEQALknNqkUrCgdXTiRwaKCZehU U+lnRwAY2DoFKaq8IqmvmiwNW2g4U0qPy0Stc7qvsOeTHSk/MX3R1Ym1+a03Hk22 tIzyJjvQPgVkbQtAljC7BObGzxGq9mUlV4+/TuTQgTsDXig121CmVVmrKXDRdP6o vXmtLgkXQB75ArOQSr0sByCFuBbA+AlIcmtIpvlR6znMZcfp0QFYbAzfAINzad+A Qg40GXUsFyyHlstM3Njt9H0ArtvE+NIPH9ZABk+58aV92CAk31rOigiiBAE1sPja qR0AIEMmwnASEWsn/yX45b+lhxXfVadZNzobhnJ/KqG/K7hrfzcLIeD5pKMt8USu TPFfdswt4utm/JDGhP9moRpe3cLGITAN93vybyOv/7W0CK18etFgevQvX0C98V9O +FUjwqsOwfXkswXcglwYmUVqJarUooh1MlXF/QnS+/d7aefIl59Y/YaGzRryjZNm Nd1hN7L5J34LfBCgltWNXA9KQB+0LyCYCX0lzE1+428WwqbZ8nGa9ZiUY0w4N2O7 maWrWnmI1VsiUL8RdsQpx7+nRfUEZW6JDfm1bA5nbd+uLuE+TwpAWWkC2kVOhnfi UQggicoM6J88zcbiGT74whjfZgx7CXcE/F/Tncd5ebi5qi++jXB6C0f3LSFcx2KP +Zv19XpWHzZXNNYiGFW0 =rQEQ -END PGP SIGNATURE-
Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum
On 2012-02-11 13:51, Andreas Färber wrote: Am 11.02.2012 13:45, schrieb Jan Kiszka: On 2012-02-11 12:46, Andreas Färber wrote: Am 10.02.2012 19:31, schrieb Jan Kiszka: Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644 --- a/pc-bios/optionrom/optionrom.h +++ b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw %ax, %ds; #define OPTION_ROM_END \ -.align 512, 0; \ + .byte 0; \ + .align 512, 0; \ Tabs. For sure, like in the whole file. No, as we can see in this patch, .align above and _align below use 4 spaces, so this looks inconsistent in Thunderbird. Right, but that is consistent with other labels in this file. OTOH, label indention is different again in the option rom source files. Well, no optimal solution here... ;) Thanks, Jan I don't really mind, just noticed and thought you might want to fix. Andreas If a codestyle fix is desired, I'll post one for all assembly files. But I guess there are different views on such changes. Jan signature.asc Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum
Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644 --- a/pc-bios/optionrom/optionrom.h +++ b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw%ax, %ds; #define OPTION_ROM_END \ -.align 512, 0; \ + .byte 0; \ + .align 512, 0; \ _end: #define BOOT_ROM_END \ -- 1.7.3.4
