Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration
Thanks Dave Eric for spending time to review my patches and giving the valuable comments, I will refine my patches in the later version according to your suggestions. * Liang Li (liang.z...@intel.com) wrote: This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v2-v3 -Splited the patch to 13 parts instead of 2 -Rewrote the core code to do compression and decompression -Updated the document -Added a common command interface to set and query parameters -Added some comments Hi, Apologies for taking so long; generally this is a lot nicer. I'll reply to each patch individually, but two more general questions: a) Shouldn't compressBound be used somewhere to get the worst case compressed size? Yes, compressBound is better to deal with the worst case, I will make a change. b) I think adding some trace points would be useful; it would make it easier to spot when you were waiting for threads etc. I will do that. Liang
Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration
* Liang Li (liang.z...@intel.com) wrote: This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v2-v3 -Splited the patch to 13 parts instead of 2 -Rewrote the core code to do compression and decompression -Updated the document -Added a common command interface to set and query parameters -Added some comments Hi, Apologies for taking so long; generally this is a lot nicer. I'll reply to each patch individually, but two more general questions: a) Shouldn't compressBound be used somewhere to get the worst case compressed size? b) I think adding some trace points would be useful; it would make it easier to spot when you were waiting for threads etc. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration
Hi All, Have you returned from vacation? If so, could you help to review my patches I have submitted three weeks ago? Thanks a lot. Liang -Original Message- From: Li, Liang Z Sent: Friday, December 12, 2014 9:29 AM To: qemu-devel@nongnu.org Cc: quint...@redhat.com; lcapitul...@redhat.com; ebl...@redhat.com; arm...@redhat.com; Zhang, Yang Z; dgilb...@redhat.com; Li, Liang Z Subject: [PATCH v3 0/13] migration: Add a new feature to do live migration This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v2-v3 -Splited the patch to 13 parts instead of 2 -Rewrote the core code to do compression and decompression -Updated the document -Added a common command interface to set and query parameters -Added some comments -- 1.9.1
Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration
-Original Message- From: Li, Liang Z Sent: Friday, December 12, 2014 9:29 AM To: qemu-devel@nongnu.org Cc: quint...@redhat.com; lcapitul...@redhat.com; ebl...@redhat.com; arm...@redhat.com; Zhang, Yang Z; dgilb...@redhat.com; Li, Liang Z Subject: [PATCH v3 0/13] migration: Add a new feature to do live migration This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v2-v3 -Splited the patch to 13 parts instead of 2 -Rewrote the core code to do compression and decompression -Updated the document -Added a common command interface to set and query parameters -Added some comments -- 1.9.1 Hi, all Could you help to review my patches? Liang
[Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration
This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v2-v3 -Splited the patch to 13 parts instead of 2 -Rewrote the core code to do compression and decompression -Updated the document -Added a common command interface to set and query parameters -Added some comments -- 1.9.1
