[Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend
This patch series adds some fixes to the netmap net backend. It contains two changes: (1) Fix compilation issue of netmap.c introduced by the reorganization of struct NetClientOptions (2) Address the FIXME comment that was asking to use error_setg() variants in place of error_report() CHANGELOG: - removed dead return and use error_setg_file_open() in place of error_setg_errno() - I noticed that net_init_netmap() has to return int, so I restored the return statements in that function Vincenzo Maffione (2): net: netmap: Fix compilation issue net: netmap: use error_setg() helpers in place of error_report() net/netmap.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.6.2
Re: [Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend
Vincenzo Maffione writes: > This patch series adds some fixes to the netmap net backend. It contains > two changes: > (1) Fix compilation issue of netmap.c introduced by the reorganization > of struct NetClientOptions > (2) Address the FIXME comment that was asking to use error_setg() > variants in place of error_report() Series Reviewed-by: Markus Armbruster
Re: [Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend
On 11/10/2015 05:47 PM, Vincenzo Maffione wrote: > This patch series adds some fixes to the netmap net backend. It contains > two changes: > (1) Fix compilation issue of netmap.c introduced by the reorganization > of struct NetClientOptions > (2) Address the FIXME comment that was asking to use error_setg() > variants in place of error_report() > > CHANGELOG: > - removed dead return and use error_setg_file_open() in place > of error_setg_errno() > - I noticed that net_init_netmap() has to return int, so I restored > the return statements in that function > > Vincenzo Maffione (2): > net: netmap: Fix compilation issue > net: netmap: use error_setg() helpers in place of error_report() > > net/netmap.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > I've picked this series in https://github.com/jasowang/qemu/commits/net Thanks