On Wed, 1 Mar 2017 11:50:23 +
Stefan Hajnoczi wrote:
> v3:
> * Added Patch 2 to fix invalid test parameters
> * Switched to nicer max < avg check [Berto]
> v2:
> * Fixed s/bps/iops/ copy-paste error in Patch 1 [Berto]
> * Rephrased warning about guest hangs and errors [Berto]
> * Added Patch 2 to hide the internal .max value from the monitor
>
> Patch 1 fleshes out the documentation for I/O throttling command-line
> parameters.
>
> Patch 2 hides an internal value that was being exposed to users via the
> monitor and caused confusion.
>
> I ended up not adding QMP-style throttling.* names to the command-line
> documentation because the names are very long and unlikely to be used. I
> couldn't see a nice way of adding them while still keeping the documentation
> readable.
>
I only see this series now and it's a bit unfortunate... throttling options
are now also available for fsdev. Only QMP-style names were added though,
and they appear in the documentation. I agree the names are long, and the
result isn't pretty on 80 columns, but it is readable still.
I don't really want to add code, just to have shorter names and a prettier
output. But it would be a good thing for fsdev to benefit from this new
documentation... any suggestion how to do that ?
> Stefan Hajnoczi (3):
> qemu-options: explain disk I/O throttling options
> throttle: do not use invalid config in test
> throttle: make throttle_config(throttle_get_config()) symmetric
>
> tests/test-throttle.c | 8
> util/throttle.c | 14 ++
> qemu-options.hx | 24
> 3 files changed, 42 insertions(+), 4 deletions(-)
>
pgp3JKRM6DVtW.pgp
Description: OpenPGP digital signature
