Re: [Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c
On 2019/5/17 下午9:47, Stefano Garzarella wrote: This series contains some clean ups in net/net.c The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, Following the Markus' advice, I modified the parsing of IPv6 prefix (patch 2) and IPv4 host:port (patch 3). Then I removed the get_str_sep() function (patch 4) because it is no longer used. v3: - Patch 2: - fix indentation [Markus] - move substrings at the function level, and call g_strfreev(substrings) at the end of the function [Markus] - add Markus' R-b v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg615866.html v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg614561.html Stefano Garzarella (4): net: fix assertion failure when ipv6-prefixlen is not a number net: avoid using variable length array in net_client_init() net: use g_strsplit() for parsing host address and port net: remove unused get_str_sep() function net/net.c | 99 +++ 1 file changed, 49 insertions(+), 50 deletions(-) Applied. Thanks
Re: [Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c
Ping. Thanks, Stefano On Fri, May 17, 2019 at 3:51 PM Stefano Garzarella wrote: > > This series contains some clean ups in net/net.c > > The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, > > Following the Markus' advice, I modified the parsing of IPv6 prefix > (patch 2) and IPv4 host:port (patch 3). Then I removed the get_str_sep() > function (patch 4) because it is no longer used. > > v3: > - Patch 2: >- fix indentation [Markus] >- move substrings at the function level, and call g_strfreev(substrings) > at the end of the function [Markus] > - add Markus' R-b > > v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg615866.html > v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg614561.html > > Stefano Garzarella (4): > net: fix assertion failure when ipv6-prefixlen is not a number > net: avoid using variable length array in net_client_init() > net: use g_strsplit() for parsing host address and port > net: remove unused get_str_sep() function > > net/net.c | 99 +++ > 1 file changed, 49 insertions(+), 50 deletions(-) > > -- > 2.20.1 > >
[Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c
This series contains some clean ups in net/net.c The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, Following the Markus' advice, I modified the parsing of IPv6 prefix (patch 2) and IPv4 host:port (patch 3). Then I removed the get_str_sep() function (patch 4) because it is no longer used. v3: - Patch 2: - fix indentation [Markus] - move substrings at the function level, and call g_strfreev(substrings) at the end of the function [Markus] - add Markus' R-b v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg615866.html v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg614561.html Stefano Garzarella (4): net: fix assertion failure when ipv6-prefixlen is not a number net: avoid using variable length array in net_client_init() net: use g_strsplit() for parsing host address and port net: remove unused get_str_sep() function net/net.c | 99 +++ 1 file changed, 49 insertions(+), 50 deletions(-) -- 2.20.1