Re: [Qemu-devel] [PATCH v3 0/5] Add common QEMU control functionality to qemu-iotests

2014-04-29 Thread Kevin Wolf
Am 10.04.2014 um 22:47 hat Jeff Cody geschrieben:
 Changes from v2:
 
 Updated Reviewed-by for Fam and Benoit (Benoit's from the v1 patch, I forgot 
 to
 add those to v2)
 
 Patch 1: * updated commit message (Thanks Fam)
  * Addded '-machine accel=qtest' to qemu launch args (Thanks Fam)
 Patch 3: * Moved from test 089 - test 090 to avoid collision with
Fam's series (Thanks Fam)
 
 Changes from v1:
 
 Patch 1: * Fixed commit message, clarified comments (Thanks Benoît)
  * Changed 'shift' line to be POSIX-friendly, instead of
relying on bashism (Thanks Eric)
  * Added ability to repeat qmp or hmp commands an arbitrary
number of times
 Patch 3: New patch, for live migration
 
 Original Description:
 
 This adds some common functionality to control QEMU for qemu-iotests.
 
 Additionally, test 085 is updated to use this new functionality.
 
 Some minor fixups along the way, to clear up spaced pathname issues, 
 for common.rc, test 019, and test 086.

Thanks, applied patches 4 and 5 to the block tree. Please resend patches
1-3 after addressing the review comments.

Kevin



Re: [Qemu-devel] [PATCH v3 0/5] Add common QEMU control functionality to qemu-iotests

2014-04-25 Thread Jeff Cody
On Thu, Apr 10, 2014 at 04:47:35PM -0400, Jeff Cody wrote:
 Changes from v2:
 
 Updated Reviewed-by for Fam and Benoit (Benoit's from the v1 patch, I forgot 
 to
 add those to v2)
 
 Patch 1: * updated commit message (Thanks Fam)
  * Addded '-machine accel=qtest' to qemu launch args (Thanks Fam)
 Patch 3: * Moved from test 089 - test 090 to avoid collision with
Fam's series (Thanks Fam)
 
 Changes from v1:
 
 Patch 1: * Fixed commit message, clarified comments (Thanks Benoît)
  * Changed 'shift' line to be POSIX-friendly, instead of
relying on bashism (Thanks Eric)
  * Added ability to repeat qmp or hmp commands an arbitrary
number of times
 Patch 3: New patch, for live migration
 
 Original Description:
 
 This adds some common functionality to control QEMU for qemu-iotests.
 
 Additionally, test 085 is updated to use this new functionality.
 
 Some minor fixups along the way, to clear up spaced pathname issues, 
 for common.rc, test 019, and test 086.
 
 Jeff Cody (5):
   block: qemu-iotests - add common.qemu, for bash-controlled qemu tests
   block: qemu-iotests - update 085 to use common.qemu
   block: qemu-iotests - test for live migration
   block: qemu-iotests - fix image cleanup when using spaced pathnames
   block: qemu-iotests: make test 019 and 086 work with spaced pathnames
 
  tests/qemu-iotests/019 |   2 +-
  tests/qemu-iotests/085 |  73 +++
  tests/qemu-iotests/086 |   8 +-
  tests/qemu-iotests/090 |  97 
  tests/qemu-iotests/090.out |  20 +
  tests/qemu-iotests/common.qemu | 195 
 +
  tests/qemu-iotests/common.rc   |   4 +-
  tests/qemu-iotests/group   |   1 +
  8 files changed, 332 insertions(+), 68 deletions(-)
  create mode 100755 tests/qemu-iotests/090
  create mode 100644 tests/qemu-iotests/090.out
  create mode 100644 tests/qemu-iotests/common.qemu
 
 -- 
 1.8.3.1
 
 

Ping?




[Qemu-devel] [PATCH v3 0/5] Add common QEMU control functionality to qemu-iotests

2014-04-10 Thread Jeff Cody
Changes from v2:

Updated Reviewed-by for Fam and Benoit (Benoit's from the v1 patch, I forgot to
add those to v2)

Patch 1: * updated commit message (Thanks Fam)
 * Addded '-machine accel=qtest' to qemu launch args (Thanks Fam)
Patch 3: * Moved from test 089 - test 090 to avoid collision with
   Fam's series (Thanks Fam)

Changes from v1:

Patch 1: * Fixed commit message, clarified comments (Thanks Benoît)
 * Changed 'shift' line to be POSIX-friendly, instead of
   relying on bashism (Thanks Eric)
 * Added ability to repeat qmp or hmp commands an arbitrary
   number of times
Patch 3: New patch, for live migration

Original Description:

This adds some common functionality to control QEMU for qemu-iotests.

Additionally, test 085 is updated to use this new functionality.

Some minor fixups along the way, to clear up spaced pathname issues, 
for common.rc, test 019, and test 086.

Jeff Cody (5):
  block: qemu-iotests - add common.qemu, for bash-controlled qemu tests
  block: qemu-iotests - update 085 to use common.qemu
  block: qemu-iotests - test for live migration
  block: qemu-iotests - fix image cleanup when using spaced pathnames
  block: qemu-iotests: make test 019 and 086 work with spaced pathnames

 tests/qemu-iotests/019 |   2 +-
 tests/qemu-iotests/085 |  73 +++
 tests/qemu-iotests/086 |   8 +-
 tests/qemu-iotests/090 |  97 
 tests/qemu-iotests/090.out |  20 +
 tests/qemu-iotests/common.qemu | 195 +
 tests/qemu-iotests/common.rc   |   4 +-
 tests/qemu-iotests/group   |   1 +
 8 files changed, 332 insertions(+), 68 deletions(-)
 create mode 100755 tests/qemu-iotests/090
 create mode 100644 tests/qemu-iotests/090.out
 create mode 100644 tests/qemu-iotests/common.qemu

-- 
1.8.3.1