Re: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes
On Tue, May 30, 2017 at 06:23:55PM +0200, Igor Mammedov wrote: > changelog since v2: > (Eduardo) > - keep original logic in when moving numa part into helper > numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr > - drop "numa: fallback to default NUMA node instead of node 0" > - split out monitor hunk into separate patch > - split out spapr_fixup_cpu_numa_dt refactoring into separate patch > - add extra patch to make default node-id calculation more robust > changelog since v1: > (Eduardo) > - user error_abort in numa_cpu_pre_plug() > - make default_mapping boolean > - redo default mapping detection loop as a combo of for/if > - return back lost TODO comment > - new patch removing numa_node from generic CPUState > - drop silence test patch as it's already in pull req on list > - new patch [3/5] to fix missing _PXM/fdt nodes for implicitly mapped CPUs > - new patch dropping fallback to node 0 > > > git repo for testing: >https://github.com/imammedo/qemu.git cphp_numa_cfg_follow_up_v3_cleanups_v3 > > CC: qemu-...@nongnu.org > CC: qemu-...@nongnu.org > CC: Eduardo Habkost > CC: David Gibson > CC: Andrew Jones > > > Igor Mammedov (7): > numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr > numa: move default mapping init to machine > numa: make sure that all cpus have has_node_id set if numa is enabled > numa: make hmp 'info numa' fetch numa nodes from qmp_query_cpus() > result > numa: move numa_node from CPUState into target specific classes > spapr: cleanup spapr_fixup_cpu_numa_dt() usage > numa: cpu: calculate/set default node-ids after all -numa CLI options > are parsed Patches 1-6 queued on numa-next. Thanks. -- Eduardo
Re: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1496161442-96665-1-git-send-email-imamm...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9136a97 numa: cpu: calculate/set default node-ids after all -numa CLI options
are parsed
4d75574 spapr: cleanup spapr_fixup_cpu_numa_dt() usage
b946845 numa: move numa_node from CPUState into target specific classes
609347e numa: make hmp 'info numa' fetch numa nodes from qmp_query_cpus() result
9d2b597 numa: make sure that all cpus have has_node_id set if numa is enabled
c0d1aad numa: move default mapping init to machine
6c6afbf numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr
=== OUTPUT BEGIN ===
Checking PATCH 1/7: numa: consolidate cpu_preplug fixups/checks for
pc/arm/spapr...
ERROR: suspect code indent for conditional statements (4, 9)
#144: FILE: numa.c:546:
+if (!slot->props.has_node_id) {
+ mapped_node_id = 0;
total: 1 errors, 0 warnings, 123 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/7: numa: move default mapping init to machine...
Checking PATCH 3/7: numa: make sure that all cpus have has_node_id set if numa
is enabled...
Checking PATCH 4/7: numa: make hmp 'info numa' fetch numa nodes from
qmp_query_cpus() result...
Checking PATCH 5/7: numa: move numa_node from CPUState into target specific
classes...
Checking PATCH 6/7: spapr: cleanup spapr_fixup_cpu_numa_dt() usage...
Checking PATCH 7/7: numa: cpu: calculate/set default node-ids after all -numa
CLI options are parsed...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
[Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes
changelog since v2: (Eduardo) - keep original logic in when moving numa part into helper numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr - drop "numa: fallback to default NUMA node instead of node 0" - split out monitor hunk into separate patch - split out spapr_fixup_cpu_numa_dt refactoring into separate patch - add extra patch to make default node-id calculation more robust changelog since v1: (Eduardo) - user error_abort in numa_cpu_pre_plug() - make default_mapping boolean - redo default mapping detection loop as a combo of for/if - return back lost TODO comment - new patch removing numa_node from generic CPUState - drop silence test patch as it's already in pull req on list - new patch [3/5] to fix missing _PXM/fdt nodes for implicitly mapped CPUs - new patch dropping fallback to node 0 git repo for testing: https://github.com/imammedo/qemu.git cphp_numa_cfg_follow_up_v3_cleanups_v3 CC: qemu-...@nongnu.org CC: qemu-...@nongnu.org CC: Eduardo Habkost CC: David Gibson CC: Andrew Jones Igor Mammedov (7): numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr numa: move default mapping init to machine numa: make sure that all cpus have has_node_id set if numa is enabled numa: make hmp 'info numa' fetch numa nodes from qmp_query_cpus() result numa: move numa_node from CPUState into target specific classes spapr: cleanup spapr_fixup_cpu_numa_dt() usage numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed include/hw/boards.h | 3 +++ include/qom/cpu.h| 2 -- include/sysemu/numa.h| 10 + target/arm/cpu.h | 2 ++ target/i386/cpu.h| 1 + target/ppc/cpu.h | 1 + hw/arm/virt-acpi-build.c | 4 +--- hw/arm/virt.c| 32 +-- hw/core/machine.c| 38 +++- hw/i386/acpi-build.c | 3 +-- hw/i386/pc.c | 42 --- hw/ppc/spapr.c | 57 hw/ppc/spapr_cpu_core.c | 4 +++- monitor.c| 11 ++ numa.c | 43 +++- target/arm/cpu.c | 2 +- target/i386/cpu.c| 2 +- 17 files changed, 119 insertions(+), 138 deletions(-) -- 2.7.4
