Re: [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support

2011-09-06 Thread Kevin Wolf
Am 05.09.2011 10:15, schrieb Stefan Hajnoczi:
 On Fri, Aug 12, 2011 at 11:19:26PM +0800, Fam Zheng wrote:
 Changes:
 02/06: Free extents on fail in vmdk_open.
 
 Added:
 07/08: VMDK: bugfix, open Haiku vmdk image
 08/08: VMDK: bugfix, opening vSphere 4 exported image

 Fam Zheng (8):
   VMDK: enable twoGbMaxExtentFlat
   VMDK: add twoGbMaxExtentSparse support
   VMDK: separate vmdk_read_extent/vmdk_write_extent
   VMDK: Opening compressed extent.
   VMDK: read/write compressed extent
   VMDK: creating streamOptimized subformat
   VMDK: bugfix, open Haiku vmdk image
   VMDK: bugfix, opening vSphere 4 exported image

  block/vmdk.c |  346 
 +-
  1 files changed, 270 insertions(+), 76 deletions(-)
 
 Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Thanks, applied to the block branch.

I saw that in some places the result of bdrv_pread/pwrite is thrown away
and -EIO is returned instead. Please fix this on top of this series to
return the real error code.

Kevin



Re: [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support

2011-09-05 Thread Stefan Hajnoczi
On Fri, Aug 12, 2011 at 11:19:26PM +0800, Fam Zheng wrote:
 Changes:
 02/06: Free extents on fail in vmdk_open.
 
 Added:
 07/08: VMDK: bugfix, open Haiku vmdk image
 08/08: VMDK: bugfix, opening vSphere 4 exported image
 
 Fam Zheng (8):
   VMDK: enable twoGbMaxExtentFlat
   VMDK: add twoGbMaxExtentSparse support
   VMDK: separate vmdk_read_extent/vmdk_write_extent
   VMDK: Opening compressed extent.
   VMDK: read/write compressed extent
   VMDK: creating streamOptimized subformat
   VMDK: bugfix, open Haiku vmdk image
   VMDK: bugfix, opening vSphere 4 exported image
 
  block/vmdk.c |  346 
 +-
  1 files changed, 270 insertions(+), 76 deletions(-)

Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com



[Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support

2011-08-12 Thread Fam Zheng
Changes:
02/06: Free extents on fail in vmdk_open.

Added:
07/08: VMDK: bugfix, open Haiku vmdk image
08/08: VMDK: bugfix, opening vSphere 4 exported image

Fam Zheng (8):
  VMDK: enable twoGbMaxExtentFlat
  VMDK: add twoGbMaxExtentSparse support
  VMDK: separate vmdk_read_extent/vmdk_write_extent
  VMDK: Opening compressed extent.
  VMDK: read/write compressed extent
  VMDK: creating streamOptimized subformat
  VMDK: bugfix, open Haiku vmdk image
  VMDK: bugfix, opening vSphere 4 exported image

 block/vmdk.c |  346 +-
 1 files changed, 270 insertions(+), 76 deletions(-)