Re: [Qemu-devel] [PATCH v3 07/13] docker: Add full test

[Alex Bennée]

Fam Zheng  writes:

> On Fri, 03/11 16:10, Alex Bennée wrote:
>>
>> Fam Zheng  writes:
>>
>> > This builds all available targets.
>> >
>> > Signed-off-by: Fam Zheng 
>> > ---
>> >  tests/docker/test-full | 17 +
>> >  1 file changed, 17 insertions(+)
>> >  create mode 100755 tests/docker/test-full
>> >
>> > diff --git a/tests/docker/test-full b/tests/docker/test-full
>> > new file mode 100755
>> > index 000..fd9b798
>> > --- /dev/null
>> > +++ b/tests/docker/test-full
>> > @@ -0,0 +1,17 @@
>> > +#!/bin/bash -e
>> > +#
>> > +# Compile all the targets.
>> > +#
>> > +# Copyright (c) 2016 Red Hat Inc.
>> > +#
>> > +# Authors:
>> > +#  Fam Zheng 
>> > +#
>> > +# This work is licensed under the terms of the GNU GPL, version 2
>> > +# or (at your option) any later version. See the COPYING file in
>> > +# the top-level directory.
>> > +
>> > +. common.rc
>> > +
>> > +build_qemu
>>
>> If this is the full featured test how can we pass additional configure
>> flags to the build?
>
> Let's add an EXTRA_CONFIGURE_OPTS and use it in build_qemu. Works for
> you?

Sounds good to me.

>
>>
>> > +make check $MAKEFLAGS
>>
>>
>> --
>> Alex Bennée


--
Alex Bennée

Re: [Qemu-devel] [PATCH v3 07/13] docker: Add full test

[Fam Zheng]

On Fri, 03/11 16:10, Alex Bennée wrote:
> 
> Fam Zheng  writes:
> 
> > This builds all available targets.
> >
> > Signed-off-by: Fam Zheng 
> > ---
> >  tests/docker/test-full | 17 +
> >  1 file changed, 17 insertions(+)
> >  create mode 100755 tests/docker/test-full
> >
> > diff --git a/tests/docker/test-full b/tests/docker/test-full
> > new file mode 100755
> > index 000..fd9b798
> > --- /dev/null
> > +++ b/tests/docker/test-full
> > @@ -0,0 +1,17 @@
> > +#!/bin/bash -e
> > +#
> > +# Compile all the targets.
> > +#
> > +# Copyright (c) 2016 Red Hat Inc.
> > +#
> > +# Authors:
> > +#  Fam Zheng 
> > +#
> > +# This work is licensed under the terms of the GNU GPL, version 2
> > +# or (at your option) any later version. See the COPYING file in
> > +# the top-level directory.
> > +
> > +. common.rc
> > +
> > +build_qemu
> 
> If this is the full featured test how can we pass additional configure
> flags to the build?

Let's add an EXTRA_CONFIGURE_OPTS and use it in build_qemu. Works for you?

> 
> > +make check $MAKEFLAGS
> 
> 
> --
> Alex Bennée

Re: [Qemu-devel] [PATCH v3 07/13] docker: Add full test

[Alex Bennée]

Fam Zheng  writes:

> This builds all available targets.
>
> Signed-off-by: Fam Zheng 
> ---
>  tests/docker/test-full | 17 +
>  1 file changed, 17 insertions(+)
>  create mode 100755 tests/docker/test-full
>
> diff --git a/tests/docker/test-full b/tests/docker/test-full
> new file mode 100755
> index 000..fd9b798
> --- /dev/null
> +++ b/tests/docker/test-full
> @@ -0,0 +1,17 @@
> +#!/bin/bash -e
> +#
> +# Compile all the targets.
> +#
> +# Copyright (c) 2016 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng 
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +. common.rc
> +
> +build_qemu

If this is the full featured test how can we pass additional configure
flags to the build?

> +make check $MAKEFLAGS


--
Alex Bennée

[Qemu-devel] [PATCH v3 07/13] docker: Add full test

[Fam Zheng]

This builds all available targets.

Signed-off-by: Fam Zheng 
---
 tests/docker/test-full | 17 +
 1 file changed, 17 insertions(+)
 create mode 100755 tests/docker/test-full

diff --git a/tests/docker/test-full b/tests/docker/test-full
new file mode 100755
index 000..fd9b798
--- /dev/null
+++ b/tests/docker/test-full
@@ -0,0 +1,17 @@
+#!/bin/bash -e
+#
+# Compile all the targets.
+#
+# Copyright (c) 2016 Red Hat Inc.
+#
+# Authors:
+#  Fam Zheng 
+#
+# This work is licensed under the terms of the GNU GPL, version 2
+# or (at your option) any later version. See the COPYING file in
+# the top-level directory.
+
+. common.rc
+
+build_qemu
+make check $MAKEFLAGS
-- 
2.4.3