Re: [Qemu-devel] [PATCH v3 1/2] ahci: remove unused AHCIDevice fields

2013-01-15 Thread Juan Quintela
Jason Baron jba...@redhat.com wrote:
 From: Jason Baron jba...@redhat.com

 'dma_status' and 'dma_cb' are written to, but never read.
 Remove these fields in preparation for AHCI migration bits.

 Signed-off-by: Jason Baron jba...@redhat.com

Reviewed-by: Juan Quintela quint...@redhat.com



[Qemu-devel] [PATCH v3 1/2] ahci: remove unused AHCIDevice fields

2013-01-04 Thread Jason Baron
From: Jason Baron jba...@redhat.com

'dma_status' and 'dma_cb' are written to, but never read.
Remove these fields in preparation for AHCI migration bits.

Signed-off-by: Jason Baron jba...@redhat.com
---
 hw/ide/ahci.c |8 ++--
 hw/ide/ahci.h |2 --
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index d072449..72cd1c8 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1035,11 +1035,10 @@ out:
 static void ahci_start_dma(IDEDMA *dma, IDEState *s,
BlockDriverCompletionFunc *dma_cb)
 {
+#ifdef DEBUG_AHCI
 AHCIDevice *ad = DO_UPCAST(AHCIDevice, dma, dma);
-
+#endif
 DPRINTF(ad-port_no, \n);
-ad-dma_cb = dma_cb;
-ad-dma_status |= BM_STATUS_DMAING;
 s-io_buffer_offset = 0;
 dma_cb(s, 0);
 }
@@ -1095,7 +1094,6 @@ static int ahci_dma_set_unit(IDEDMA *dma, int unit)
 static int ahci_dma_add_status(IDEDMA *dma, int status)
 {
 AHCIDevice *ad = DO_UPCAST(AHCIDevice, dma, dma);
-ad-dma_status |= status;
 DPRINTF(ad-port_no, set status: %x\n, status);
 
 if (status  BM_STATUS_INT) {
@@ -1114,8 +1112,6 @@ static int ahci_dma_set_inactive(IDEDMA *dma)
 /* update d2h status */
 ahci_write_fis_d2h(ad, NULL);
 
-ad-dma_cb = NULL;
-
 if (!ad-check_bh) {
 /* maybe we still have something to process, check later */
 ad-check_bh = qemu_bh_new(ahci_check_cmd_bh, ad);
diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
index 1200a56..735b379 100644
--- a/hw/ide/ahci.h
+++ b/hw/ide/ahci.h
@@ -281,11 +281,9 @@ struct AHCIDevice {
 QEMUBH *check_bh;
 uint8_t *lst;
 uint8_t *res_fis;
-int dma_status;
 int done_atapi_packet;
 int busy_slot;
 int init_d2h_sent;
-BlockDriverCompletionFunc *dma_cb;
 AHCICmdHdr *cur_cmd;
 NCQTransferState ncq_tfs[AHCI_MAX_CMDS];
 };
-- 
1.7.1