Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests
Am 30.08.2017 um 18:52 hat Jeff Cody geschrieben: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu. > > Reviewed-by: Eric Blake > Signed-off-by: Jeff Cody What about non-file protocols? _cleanup_test_img() does more than just a few 'rm' commands. For NBD and vxhs it also kills the server process and for sheepdog and rbd it uses their specific tools to delete the image from the cluster because it's not simply a local file. Kevin
Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests
On 08/30/2017 12:52 PM, Jeff Cody wrote: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu. > > Reviewed-by: Eric Blake > Signed-off-by: Jeff Cody > --- > tests/qemu-iotests/001 | 6 -- > tests/qemu-iotests/002 | 6 -- > tests/qemu-iotests/003 | 6 -- > tests/qemu-iotests/004 | 6 -- > tests/qemu-iotests/005 | 6 -- > tests/qemu-iotests/007 | 7 --- > tests/qemu-iotests/008 | 6 -- > tests/qemu-iotests/009 | 6 -- > tests/qemu-iotests/010 | 6 -- > tests/qemu-iotests/011 | 6 -- > tests/qemu-iotests/012 | 6 -- > tests/qemu-iotests/013 | 6 -- > tests/qemu-iotests/014 | 6 -- > tests/qemu-iotests/015 | 7 --- > tests/qemu-iotests/017 | 6 -- > tests/qemu-iotests/018 | 6 -- > tests/qemu-iotests/019 | 8 > tests/qemu-iotests/020 | 8 > tests/qemu-iotests/021 | 6 -- > tests/qemu-iotests/022 | 6 -- > tests/qemu-iotests/023 | 6 -- > tests/qemu-iotests/024 | 8 > tests/qemu-iotests/025 | 6 -- > tests/qemu-iotests/026 | 7 --- > tests/qemu-iotests/027 | 6 -- > tests/qemu-iotests/028 | 8 > tests/qemu-iotests/029 | 7 --- > tests/qemu-iotests/031 | 6 -- > tests/qemu-iotests/032 | 6 -- > tests/qemu-iotests/033 | 6 -- > tests/qemu-iotests/034 | 6 -- > tests/qemu-iotests/035 | 6 -- > tests/qemu-iotests/036 | 6 -- > tests/qemu-iotests/037 | 6 -- > tests/qemu-iotests/038 | 6 -- > tests/qemu-iotests/039 | 6 -- > tests/qemu-iotests/042 | 6 -- > tests/qemu-iotests/043 | 7 --- > tests/qemu-iotests/046 | 6 -- > tests/qemu-iotests/047 | 6 -- > tests/qemu-iotests/048 | 8 > tests/qemu-iotests/048.out | 1 - > tests/qemu-iotests/049 | 6 -- > tests/qemu-iotests/050 | 8 > tests/qemu-iotests/051 | 6 -- > tests/qemu-iotests/052 | 6 -- > tests/qemu-iotests/053 | 7 --- > tests/qemu-iotests/054 | 6 -- > tests/qemu-iotests/058 | 8 +--- > tests/qemu-iotests/059 | 7 --- > tests/qemu-iotests/060 | 6 -- > tests/qemu-iotests/061 | 6 -- > tests/qemu-iotests/062 | 6 -- > tests/qemu-iotests/063 | 7 --- > tests/qemu-iotests/064 | 6 -- > tests/qemu-iotests/066 | 6 -- > tests/qemu-iotests/068 | 6 -- > tests/qemu-iotests/069 | 6 -- > tests/qemu-iotests/070 | 6 -- > tests/qemu-iotests/071 | 6 -- > tests/qemu-iotests/072 | 6 -- > tests/qemu-iotests/073 | 6 -- > tests/qemu-iotests/074 | 9 - > tests/qemu-iotests/074.out | 1 - > tests/qemu-iotests/075 | 6 -- > tests/qemu-iotests/076 | 6 -- > tests/qemu-iotests/077 | 6 -- > tests/qemu-iotests/078 | 6 -- > tests/qemu-iotests/079 | 6 -- > tests/qemu-iotests/080 | 7 --- > tests/qemu-iotests/081 | 8 > tests/qemu-iotests/082 | 6 -- > tests/qemu-iotests/084 | 6 -- > tests/qemu-iotests/085 | 13 + > tests/qemu-iotests/086 | 6 -- > tests/qemu-iotests/088 | 7 --- > tests/qemu-iotests/089 | 6 -- > tests/qemu-iotests/090 | 6 -- > tests/qemu-iotests/091 | 8 +--- > tests/qemu-iotests/092 | 7 --- > tests/qemu-iotests/094 | 9 + > tests/qemu-iotests/095 | 8 +--- > tests/qemu-iotests/097 | 7 --- > tests/qemu-iotests/098 | 7 --- > tests/qemu-iotests/099 | 6 -- > tests/qemu-iotests/101 | 6 -- > tests/qemu-iotests/102 | 7 +-- > tests/qemu-iotests/103 | 6 -- > tests/qemu-iotests/104 | 2 -- > tests/qemu-iotests/105 | 6 -- > tests/qemu-iotests/106 | 6 -- > tests/qemu-iotests/107 | 6 -- > tests/qemu-iotests/108 | 6 -- > tests/qemu-iotests/109 | 8 +--- > tests/qemu-iotests/110 | 6 -- > tests/qemu-iotests/111 | 6 -- > tests/qemu-iotests/112 | 6 -- > tests/qemu-iotests/113 | 6 -- > tests/qemu-iotests/114 | 6 -- > tests/qemu-iotests/115 | 6 -- > tests/qemu-iotests/116 | 6 -- > tests/qemu-iotests/117 | 7 +-- > tests/qemu-iotests/119 | 6 -- > tests/qemu-iotests/120 | 6 -- > tests/qemu-iotests/121 | 6 -- > tests/qemu-iotests/122 | 7 --- > tests/qemu-iotests/123 | 7 --- > tests/qemu-iotests/125 | 6 -- > test
[Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests
All files for a given test are now self-contained in a subdirectory, and therefore the "./check" script can do all file-related cleanup without any help. This removes file cleanups from the bash tests. The only cleanup left is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu. Reviewed-by: Eric Blake Signed-off-by: Jeff Cody --- tests/qemu-iotests/001 | 6 -- tests/qemu-iotests/002 | 6 -- tests/qemu-iotests/003 | 6 -- tests/qemu-iotests/004 | 6 -- tests/qemu-iotests/005 | 6 -- tests/qemu-iotests/007 | 7 --- tests/qemu-iotests/008 | 6 -- tests/qemu-iotests/009 | 6 -- tests/qemu-iotests/010 | 6 -- tests/qemu-iotests/011 | 6 -- tests/qemu-iotests/012 | 6 -- tests/qemu-iotests/013 | 6 -- tests/qemu-iotests/014 | 6 -- tests/qemu-iotests/015 | 7 --- tests/qemu-iotests/017 | 6 -- tests/qemu-iotests/018 | 6 -- tests/qemu-iotests/019 | 8 tests/qemu-iotests/020 | 8 tests/qemu-iotests/021 | 6 -- tests/qemu-iotests/022 | 6 -- tests/qemu-iotests/023 | 6 -- tests/qemu-iotests/024 | 8 tests/qemu-iotests/025 | 6 -- tests/qemu-iotests/026 | 7 --- tests/qemu-iotests/027 | 6 -- tests/qemu-iotests/028 | 8 tests/qemu-iotests/029 | 7 --- tests/qemu-iotests/031 | 6 -- tests/qemu-iotests/032 | 6 -- tests/qemu-iotests/033 | 6 -- tests/qemu-iotests/034 | 6 -- tests/qemu-iotests/035 | 6 -- tests/qemu-iotests/036 | 6 -- tests/qemu-iotests/037 | 6 -- tests/qemu-iotests/038 | 6 -- tests/qemu-iotests/039 | 6 -- tests/qemu-iotests/042 | 6 -- tests/qemu-iotests/043 | 7 --- tests/qemu-iotests/046 | 6 -- tests/qemu-iotests/047 | 6 -- tests/qemu-iotests/048 | 8 tests/qemu-iotests/048.out | 1 - tests/qemu-iotests/049 | 6 -- tests/qemu-iotests/050 | 8 tests/qemu-iotests/051 | 6 -- tests/qemu-iotests/052 | 6 -- tests/qemu-iotests/053 | 7 --- tests/qemu-iotests/054 | 6 -- tests/qemu-iotests/058 | 8 +--- tests/qemu-iotests/059 | 7 --- tests/qemu-iotests/060 | 6 -- tests/qemu-iotests/061 | 6 -- tests/qemu-iotests/062 | 6 -- tests/qemu-iotests/063 | 7 --- tests/qemu-iotests/064 | 6 -- tests/qemu-iotests/066 | 6 -- tests/qemu-iotests/068 | 6 -- tests/qemu-iotests/069 | 6 -- tests/qemu-iotests/070 | 6 -- tests/qemu-iotests/071 | 6 -- tests/qemu-iotests/072 | 6 -- tests/qemu-iotests/073 | 6 -- tests/qemu-iotests/074 | 9 - tests/qemu-iotests/074.out | 1 - tests/qemu-iotests/075 | 6 -- tests/qemu-iotests/076 | 6 -- tests/qemu-iotests/077 | 6 -- tests/qemu-iotests/078 | 6 -- tests/qemu-iotests/079 | 6 -- tests/qemu-iotests/080 | 7 --- tests/qemu-iotests/081 | 8 tests/qemu-iotests/082 | 6 -- tests/qemu-iotests/084 | 6 -- tests/qemu-iotests/085 | 13 + tests/qemu-iotests/086 | 6 -- tests/qemu-iotests/088 | 7 --- tests/qemu-iotests/089 | 6 -- tests/qemu-iotests/090 | 6 -- tests/qemu-iotests/091 | 8 +--- tests/qemu-iotests/092 | 7 --- tests/qemu-iotests/094 | 9 + tests/qemu-iotests/095 | 8 +--- tests/qemu-iotests/097 | 7 --- tests/qemu-iotests/098 | 7 --- tests/qemu-iotests/099 | 6 -- tests/qemu-iotests/101 | 6 -- tests/qemu-iotests/102 | 7 +-- tests/qemu-iotests/103 | 6 -- tests/qemu-iotests/104 | 2 -- tests/qemu-iotests/105 | 6 -- tests/qemu-iotests/106 | 6 -- tests/qemu-iotests/107 | 6 -- tests/qemu-iotests/108 | 6 -- tests/qemu-iotests/109 | 8 +--- tests/qemu-iotests/110 | 6 -- tests/qemu-iotests/111 | 6 -- tests/qemu-iotests/112 | 6 -- tests/qemu-iotests/113 | 6 -- tests/qemu-iotests/114 | 6 -- tests/qemu-iotests/115 | 6 -- tests/qemu-iotests/116 | 6 -- tests/qemu-iotests/117 | 7 +-- tests/qemu-iotests/119 | 6 -- tests/qemu-iotests/120 | 6 -- tests/qemu-iotests/121 | 6 -- tests/qemu-iotests/122 | 7 --- tests/qemu-iotests/123 | 7 --- tests/qemu-iotests/125 | 6 -- tests/qemu-iotests/130 | 7 +-- tests/qemu-iotests/131 | 6 -- tests/qemu-iotests/133 | 6 -- tests/qemu-iotests/134 | 6 -- tests/qemu-iotests/135 | 6 -- tests/qemu-iotests/137 | 6 -- tests/qemu-iotests/138 | 6 -- test