Re: [Qemu-devel] [PATCH v3 8/8] RFC iotests: Disable 236 and 238 on OpenBSD

2019-02-13 Thread Christian Borntraeger 
FWIW 238 also fails on my s390 box:

qemu-iotests]$ ./check -qcow2 238
QEMU  -- 
"/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/../../s390x-softmmu/qemu-system-s390x"
 -nodefaults -machine accel=qtest
QEMU_IMG  -- 
"/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/../../qemu-img" 
QEMU_IO   -- 
"/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/../../qemu-io"  --cache 
writeback -f qcow2
QEMU_NBD  -- 
"/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/../../qemu-nbd" 
IMGFMT-- qcow2 (compat=1.1)
IMGPROTO  -- file
PLATFORM  -- Linux/s390x s38lp08 5.0.0-rc5+
TEST_DIR  -- /home/cborntra/REPOS/qemu/build/tests/qemu-iotests/scratch
SOCKET_SCM_HELPER -- 
/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/socket_scm_helper

238 - output mismatch (see 238.out.bad)
--- /home/cborntra/REPOS/qemu/tests/qemu-iotests/238.out2019-02-13 
15:02:49.595468321 +0100
+++ /home/cborntra/REPOS/qemu/build/tests/qemu-iotests/238.out.bad  
2019-02-13 18:02:22.006360869 +0100
@@ -1,6 +1,6 @@
 {"return": {}}
-{"return": {}}
-{"return": {}}
-{"return": {}}
-{"return": {}}
-{"return": {}}
+None
+None
+None
+None
+None
Failures: 238
Failed 1 of 1 tests



Have not looked into that yet.


On 05.02.2019 01:18, Philippe Mathieu-Daudé wrote:
> These tests explode on OpenBSD:
> 
>   $ gmake check-block
>   [...]
>   238[17:16:09] [17:16:09] [failed, exit status 1] - output 
> mismatch (see 238.out.bad)
>   --- /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.outTue Jan 29 17:09:03 
> 2019
>   +++ /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.out.badTue Jan 29 
> 17:16:09 2019
>   @@ -1,6 +1,14 @@
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   +Traceback (most recent call last):
>   +  File "238", line 37, in 
>   +vm.launch()
>   +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
> line 295, in launch
>   +self._launch()
>   +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
> line 321, in _launch
>   +self._post_launch()
>   +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
> line 266, in _post_launch
>   +self._qmp.accept()
>   +  File 
> "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qmp/qmp.py", line 
> 157, in accept
>   +return self.__negotiate_capabilities()
>   +  File 
> "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qmp/qmp.py", line 73, 
> in __negotiate_capabilities
>   +raise QMPConnectError
>   +qmp.qmp.QMPConnectError
> 
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
> This might be due to these tests requiring KVM?...
> Maybe we need a has_kvm argument to iotests.verify_platform()?
> ---
>  tests/qemu-iotests/236 | 1 +
>  tests/qemu-iotests/238 | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/tests/qemu-iotests/236 b/tests/qemu-iotests/236
> index 79a6381f8e..b98df35ca4 100755
> --- a/tests/qemu-iotests/236
> +++ b/tests/qemu-iotests/236
> @@ -23,6 +23,7 @@ import iotests
>  from iotests import log
>  
>  iotests.verify_image_format(supported_fmts=['generic'])
> +iotests.verify_platform(unsupported_oses=['openbsd']) # FIXME
>  size = 64 * 1024 * 1024
>  granularity = 64 * 1024
>  
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..c62ff9a6dc 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -23,6 +23,8 @@ import os
>  import iotests
>  from iotests import log
>  
> +iotests.verify_platform(unsupported_oses=['openbsd']) # FIXME
> +
>  sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 
> 'scripts'))
>  
>  from qemu import QEMUMachine
>

Re: [Qemu-devel] [PATCH v3 8/8] RFC iotests: Disable 236 and 238 on OpenBSD

2019-02-04 Thread John Snow 



On 2/4/19 7:18 PM, Philippe Mathieu-Daudé wrote:
> These tests explode on OpenBSD:
> 
>   $ gmake check-block
>   [...]
>   238[17:16:09] [17:16:09] [failed, exit status 1] - output 
> mismatch (see 238.out.bad)
>   --- /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.outTue Jan 29 17:09:03 
> 2019
>   +++ /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.out.badTue Jan 29 
> 17:16:09 2019
>   @@ -1,6 +1,14 @@
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   -{"return": {}}
>   +Traceback (most recent call last):
>   +  File "238", line 37, in 
>   +vm.launch()
>   +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
> line 295, in launch
>   +self._launch()
>   +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
> line 321, in _launch
>   +self._post_launch()
>   +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
> line 266, in _post_launch
>   +self._qmp.accept()
>   +  File 
> "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qmp/qmp.py", line 
> 157, in accept
>   +return self.__negotiate_capabilities()
>   +  File 
> "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qmp/qmp.py", line 73, 
> in __negotiate_capabilities
>   +raise QMPConnectError
>   +qmp.qmp.QMPConnectError
> 
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
> This might be due to these tests requiring KVM?...
> Maybe we need a has_kvm argument to iotests.verify_platform()?

Uhhh, 236 shouldn't be doing anything fancy. It does boot a VM, but so
does 237, 222, 219, 218, 216, ...

I actually don't know what this would be failing. Any chance to look at
the core dump QEMU is leaving behind?

> ---
>  tests/qemu-iotests/236 | 1 +
>  tests/qemu-iotests/238 | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/tests/qemu-iotests/236 b/tests/qemu-iotests/236
> index 79a6381f8e..b98df35ca4 100755
> --- a/tests/qemu-iotests/236
> +++ b/tests/qemu-iotests/236
> @@ -23,6 +23,7 @@ import iotests
>  from iotests import log
>  
>  iotests.verify_image_format(supported_fmts=['generic'])
> +iotests.verify_platform(unsupported_oses=['openbsd']) # FIXME
>  size = 64 * 1024 * 1024
>  granularity = 64 * 1024
>  
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..c62ff9a6dc 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -23,6 +23,8 @@ import os
>  import iotests
>  from iotests import log
>  
> +iotests.verify_platform(unsupported_oses=['openbsd']) # FIXME
> +
>  sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 
> 'scripts'))
>  
>  from qemu import QEMUMachine
>

[Qemu-devel] [PATCH v3 8/8] RFC iotests: Disable 236 and 238 on OpenBSD

2019-02-04 Thread Philippe Mathieu-Daudé 
These tests explode on OpenBSD:

  $ gmake check-block
  [...]
  238[17:16:09] [17:16:09] [failed, exit status 1] - output 
mismatch (see 238.out.bad)
  --- /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.outTue Jan 29 17:09:03 
2019
  +++ /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.out.badTue Jan 29 
17:16:09 2019
  @@ -1,6 +1,14 @@
  -{"return": {}}
  -{"return": {}}
  -{"return": {}}
  -{"return": {}}
  -{"return": {}}
  -{"return": {}}
  +Traceback (most recent call last):
  +  File "238", line 37, in 
  +vm.launch()
  +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
line 295, in launch
  +self._launch()
  +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
line 321, in _launch
  +self._post_launch()
  +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qemu.py", 
line 266, in _post_launch
  +self._qmp.accept()
  +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qmp/qmp.py", 
line 157, in accept
  +return self.__negotiate_capabilities()
  +  File "/tmp/qemu-test.VKNS07/tests/qemu-iotests/../../scripts/qmp/qmp.py", 
line 73, in __negotiate_capabilities
  +raise QMPConnectError
  +qmp.qmp.QMPConnectError

Signed-off-by: Philippe Mathieu-Daudé 
---
This might be due to these tests requiring KVM?...
Maybe we need a has_kvm argument to iotests.verify_platform()?
---
 tests/qemu-iotests/236 | 1 +
 tests/qemu-iotests/238 | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/tests/qemu-iotests/236 b/tests/qemu-iotests/236
index 79a6381f8e..b98df35ca4 100755
--- a/tests/qemu-iotests/236
+++ b/tests/qemu-iotests/236
@@ -23,6 +23,7 @@ import iotests
 from iotests import log
 
 iotests.verify_image_format(supported_fmts=['generic'])
+iotests.verify_platform(unsupported_oses=['openbsd']) # FIXME
 size = 64 * 1024 * 1024
 granularity = 64 * 1024
 
diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
index f81ee1112f..c62ff9a6dc 100755
--- a/tests/qemu-iotests/238
+++ b/tests/qemu-iotests/238
@@ -23,6 +23,8 @@ import os
 import iotests
 from iotests import log
 
+iotests.verify_platform(unsupported_oses=['openbsd']) # FIXME
+
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'scripts'))
 
 from qemu import QEMUMachine
-- 
2.20.1