Re: [Qemu-devel] [PATCH v4 0/2] trace: Add event for vCPU memory accesses
On Fri, May 27, 2016 at 06:00:53PM +0200, Lluís Vilanova wrote:
Hi Richard,
I noticed you reviewed the last revision but weren't CCed on this.
Please review and then I'll merge it.
Stefan
> This series adds an event to track information related to memory accesses
> performed by the guest CPUs ("guest_mem_before").
>
> A future series might extend this to contain the physical address and memory
> value (e.g., "guest_mem_after").
>
> Signed-off-by: Lluís Vilanova
> ---
>
> Changes in v4
> -
>
> * Clarify alignment info is not on the trace.
> * Add event information on commit log. [Richard Henderson]
>
>
> Changes in v3
> -
>
> * Set "tcg_ctx.cpu" to NULL when unused. [Paolo Bonzini]
> * Clarify how the 'info' field is interpreted.
> * Fix argument size in 'info' field when using ld/st handlers.
> * Fix reset of unused bits in 'info' field.
>
>
> Changes in v2
> -
>
> * Rebase on bfc766d.
> * Rename "guest_vmem" to "guest_mem_before"
> * Add memory access information. [suggested by Peter Maydell]
> * Drop event "guest_vmem_user_syscall". [suggested by Peter Maydell]
>
>
> Lluís Vilanova (2):
> exec: [tcg] Track which vCPU is performing translation and execution
> trace: [all] Add "guest_mem_before" event
>
>
> include/exec/cpu_ldst_template.h | 25
> include/exec/cpu_ldst_useronly_template.h | 22 ++
> target-alpha/translate.c |1 +
> target-arm/translate.c|1 +
> target-cris/translate.c |1 +
> target-cris/translate_v10.c |1 +
> target-i386/translate.c |1 +
> target-lm32/translate.c |1 +
> target-m68k/translate.c |1 +
> target-microblaze/translate.c |1 +
> target-mips/translate.c |1 +
> target-moxie/translate.c |1 +
> target-openrisc/translate.c |1 +
> target-ppc/translate.c|1 +
> target-s390x/translate.c |1 +
> target-sh4/translate.c|1 +
> target-sparc/translate.c |1 +
> target-tilegx/translate.c |1 +
> target-tricore/translate.c|1 +
> target-unicore32/translate.c |1 +
> target-xtensa/translate.c |1 +
> tcg/tcg-op.c | 32 ++--
> tcg/tcg.h |4 +++
> trace-events | 22 ++
> trace/mem-internal.h | 46
> +
> trace/mem.h | 34 +
> translate-all.c |2 +
> 27 files changed, 202 insertions(+), 4 deletions(-)
> create mode 100644 trace/mem-internal.h
> create mode 100644 trace/mem.h
>
>
> To: qemu-devel@nongnu.org
> Cc: Stefan Hajnoczi
> Cc: Peter Maydell
>
signature.asc
Description: PGP signature
Re: [Qemu-devel] [PATCH v4 0/2] trace: Add event for vCPU memory accesses
On Fri, May 27, 2016 at 06:00:53PM +0200, Lluís Vilanova wrote:
> This series adds an event to track information related to memory accesses
> performed by the guest CPUs ("guest_mem_before").
>
> A future series might extend this to contain the physical address and memory
> value (e.g., "guest_mem_after").
>
> Signed-off-by: Lluís Vilanova
> ---
>
> Changes in v4
> -
>
> * Clarify alignment info is not on the trace.
> * Add event information on commit log. [Richard Henderson]
I'm happy to merge once TCG folks have reviewed it.
signature.asc
Description: PGP signature
[Qemu-devel] [PATCH v4 0/2] trace: Add event for vCPU memory accesses
This series adds an event to track information related to memory accesses
performed by the guest CPUs ("guest_mem_before").
A future series might extend this to contain the physical address and memory
value (e.g., "guest_mem_after").
Signed-off-by: Lluís Vilanova
---
Changes in v4
-
* Clarify alignment info is not on the trace.
* Add event information on commit log. [Richard Henderson]
Changes in v3
-
* Set "tcg_ctx.cpu" to NULL when unused. [Paolo Bonzini]
* Clarify how the 'info' field is interpreted.
* Fix argument size in 'info' field when using ld/st handlers.
* Fix reset of unused bits in 'info' field.
Changes in v2
-
* Rebase on bfc766d.
* Rename "guest_vmem" to "guest_mem_before"
* Add memory access information. [suggested by Peter Maydell]
* Drop event "guest_vmem_user_syscall". [suggested by Peter Maydell]
Lluís Vilanova (2):
exec: [tcg] Track which vCPU is performing translation and execution
trace: [all] Add "guest_mem_before" event
include/exec/cpu_ldst_template.h | 25
include/exec/cpu_ldst_useronly_template.h | 22 ++
target-alpha/translate.c |1 +
target-arm/translate.c|1 +
target-cris/translate.c |1 +
target-cris/translate_v10.c |1 +
target-i386/translate.c |1 +
target-lm32/translate.c |1 +
target-m68k/translate.c |1 +
target-microblaze/translate.c |1 +
target-mips/translate.c |1 +
target-moxie/translate.c |1 +
target-openrisc/translate.c |1 +
target-ppc/translate.c|1 +
target-s390x/translate.c |1 +
target-sh4/translate.c|1 +
target-sparc/translate.c |1 +
target-tilegx/translate.c |1 +
target-tricore/translate.c|1 +
target-unicore32/translate.c |1 +
target-xtensa/translate.c |1 +
tcg/tcg-op.c | 32 ++--
tcg/tcg.h |4 +++
trace-events | 22 ++
trace/mem-internal.h | 46 +
trace/mem.h | 34 +
translate-all.c |2 +
27 files changed, 202 insertions(+), 4 deletions(-)
create mode 100644 trace/mem-internal.h
create mode 100644 trace/mem.h
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi
Cc: Peter Maydell
