Re: [Qemu-devel] [PATCH v4 0/6] QOMify MIPS cpu
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v4 0/6] QOMify MIPS cpu
Message-id: 20170920194934.23071-1-f4...@amsat.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update]patchew/20170919201910.25656-1-ebl...@redhat.com ->
patchew/20170919201910.25656-1-ebl...@redhat.com
t [tag update]patchew/20170920194144.20101-1-js...@redhat.com ->
patchew/20170920194144.20101-1-js...@redhat.com
* [new tag] patchew/20170920194934.23071-1-f4...@amsat.org ->
patchew/20170920194934.23071-1-f4...@amsat.org
Switched to a new branch 'test'
b699ac6511 mips: replace cpu_mips_init() with cpu_generic_init()
5cc6cd0c43 mips: MIPSCPU model subclasses
37ab3cc153 mips: call cpu_mips_realize_env() from mips_cpu_realizefn()
f72459c7e1 mips: split cpu_mips_realize_env() out of cpu_mips_init()
08d47c8c54 mips: introduce internal.h and cleanup cpu.h
e5c334b86a mips: move hw/mips/cputimer.c to target/mips/
=== OUTPUT BEGIN ===
Checking PATCH 1/6: mips: move hw/mips/cputimer.c to target/mips/...
Checking PATCH 2/6: mips: introduce internal.h and cleanup cpu.h...
ERROR: space prohibited after that '&' (ctx:WxW)
#728: FILE: target/mips/internal.h:230:
+if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) {
^
ERROR: space prohibited after that '&' (ctx:WxW)
#736: FILE: target/mips/internal.h:238:
+((other_cpu->env.CP0_VPControl >> CP0VPCtl_DIS) & 1)) {
^
ERROR: space prohibited after that '&' (ctx:WxW)
#756: FILE: target/mips/internal.h:258:
+env->hflags |= (env->CP0_Status >> CP0St_KSU) & MIPS_HFLAG_KSU;
^
total: 3 errors, 0 warnings, 842 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/6: mips: split cpu_mips_realize_env() out of cpu_mips_init()...
Checking PATCH 4/6: mips: call cpu_mips_realize_env() from
mips_cpu_realizefn()...
Checking PATCH 5/6: mips: MIPSCPU model subclasses...
Checking PATCH 6/6: mips: replace cpu_mips_init() with cpu_generic_init()...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
[Qemu-devel] [PATCH v4 0/6] QOMify MIPS cpu
Hi, This series is based on Igor's "complete cpu QOMification" [1] but only modify the MIPS part. Igor posted an updated series [2]. Yongbok: this series is now ready to apply to your MIPS tree :) Regards, Phil. [1]: http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg04414.html [2]: http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg03364.html v4: - rebased after "generalize parsing of cpu_model (x86/arm)" merge v3: - added Eduardo Habkost Acked-by and Reviewed-by - put Eduardo patch 4 review comment in commit message - address Eduardo's patch 5 review (use correct type, unnecessary null check) - drop patch 7 in favor of a "generic mechanism to list CPU models using the QOM hierarchy" v2: - added Igor and James Tested-by - squashed "!fixup mips: now than MIPSCPU is QOMified, mark it abstract" PS: code movement somehow triggers a "binary vs unary operators" confusion in checkpatch: "ERROR: space prohibited after that '&' (ctx:WxW)" Igor Mammedov (2): mips: MIPSCPU model subclasses mips: replace cpu_mips_init() with cpu_generic_init() Philippe Mathieu-Daudé (4): mips: move hw/mips/cputimer.c to target/mips/ mips: introduce internal.h and cleanup cpu.h mips: split cpu_mips_realize_env() out of cpu_mips_init() mips: call cpu_mips_realize_env() from mips_cpu_realizefn() target/mips/cpu-qom.h | 1 + target/mips/cpu.h | 357 +- target/mips/internal.h| 422 ++ hw/mips/cps.c | 2 +- hw/mips/mips_fulong2e.c | 2 +- hw/mips/mips_jazz.c | 2 +- hw/mips/mips_malta.c | 2 +- hw/mips/mips_mipssim.c| 2 +- hw/mips/mips_r4k.c| 2 +- hw/mips/cputimer.c => target/mips/cp0_timer.c | 2 +- target/mips/cpu.c | 54 +++- target/mips/gdbstub.c | 1 + target/mips/helper.c | 1 + target/mips/kvm.c | 1 + target/mips/machine.c | 1 + target/mips/msa_helper.c | 1 + target/mips/op_helper.c | 1 + target/mips/translate.c | 23 +- target/mips/translate_init.c | 58 +--- hw/mips/Makefile.objs | 2 +- target/mips/Makefile.objs | 2 +- 21 files changed, 500 insertions(+), 439 deletions(-) create mode 100644 target/mips/internal.h rename hw/mips/cputimer.c => target/mips/cp0_timer.c (99%) -- 2.14.1
