Re: [Qemu-devel] [PATCH v4 0/6] vmdk: zeroed-grain GTE support

2013-05-01 Thread Stefan Hajnoczi
On Sun, Apr 28, 2013 at 11:27:57AM +0800, Fam Zheng wrote:
 Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1].
 
 [1] Virtual Disk Format 5.0 - VMware,
 http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk
 
 Changes since v3:
  - 5/6: Remove tmp
  - 6/6: Update L2 Cache
 Remove redundant assignment to m_data
 Simplify l2_offset assignment to m_data
 Fix m_data.offset endian.
 
 Changes since v2:
  - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian)
  - 6/6: Avoid side-effect of vmdk_L2update.
 Change function comment to gtkdoc stype.
 Fix VMDK4_FLAG_ZG.
 
 Changes since v1:
  - all: fix From: field
  - 1/5: squash one line of ret code macro change from 2/5
  - 2/5: change VMDK4_FLAG_ZG to VMDK4_FLAG_ZERO_GRAIN
  - 3/5: move BLOCK_OPT_ZEROED_GRAIN defination from block_int.h to vmdk.c
  - 5/5: fix metadata update issue, unit test with cases 033 034
 
 Fam Zheng (6):
   vmdk: named return code.
   vmdk: add support for “zeroed‐grain” GTE
   vmdk: Add option to create zeroed-grain image
   vmdk: change magic number to macro
   vmdk: store fields of VmdkMetaData in cpu endian
   vmdk: add bdrv_co_write_zeroes
 
  block/vmdk.c | 208 
 +--
  1 file changed, 145 insertions(+), 63 deletions(-)

One issue with Patch 6.

Please send full patch series in future revisions.  This makes it easier
to review and apply without having to search for the previous thread.

Stefan



[Qemu-devel] [PATCH v4 0/6] vmdk: zeroed-grain GTE support

2013-04-27 Thread Fam Zheng
Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1].

[1] Virtual Disk Format 5.0 - VMware,
http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk

Changes since v3:
 - 5/6: Remove tmp
 - 6/6: Update L2 Cache
Remove redundant assignment to m_data
Simplify l2_offset assignment to m_data
Fix m_data.offset endian.

Changes since v2:
 - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian)
 - 6/6: Avoid side-effect of vmdk_L2update.
Change function comment to gtkdoc stype.
Fix VMDK4_FLAG_ZG.

Changes since v1:
 - all: fix From: field
 - 1/5: squash one line of ret code macro change from 2/5
 - 2/5: change VMDK4_FLAG_ZG to VMDK4_FLAG_ZERO_GRAIN
 - 3/5: move BLOCK_OPT_ZEROED_GRAIN defination from block_int.h to vmdk.c
 - 5/5: fix metadata update issue, unit test with cases 033 034

Fam Zheng (6):
  vmdk: named return code.
  vmdk: add support for “zeroed‐grain” GTE
  vmdk: Add option to create zeroed-grain image
  vmdk: change magic number to macro
  vmdk: store fields of VmdkMetaData in cpu endian
  vmdk: add bdrv_co_write_zeroes

 block/vmdk.c | 208 +--
 1 file changed, 145 insertions(+), 63 deletions(-)

-- 
1.8.1.4