Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
Il 20/02/2014 09:37, Alexey Kardashevskiy ha scritto: On 02/14/2014 07:26 PM, Alexey Kardashevskiy wrote: > On 02/14/2014 06:29 PM, Paolo Bonzini wrote: >> Il 14/02/2014 04:25, Alexey Kardashevskiy ha scritto: >>> Nobody seems picking up the bits I am interested in from this :-/ >>> What can I possibly do to get this in upstream?... I feel I am doing >>> something systematically wrong but nobody is telling me what exactly. >>> Thanks. >> >> No, you're not. Ping agraf on IRC if he doesn't answer. > > This almost never helps... Tried. Did not help. Oh. I also would like to post a patchset adding NMI for ppc64 and since I am not allowed to post yet another #ifdef PPC64 thing, I tried making it an NMI interface for a machine (same as FWPathProvider) but found out that even "qdev: introduce FWPathProvider interface" it is not upstream yet - where is it now and what are the plans about it? Well, that would also be for Alex since the sole user is pseries. I suggest you just repost the whole series, either Alex or Andreas can pick it up. Paolo
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On 02/14/2014 07:26 PM, Alexey Kardashevskiy wrote: > On 02/14/2014 06:29 PM, Paolo Bonzini wrote: >> Il 14/02/2014 04:25, Alexey Kardashevskiy ha scritto: >>> Nobody seems picking up the bits I am interested in from this :-/ >>> What can I possibly do to get this in upstream?... I feel I am doing >>> something systematically wrong but nobody is telling me what exactly. >>> Thanks. >> >> No, you're not. Ping agraf on IRC if he doesn't answer. > > This almost never helps... Tried. Did not help. Oh. I also would like to post a patchset adding NMI for ppc64 and since I am not allowed to post yet another #ifdef PPC64 thing, I tried making it an NMI interface for a machine (same as FWPathProvider) but found out that even "qdev: introduce FWPathProvider interface" it is not upstream yet - where is it now and what are the plans about it? -- Alexey
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On 02/14/2014 06:29 PM, Paolo Bonzini wrote: > Il 14/02/2014 04:25, Alexey Kardashevskiy ha scritto: >> Nobody seems picking up the bits I am interested in from this :-/ >> What can I possibly do to get this in upstream?... I feel I am doing >> something systematically wrong but nobody is telling me what exactly. >> Thanks. > > No, you're not. Ping agraf on IRC if he doesn't answer. This almost never helps... -- Alexey
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
Il 14/02/2014 04:25, Alexey Kardashevskiy ha scritto: Nobody seems picking up the bits I am interested in from this :-/ What can I possibly do to get this in upstream?... I feel I am doing something systematically wrong but nobody is telling me what exactly. Thanks. No, you're not. Ping agraf on IRC if he doesn't answer. Paolo
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On 01/22/2014 11:17 PM, Alexey Kardashevskiy wrote: > On 01/22/2014 09:16 PM, Paolo Bonzini wrote: >> Il 22/01/2014 05:19, Alexey Kardashevskiy ha scritto: >>> On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: With the great help from Paolo, I am presenting yet another try of bootindex support on sPAPR, this time with some QOM fixes. Details are in the commit messages. Please, comment. Thanks. Alexey Kardashevskiy (5): boot: extend get_boot_devices_list() to ignore suffixes spapr-llan: add to boot device list spapr-vio: fix firmware names qdev: introduce FWPathProvider interface spapr: define interface to fix device pathname Hervé Poussineau (1): qom: detect bad reentrance during object_class_foreach Paolo Bonzini (2): qom: do not register interface "types" in the type table vl: allow customizing the class of /machine hw/core/Makefile.objs | 1 + hw/core/fw-path-provider.c| 34 ++ hw/core/qdev.c| 18 +- hw/net/spapr_llan.c | 3 ++ hw/nvram/fw_cfg.c | 2 +- hw/ppc/spapr.c| 80 ++- hw/ppc/spapr_vio.c| 2 ++ include/hw/boards.h | 1 + include/hw/fw-path-provider.h | 31 + include/sysemu/sysemu.h | 2 +- qom/object.c | 17 +++-- tests/Makefile| 1 + vl.c | 11 -- 13 files changed, 193 insertions(+), 10 deletions(-) create mode 100644 hw/core/fw-path-provider.c create mode 100644 include/hw/fw-path-provider.h >>> >>> >>> Some bits from this went upstream but none of them is mine. What am I >>> missing here? Thanks. >> >> No idea, perhaps it's because the same patches were present in multiple >> series? Alex, are you picking up what's left? >> >> Paolo > > > In the "Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during > object_class_foreach" thread Andreas told me: > > === > Be patient. > > 1) I am on holidays and thus not available full-time. > 2) Alex has already sent out his ppc PULL, so no urgency. > 3) As mentioned, I plan to post QOM and CPU PULLs later today. > > And no, you don't need to repost after parts of your series get applied > pretty much unmodified. > === > > So I wonder if I am not just patient enough :) Nobody seems picking up the bits I am interested in from this :-/ What can I possibly do to get this in upstream?... I feel I am doing something systematically wrong but nobody is telling me what exactly. Thanks. -- Alexey
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On 01/22/2014 09:16 PM, Paolo Bonzini wrote: > Il 22/01/2014 05:19, Alexey Kardashevskiy ha scritto: >> On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: >>> With the great help from Paolo, I am presenting yet another try of >>> bootindex >>> support on sPAPR, this time with some QOM fixes. Details are in the >>> commit messages. >>> Please, comment. Thanks. >>> >>> Alexey Kardashevskiy (5): >>> boot: extend get_boot_devices_list() to ignore suffixes >>> spapr-llan: add to boot device list >>> spapr-vio: fix firmware names >>> qdev: introduce FWPathProvider interface >>> spapr: define interface to fix device pathname >>> >>> Hervé Poussineau (1): >>> qom: detect bad reentrance during object_class_foreach >>> >>> Paolo Bonzini (2): >>> qom: do not register interface "types" in the type table >>> vl: allow customizing the class of /machine >>> >>> hw/core/Makefile.objs | 1 + >>> hw/core/fw-path-provider.c| 34 ++ >>> hw/core/qdev.c| 18 +- >>> hw/net/spapr_llan.c | 3 ++ >>> hw/nvram/fw_cfg.c | 2 +- >>> hw/ppc/spapr.c| 80 >>> ++- >>> hw/ppc/spapr_vio.c| 2 ++ >>> include/hw/boards.h | 1 + >>> include/hw/fw-path-provider.h | 31 + >>> include/sysemu/sysemu.h | 2 +- >>> qom/object.c | 17 +++-- >>> tests/Makefile| 1 + >>> vl.c | 11 -- >>> 13 files changed, 193 insertions(+), 10 deletions(-) >>> create mode 100644 hw/core/fw-path-provider.c >>> create mode 100644 include/hw/fw-path-provider.h >> >> >> Some bits from this went upstream but none of them is mine. What am I >> missing here? Thanks. > > No idea, perhaps it's because the same patches were present in multiple > series? Alex, are you picking up what's left? > > Paolo In the "Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach" thread Andreas told me: === Be patient. 1) I am on holidays and thus not available full-time. 2) Alex has already sent out his ppc PULL, so no urgency. 3) As mentioned, I plan to post QOM and CPU PULLs later today. And no, you don't need to repost after parts of your series get applied pretty much unmodified. === So I wonder if I am not just patient enough :) -- Alexey
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
Il 22/01/2014 05:19, Alexey Kardashevskiy ha scritto: On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: With the great help from Paolo, I am presenting yet another try of bootindex support on sPAPR, this time with some QOM fixes. Details are in the commit messages. Please, comment. Thanks. Alexey Kardashevskiy (5): boot: extend get_boot_devices_list() to ignore suffixes spapr-llan: add to boot device list spapr-vio: fix firmware names qdev: introduce FWPathProvider interface spapr: define interface to fix device pathname Hervé Poussineau (1): qom: detect bad reentrance during object_class_foreach Paolo Bonzini (2): qom: do not register interface "types" in the type table vl: allow customizing the class of /machine hw/core/Makefile.objs | 1 + hw/core/fw-path-provider.c| 34 ++ hw/core/qdev.c| 18 +- hw/net/spapr_llan.c | 3 ++ hw/nvram/fw_cfg.c | 2 +- hw/ppc/spapr.c| 80 ++- hw/ppc/spapr_vio.c| 2 ++ include/hw/boards.h | 1 + include/hw/fw-path-provider.h | 31 + include/sysemu/sysemu.h | 2 +- qom/object.c | 17 +++-- tests/Makefile| 1 + vl.c | 11 -- 13 files changed, 193 insertions(+), 10 deletions(-) create mode 100644 hw/core/fw-path-provider.c create mode 100644 include/hw/fw-path-provider.h Some bits from this went upstream but none of them is mine. What am I missing here? Thanks. No idea, perhaps it's because the same patches were present in multiple series? Alex, are you picking up what's left? Paolo
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: > With the great help from Paolo, I am presenting yet another try of bootindex > support on sPAPR, this time with some QOM fixes. Details are in the commit > messages. > Please, comment. Thanks. > > Alexey Kardashevskiy (5): > boot: extend get_boot_devices_list() to ignore suffixes > spapr-llan: add to boot device list > spapr-vio: fix firmware names > qdev: introduce FWPathProvider interface > spapr: define interface to fix device pathname > > Hervé Poussineau (1): > qom: detect bad reentrance during object_class_foreach > > Paolo Bonzini (2): > qom: do not register interface "types" in the type table > vl: allow customizing the class of /machine > > hw/core/Makefile.objs | 1 + > hw/core/fw-path-provider.c| 34 ++ > hw/core/qdev.c| 18 +- > hw/net/spapr_llan.c | 3 ++ > hw/nvram/fw_cfg.c | 2 +- > hw/ppc/spapr.c| 80 > ++- > hw/ppc/spapr_vio.c| 2 ++ > include/hw/boards.h | 1 + > include/hw/fw-path-provider.h | 31 + > include/sysemu/sysemu.h | 2 +- > qom/object.c | 17 +++-- > tests/Makefile| 1 + > vl.c | 11 -- > 13 files changed, 193 insertions(+), 10 deletions(-) > create mode 100644 hw/core/fw-path-provider.c > create mode 100644 include/hw/fw-path-provider.h Some bits from this went upstream but none of them is mine. What am I missing here? Thanks. -- Alexey
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On 12/13/2013 01:05 AM, Michael S. Tsirkin wrote: > On Wed, Dec 11, 2013 at 09:22:13PM +1100, Alexey Kardashevskiy wrote: >> With the great help from Paolo, I am presenting yet another try of bootindex >> support on sPAPR, this time with some QOM fixes. Details are in the commit >> messages. >> Please, comment. Thanks. >> >> Alexey Kardashevskiy (5): >> boot: extend get_boot_devices_list() to ignore suffixes >> spapr-llan: add to boot device list >> spapr-vio: fix firmware names >> qdev: introduce FWPathProvider interface >> spapr: define interface to fix device pathname >> >> Hervé Poussineau (1): >> qom: detect bad reentrance during object_class_foreach >> >> Paolo Bonzini (2): >> qom: do not register interface "types" in the type table >> vl: allow customizing the class of /machine > > Looks good overall. > But this seems to suffer from the same problem as existing > bootindex code on x86: you can't add a bootable device > by hotplug. Why? The boot list is delivered to SLOF via the device tree which is composed on a machine reset (spapr_finalize_fdt() calls get_boot_devices_list() and that's it) so if a bootable device was hotplugged, then after reset it will be in the list. > And we really want to fix it on x86 too. > This might be fixable using FW CFG read callback, and updating > the bootindex blob dynamically. > See how e.g. acpi_build_update works. Sorry, since I do not have good understanding what is happening in x86, I need more details. Because I would implement qemu_add_machine_reset_notifier (copied from qemu_add_machine_init_done_notifier thing) and make fw_cfg_init() register a reset notifier. Or just call qemu_add_machine_init_done_notifier() on a machine reset - I do not really see a code in any of those notifiers which could not be executed on a machine reset (but again, I am even more ignorant in x86 field than usual :) ). -- Alexey
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
On Wed, Dec 11, 2013 at 09:22:13PM +1100, Alexey Kardashevskiy wrote: > With the great help from Paolo, I am presenting yet another try of bootindex > support on sPAPR, this time with some QOM fixes. Details are in the commit > messages. > Please, comment. Thanks. > > Alexey Kardashevskiy (5): > boot: extend get_boot_devices_list() to ignore suffixes > spapr-llan: add to boot device list > spapr-vio: fix firmware names > qdev: introduce FWPathProvider interface > spapr: define interface to fix device pathname > > Hervé Poussineau (1): > qom: detect bad reentrance during object_class_foreach > > Paolo Bonzini (2): > qom: do not register interface "types" in the type table > vl: allow customizing the class of /machine Looks good overall. But this seems to suffer from the same problem as existing bootindex code on x86: you can't add a bootable device by hotplug. And we really want to fix it on x86 too. This might be fixable using FW CFG read callback, and updating the bootindex blob dynamically. See how e.g. acpi_build_update works. > hw/core/Makefile.objs | 1 + > hw/core/fw-path-provider.c| 34 ++ > hw/core/qdev.c| 18 +- > hw/net/spapr_llan.c | 3 ++ > hw/nvram/fw_cfg.c | 2 +- > hw/ppc/spapr.c| 80 > ++- > hw/ppc/spapr_vio.c| 2 ++ > include/hw/boards.h | 1 + > include/hw/fw-path-provider.h | 31 + > include/sysemu/sysemu.h | 2 +- > qom/object.c | 17 +++-- > tests/Makefile| 1 + > vl.c | 11 -- > 13 files changed, 193 insertions(+), 10 deletions(-) > create mode 100644 hw/core/fw-path-provider.c > create mode 100644 include/hw/fw-path-provider.h > > -- > 1.8.4.rc4 >
Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
Il 11/12/2013 11:22, Alexey Kardashevskiy ha scritto: > With the great help from Paolo, I am presenting yet another try of bootindex > support on sPAPR, this time with some QOM fixes. Details are in the commit > messages. > Please, comment. Thanks. > > Alexey Kardashevskiy (5): > boot: extend get_boot_devices_list() to ignore suffixes > spapr-llan: add to boot device list > spapr-vio: fix firmware names > qdev: introduce FWPathProvider interface > spapr: define interface to fix device pathname > > Hervé Poussineau (1): > qom: detect bad reentrance during object_class_foreach > > Paolo Bonzini (2): > qom: do not register interface "types" in the type table > vl: allow customizing the class of /machine > > hw/core/Makefile.objs | 1 + > hw/core/fw-path-provider.c| 34 ++ > hw/core/qdev.c| 18 +- > hw/net/spapr_llan.c | 3 ++ > hw/nvram/fw_cfg.c | 2 +- > hw/ppc/spapr.c| 80 > ++- > hw/ppc/spapr_vio.c| 2 ++ > include/hw/boards.h | 1 + > include/hw/fw-path-provider.h | 31 + > include/sysemu/sysemu.h | 2 +- > qom/object.c | 17 +++-- > tests/Makefile| 1 + > vl.c | 11 -- > 13 files changed, 193 insertions(+), 10 deletions(-) > create mode 100644 hw/core/fw-path-provider.c > create mode 100644 include/hw/fw-path-provider.h > Acked-by: Paolo Bonzini
[Qemu-devel] [PATCH v4 0/8] spapr: bootindex support
With the great help from Paolo, I am presenting yet another try of bootindex support on sPAPR, this time with some QOM fixes. Details are in the commit messages. Please, comment. Thanks. Alexey Kardashevskiy (5): boot: extend get_boot_devices_list() to ignore suffixes spapr-llan: add to boot device list spapr-vio: fix firmware names qdev: introduce FWPathProvider interface spapr: define interface to fix device pathname Hervé Poussineau (1): qom: detect bad reentrance during object_class_foreach Paolo Bonzini (2): qom: do not register interface "types" in the type table vl: allow customizing the class of /machine hw/core/Makefile.objs | 1 + hw/core/fw-path-provider.c| 34 ++ hw/core/qdev.c| 18 +- hw/net/spapr_llan.c | 3 ++ hw/nvram/fw_cfg.c | 2 +- hw/ppc/spapr.c| 80 ++- hw/ppc/spapr_vio.c| 2 ++ include/hw/boards.h | 1 + include/hw/fw-path-provider.h | 31 + include/sysemu/sysemu.h | 2 +- qom/object.c | 17 +++-- tests/Makefile| 1 + vl.c | 11 -- 13 files changed, 193 insertions(+), 10 deletions(-) create mode 100644 hw/core/fw-path-provider.c create mode 100644 include/hw/fw-path-provider.h -- 1.8.4.rc4
