Re: [Qemu-devel] [PATCH v4 00/14] block: kill sector-based blk_write/read

2016-05-02 Thread Eric Blake
On 05/02/2016 01:27 AM, Kevin Wolf wrote:
> Am 29.04.2016 um 22:08 hat Eric Blake geschrieben:
>> 2.7 material, depends on Kevin's block-next:
>> git://repo.or.cz/qemu/kevin.git block-next
>>
>> Previously posted as part of a larger NBD series [1] (at v3, explaining
>> why this is v4), but these are independent enough to make for easier
>> review on their own, and is mostly orthogonal to Kevin's recent work
>> to also kill sector interfaces from the driver.
>>
>> [1] https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03526.html
>>
>> Also available as a tag at this location:
>> git fetch git://repo.or.cz/qemu/ericb.git nbd-block-v4
> 
> If you send a v5, can you please make sure to explicitly CC qemu-block?
> This series ended up only partially and without cover letter in my mail
> folder that I generally use for processing patches, which is useless if
> you want me to merge this series through my tree.

Sure, will do (don't know why qemu-block as a list is not auto-assigned
to all nbd/ files; maybe we need a MAINTAINERS update there.  But this
patch touched more than just those files)

> 
> I also think it's a good rule of thumb that at least one person (the one
> who is supposed to merge the series) should be directly copied on the
> whole series instead of just parts of it.

I'm guessing Max and you are the two best candidates, according to
get_maintainers.pl for include/block/block_int.h?

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature


Re: [Qemu-devel] [PATCH v4 00/14] block: kill sector-based blk_write/read

2016-05-02 Thread Kevin Wolf
Am 29.04.2016 um 22:08 hat Eric Blake geschrieben:
> 2.7 material, depends on Kevin's block-next:
> git://repo.or.cz/qemu/kevin.git block-next
> 
> Previously posted as part of a larger NBD series [1] (at v3, explaining
> why this is v4), but these are independent enough to make for easier
> review on their own, and is mostly orthogonal to Kevin's recent work
> to also kill sector interfaces from the driver.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03526.html
> 
> Also available as a tag at this location:
> git fetch git://repo.or.cz/qemu/ericb.git nbd-block-v4

If you send a v5, can you please make sure to explicitly CC qemu-block?
This series ended up only partially and without cover letter in my mail
folder that I generally use for processing patches, which is useless if
you want me to merge this series through my tree.

I also think it's a good rule of thumb that at least one person (the one
who is supposed to merge the series) should be directly copied on the
whole series instead of just parts of it.

Kevin

> Changes since then:
> add R-b/Acks received so far
> rebase to Kevin's block-next branch
> patch 8: use new defines for legibility [jsnow]
> 
> 001/14:[] [--] 'block: Allow BDRV_REQ_FUA through blk_pwrite()'
> 002/14:[] [--] 'fdc: Switch to byte-based block access'
> 003/14:[] [--] 'nand: Switch to byte-based block access'
> 004/14:[] [--] 'onenand: Switch to byte-based block access'
> 005/14:[] [--] 'pflash: Switch to byte-based block access'
> 006/14:[] [--] 'sd: Switch to byte-based block access'
> 007/14:[] [--] 'm25p80: Switch to byte-based block access'
> 008/14:[0019] [FC] 'atapi: Switch to byte-based block access'
> 009/14:[] [--] 'nbd: Switch to byte-based block access'
> 010/14:[] [--] 'qemu-img: Switch to byte-based block access'
> 011/14:[] [--] 'qemu-io: Switch to byte-based block access'
> 012/14:[] [-C] 'block: Switch blk_read_unthrottled() to byte interface'
> 013/14:[] [--] 'block: Switch blk_write_zeroes() to byte interface'
> 014/14:[] [--] 'block: Kill blk_write(), blk_read()'
> 
> Eric Blake (14):
>   block: Allow BDRV_REQ_FUA through blk_pwrite()
>   fdc: Switch to byte-based block access
>   nand: Switch to byte-based block access
>   onenand: Switch to byte-based block access
>   pflash: Switch to byte-based block access
>   sd: Switch to byte-based block access
>   m25p80: Switch to byte-based block access
>   atapi: Switch to byte-based block access
>   nbd: Switch to byte-based block access
>   qemu-img: Switch to byte-based block access
>   qemu-io: Switch to byte-based block access
>   block: Switch blk_read_unthrottled() to byte interface
>   block: Switch blk_write_zeroes() to byte interface
>   block: Kill blk_write(), blk_read()
> 
>  include/sysemu/block-backend.h | 15 
>  block/block-backend.c  | 47 +++---
>  block/crypto.c |  2 +-
>  block/parallels.c  |  5 +--
>  block/qcow.c   |  8 ++---
>  block/qcow2.c  |  4 +--
>  block/qed.c|  6 ++--
>  block/sheepdog.c   |  2 +-
>  block/vdi.c|  4 +--
>  block/vhdx.c   |  5 +--
>  block/vmdk.c   | 10 +++---
>  block/vpc.c| 10 +++---
>  hw/block/fdc.c | 25 +-
>  hw/block/hd-geometry.c |  2 +-
>  hw/block/m25p80.c  |  3 +-
>  hw/block/nand.c| 36 +---
>  hw/block/onenand.c | 36 
>  hw/block/pflash_cfi01.c| 12 +++
>  hw/block/pflash_cfi02.c| 12 +++
>  hw/ide/atapi.c | 19 ++-
>  hw/nvram/spapr_nvram.c |  4 +--
>  hw/sd/sd.c | 46 ++---
>  nbd/server.c   |  2 +-
>  qemu-img.c | 31 +++--
>  qemu-io-cmds.c | 77 
> ++
>  qemu-nbd.c | 11 +++---
>  26 files changed, 185 insertions(+), 249 deletions(-)
> 
> -- 
> 2.5.5
> 
> 



[Qemu-devel] [PATCH v4 00/14] block: kill sector-based blk_write/read

2016-04-29 Thread Eric Blake
2.7 material, depends on Kevin's block-next:
git://repo.or.cz/qemu/kevin.git block-next

Previously posted as part of a larger NBD series [1] (at v3, explaining
why this is v4), but these are independent enough to make for easier
review on their own, and is mostly orthogonal to Kevin's recent work
to also kill sector interfaces from the driver.

[1] https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03526.html

Also available as a tag at this location:
git fetch git://repo.or.cz/qemu/ericb.git nbd-block-v4

Changes since then:
add R-b/Acks received so far
rebase to Kevin's block-next branch
patch 8: use new defines for legibility [jsnow]

001/14:[] [--] 'block: Allow BDRV_REQ_FUA through blk_pwrite()'
002/14:[] [--] 'fdc: Switch to byte-based block access'
003/14:[] [--] 'nand: Switch to byte-based block access'
004/14:[] [--] 'onenand: Switch to byte-based block access'
005/14:[] [--] 'pflash: Switch to byte-based block access'
006/14:[] [--] 'sd: Switch to byte-based block access'
007/14:[] [--] 'm25p80: Switch to byte-based block access'
008/14:[0019] [FC] 'atapi: Switch to byte-based block access'
009/14:[] [--] 'nbd: Switch to byte-based block access'
010/14:[] [--] 'qemu-img: Switch to byte-based block access'
011/14:[] [--] 'qemu-io: Switch to byte-based block access'
012/14:[] [-C] 'block: Switch blk_read_unthrottled() to byte interface'
013/14:[] [--] 'block: Switch blk_write_zeroes() to byte interface'
014/14:[] [--] 'block: Kill blk_write(), blk_read()'

Eric Blake (14):
  block: Allow BDRV_REQ_FUA through blk_pwrite()
  fdc: Switch to byte-based block access
  nand: Switch to byte-based block access
  onenand: Switch to byte-based block access
  pflash: Switch to byte-based block access
  sd: Switch to byte-based block access
  m25p80: Switch to byte-based block access
  atapi: Switch to byte-based block access
  nbd: Switch to byte-based block access
  qemu-img: Switch to byte-based block access
  qemu-io: Switch to byte-based block access
  block: Switch blk_read_unthrottled() to byte interface
  block: Switch blk_write_zeroes() to byte interface
  block: Kill blk_write(), blk_read()

 include/sysemu/block-backend.h | 15 
 block/block-backend.c  | 47 +++---
 block/crypto.c |  2 +-
 block/parallels.c  |  5 +--
 block/qcow.c   |  8 ++---
 block/qcow2.c  |  4 +--
 block/qed.c|  6 ++--
 block/sheepdog.c   |  2 +-
 block/vdi.c|  4 +--
 block/vhdx.c   |  5 +--
 block/vmdk.c   | 10 +++---
 block/vpc.c| 10 +++---
 hw/block/fdc.c | 25 +-
 hw/block/hd-geometry.c |  2 +-
 hw/block/m25p80.c  |  3 +-
 hw/block/nand.c| 36 +---
 hw/block/onenand.c | 36 
 hw/block/pflash_cfi01.c| 12 +++
 hw/block/pflash_cfi02.c| 12 +++
 hw/ide/atapi.c | 19 ++-
 hw/nvram/spapr_nvram.c |  4 +--
 hw/sd/sd.c | 46 ++---
 nbd/server.c   |  2 +-
 qemu-img.c | 31 +++--
 qemu-io-cmds.c | 77 ++
 qemu-nbd.c | 11 +++---
 26 files changed, 185 insertions(+), 249 deletions(-)

-- 
2.5.5