On 12/04/16 13:58, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Only for Mips platform, and only for cases when snan_bit_is_one is 0,
> correct default NaN values (in their 16-, 32-, and 64-bit flavors).
>
> For more info, see [1], page 84, Table 6.3 "Value Supplied When
> a New Quiet NaN Is Created", and [2], page 52, table 3.7 "Default
> NaN Encodings".
>
> [1] "MIPS® Architecture For Programmers Volume II-A:
> The MIPS64® Instruction Set Reference Manual",
> Imagination Technologies LTD, Revision 6.04, November 13, 2015
>
> [2] "MIPS Architecture for Programmers Volume IV-j:
> The MIPS32® SIMD Architecture Module",
> Imagination Technologies LTD, Revision 1.12, February 3, 2016
>
> Signed-off-by: Aleksandar Markovic
> ---
> fpu/softfloat-specialize.h | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
> index 53dae9b..169246e 100644
> --- a/fpu/softfloat-specialize.h
> +++ b/fpu/softfloat-specialize.h
> @@ -97,7 +97,11 @@ float16 float16_default_nan(float_status *status)
> if (status->snan_bit_is_one) {
> return const_float16(0x7DFF);
> } else {
> +#if defined(TARGET_MIPS)
> +return const_float16(0x7E00);
> +#else
> return const_float16(0xFE00);
> +#endif
> }
> #endif
> }
> @@ -116,7 +120,11 @@ float32 float32_default_nan(float_status *status)
> if (status->snan_bit_is_one) {
> return const_float32(0x7FBF);
> } else {
> +#if defined(TARGET_MIPS)
> +return const_float32(0x7FC0);
> +#else
> return const_float32(0xFFC0);
> +#endif
> }
> #endif
> }
> @@ -135,7 +143,11 @@ float64 float64_default_nan(float_status *status)
> if (status->snan_bit_is_one) {
> return const_float64(LIT64( 0x7FF7 ));
> } else {
> +#if defined(TARGET_MIPS)
> +return const_float64(LIT64( 0x7FF8 ));
Could you remove space after/before the parentheses, please? The
scripts/checkpatch.pl would complain here. Otherwise looks good to me.
Thanks,
Leon
> +#else
> return const_float64(LIT64( 0xFFF8 ));
> +#endif
> }
> #endif
> }
>
