Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Cao jin]

Hi Stefano,

Just FYI: The series have been reviewed by Eric, I guess it could 
be picked up;)


On 01/17/2016 08:13 PM, Cao jin wrote:

v6 changelog:
1. split modification of xen_host_pci_sysfs_path() into a separate new patch
as 1/6 shows.
2. 'bug' fix of qemu_strtoul(), in patch 2/6 & 3/6
3. Grammar fix in patch 4/6
4. 'msg' --> 'message' in commit message.

Cao jin (6):
   Change xen_host_pci_sysfs_path() to return void
   Xen: use qemu_strtoul instead of strtol
   Add Error **errp for xen_host_pci_device_get()
   Add Error **errp for xen_pt_setup_vga()
   Add Error **errp for xen_pt_config_init()
   Xen PCI passthru: convert to realize()

  hw/xen/xen-host-pci-device.c | 149 +--
  hw/xen/xen-host-pci-device.h |   5 +-
  hw/xen/xen_pt.c  |  77 --
  hw/xen/xen_pt.h  |   5 +-
  hw/xen/xen_pt_config_init.c  |  51 ---
  hw/xen/xen_pt_graphics.c |  11 ++--
  6 files changed, 155 insertions(+), 143 deletions(-)



--
Yours Sincerely,

Cao jin

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Stefano Stabellini]

Hi Cao,

I appreciate the reminder, but it looks like Eric hasn't reviewed patch
3/5. Am I wrong?

On Thu, 21 Jan 2016, Cao jin wrote:
> Hi Stefano,
> 
> Just FYI: The series have been reviewed by Eric, I guess it could be
> picked up;)
> 
> On 01/17/2016 08:13 PM, Cao jin wrote:
> > v6 changelog:
> > 1. split modification of xen_host_pci_sysfs_path() into a separate new patch
> > as 1/6 shows.
> > 2. 'bug' fix of qemu_strtoul(), in patch 2/6 & 3/6
> > 3. Grammar fix in patch 4/6
> > 4. 'msg' --> 'message' in commit message.
> > 
> > Cao jin (6):
> >Change xen_host_pci_sysfs_path() to return void
> >Xen: use qemu_strtoul instead of strtol
> >Add Error **errp for xen_host_pci_device_get()
> >Add Error **errp for xen_pt_setup_vga()
> >Add Error **errp for xen_pt_config_init()
> >Xen PCI passthru: convert to realize()
> > 
> >   hw/xen/xen-host-pci-device.c | 149
> > +--
> >   hw/xen/xen-host-pci-device.h |   5 +-
> >   hw/xen/xen_pt.c  |  77 --
> >   hw/xen/xen_pt.h  |   5 +-
> >   hw/xen/xen_pt_config_init.c  |  51 ---
> >   hw/xen/xen_pt_graphics.c |  11 ++--
> >   6 files changed, 155 insertions(+), 143 deletions(-)
> > 
> 
> -- 
> Yours Sincerely,
> 
> Cao jin
> 
> 
> 

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Stefano Stabellini]

On Thu, 21 Jan 2016, Eric Blake wrote:
> On 01/21/2016 08:41 AM, Stefano Stabellini wrote:
> > Hi Cao,
> > 
> > I appreciate the reminder, but it looks like Eric hasn't reviewed patch
> > 3/5. Am I wrong?
> 
> I've done it now. Thanks for your patience, and for letting me jump in
> with a late review (since I remember you were about to push an earlier
> version when I started looking at it).
 
Thank you for reviewing :-)

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Eric Blake]

On 01/21/2016 08:41 AM, Stefano Stabellini wrote:
> Hi Cao,
> 
> I appreciate the reminder, but it looks like Eric hasn't reviewed patch
> 3/5. Am I wrong?

I've done it now. Thanks for your patience, and for letting me jump in
with a late review (since I remember you were about to push an earlier
version when I started looking at it).

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Cao jin]

On 01/21/2016 11:41 PM, Stefano Stabellini wrote:

Hi Cao,

I appreciate the reminder, but it looks like Eric hasn't reviewed patch
3/5. Am I wrong?



Seems I made a little mistake:-[
Already see your pull request, Thank you:)
And thanks for Eric`s review:)

--
Yours Sincerely,

Cao jin

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Cao jin]

Seems I forgot to CC Eric, but I checked my command line history, I do 
include Eric...weird


On 01/17/2016 08:13 PM, Cao jin wrote:

v6 changelog:
1. split modification of xen_host_pci_sysfs_path() into a separate new patch
as 1/6 shows.
2. 'bug' fix of qemu_strtoul(), in patch 2/6 & 3/6
3. Grammar fix in patch 4/6
4. 'msg' --> 'message' in commit message.

Cao jin (6):
   Change xen_host_pci_sysfs_path() to return void
   Xen: use qemu_strtoul instead of strtol
   Add Error **errp for xen_host_pci_device_get()
   Add Error **errp for xen_pt_setup_vga()
   Add Error **errp for xen_pt_config_init()
   Xen PCI passthru: convert to realize()

  hw/xen/xen-host-pci-device.c | 149 +--
  hw/xen/xen-host-pci-device.h |   5 +-
  hw/xen/xen_pt.c  |  77 --
  hw/xen/xen_pt.h  |   5 +-
  hw/xen/xen_pt_config_init.c  |  51 ---
  hw/xen/xen_pt_graphics.c |  11 ++--
  6 files changed, 155 insertions(+), 143 deletions(-)



--
Yours Sincerely,

Cao jin

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Markus Armbruster]

Cao jin  writes:

> Seems I forgot to CC Eric, but I checked my command line history, I do
> include Eric...weird

Probably the broken duplicate suppression feature.  Eric, are you sure
the reduction in e-mail for you is worth the occasional confusion for
others?

[Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

[Cao jin]

v6 changelog:
1. split modification of xen_host_pci_sysfs_path() into a separate new patch
   as 1/6 shows.
2. 'bug' fix of qemu_strtoul(), in patch 2/6 & 3/6
3. Grammar fix in patch 4/6
4. 'msg' --> 'message' in commit message.

Cao jin (6):
  Change xen_host_pci_sysfs_path() to return void
  Xen: use qemu_strtoul instead of strtol
  Add Error **errp for xen_host_pci_device_get()
  Add Error **errp for xen_pt_setup_vga()
  Add Error **errp for xen_pt_config_init()
  Xen PCI passthru: convert to realize()

 hw/xen/xen-host-pci-device.c | 149 +--
 hw/xen/xen-host-pci-device.h |   5 +-
 hw/xen/xen_pt.c  |  77 --
 hw/xen/xen_pt.h  |   5 +-
 hw/xen/xen_pt_config_init.c  |  51 ---
 hw/xen/xen_pt_graphics.c |  11 ++--
 6 files changed, 155 insertions(+), 143 deletions(-)

-- 
2.1.0