Re: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-11 Thread Philippe Mathieu-Daudé
On 06/11/2018 05:19 AM, Alex Bennée wrote:
> Philippe Mathieu-Daudé  writes:
>> On 06/08/2018 09:32 AM, Alex Bennée wrote:
>>> Hi,
>>>
>>> Not a super amount has changed since the last version but review
>>> comments and review tags have been added. The new patches at the end
>>> enable a .travis.yml run and try and make the image building part of
>>> check-tcg -j safe. Essentially the problem is trying to avoid
>>> re-building the images multiple times. The additional issue is wanting
>>> an upto date Debian SID image whenever we actually build an image but
>>> not forcing a rebuild every time.
>>>
>>> Essentially I'd like to encode a conditional dependency when:
>>>   - the target image doesn't exist
>>>   - or the target image is out of date w.r.t. the dockerfike
>>>
>>> I'm thinking this is going to involve some sort of extension to the
>>> docker.py script to feed the Makefile.
>>>
>>> A number of the prerequisite patches have already been pulled in the
>>> docker fixes series however I think this series is ready to go in now.
>>> Unless there are any objections I'll send a pull on Monday.
>>>
>>> Current unreviewed patches:
>>>
>>>   patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs 
>>> review
>>>   patch 0039/docker move debian powerpc cross to sid based bui.patch needs 
>>> review
>>>   patch 0040/tests tcg enable building for PowerPC.patch needs review
>>>   patch 0042/Makefile.target add clean build guest tests targe.patch needs 
>>> review
>>>   patch 0044/tests tcg add run diff and skip helper macros.patch needs 
>>> review
>>>   patch 0045/tests tcg override runners for broken tests.patch needs review
>>>   patch 0046/target sh4 Fix translator.c assertion failure for.patch needs 
>>> review
>>
>> Is this patch related/required to this series?
>> It looks it should enter via another tree.
>>
>> The SH4 tests pass without it:
>>
>> $ make run-tcg-tests-sh4-linux-user -j1
>>   ...
>>   RUN-TESTS for sh4
>>   TESTtest-mmap (default) on sh4
>>   TESTsha1 on sh4
>>   TESTlinux-test on sh4
>>   TESTtestthread on sh4
>>   TESTtest-mmap (4096 byte pages) on sh4
> 
> Not with --enable-debug, but yeah I'll drop as it should come via Rich's
> TCG tree.

Oh I just tested the basic options, didn't go with all the matrix :/

Indeed,

  RUN-TESTS for sh4
  TESTtest-mmap (default) on sh4
  TESTsha1 on sh4
  TESTlinux-test on sh4
  TESTtestthread on sh4
qemu-sh4: accel/tcg/translator.c:66: translator_loop: Assertion
`db->is_jmp == DISAS_NEXT' failed.
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Segmentation fault
make: *** [tests/Makefile.include:950: run-tcg-tests-sh4-linux-user] Error 2

I'd still prefer this enter via Richard tree, and keep this PR
testing-only (in case if bisection in translate.c, this might goes very
slow due to your changes in ./configure triggering full rebuild).

> 
>>
>>>   patch 0047/tests add top level make dependency for docker bu.patch needs 
>>> review
>>>   patch 0048/tests docker prevent sub makes re building debian.patch needs 
>>> review
>>>   patch 0049/.travis.yml add check tcg test.patch needs review
>>>
>>>
>>> Alex Bennée (46):
>>>   configure: add support for --cross-cc-FOO
>>>   configure: move i386_cc to cross_cc_i386
>>>   configure: allow user to specify --cross-cc-cflags-foo=
>>>   configure: set cross_cc_FOO for host compiler
>>>   docker: Add "cc" subcommand
>>>   docker: extend "cc" command to accept compiler
>>>   docker: allow "cc" command to run in user context
>>>   docker: Makefile.include introduce DOCKER_SCRIPT
>>>   tests/tcg: move architecture independent tests into subdir
>>>   tests/tcg/multiarch: enable additional linux-test tests
>>>   tests/tcg/multiarch: move most output to stdout
>>>   tests/tcg: move i386 specific tests into subdir
>>>   tests/tcg: enable building for i386
>>>   tests/tcg/i386: fix test-i386
>>>   tests/tcg/i386: add runner for test-i386-fprem
>>>   tests/tcg/x86_64: add Makefile.target
>>>   tests/tcg/i386/test-i386: use modern vector_size attributes
>>>   tests/tcg/i386/test-i386: fix printf format
>>>   tests/tcg: move ARM specific tests into subdir
>>>   tests/tcg: enable building for ARM
>>>   tests/tcg/arm: fix up test-arm-iwmmxt test
>>>   tests/tcg: enable building for AArch64
>>>   tests/tcg/arm: add fcvt test cases for AArch32/64
>>>   tests/tcg: move MIPS specific tests into subdir
>>>   tests/tcg: enable building for MIPS
>>>   tests/tcg/mips: include common mips hello-mips
>>>   tests/tcg: enable building for s390x
>>>   tests/tcg: enable building for ppc64
>>>   tests/tcg: enable building for Alpha
>>>   tests/tcg/alpha: add Alpha specific tests
>>>   tests/tcg: enable building for HPPA
>>>   tests/tcg: enable building for m68k
>>>   tests/tcg: enable building for sh4
>>>   tests/tcg: enable building for sparc64
>>>   tests/tcg: enable building for mips64
>>>   tests/tcg: enable building for RISCV64
>>>   docker: move debian-powerpc-cross 

Re: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-11 Thread Alex Bennée


Philippe Mathieu-Daudé  writes:

> On 06/08/2018 09:32 AM, Alex Bennée wrote:
>> Hi,
>>
>> Not a super amount has changed since the last version but review
>> comments and review tags have been added. The new patches at the end
>> enable a .travis.yml run and try and make the image building part of
>> check-tcg -j safe. Essentially the problem is trying to avoid
>> re-building the images multiple times. The additional issue is wanting
>> an upto date Debian SID image whenever we actually build an image but
>> not forcing a rebuild every time.
>>
>> Essentially I'd like to encode a conditional dependency when:
>>   - the target image doesn't exist
>>   - or the target image is out of date w.r.t. the dockerfike
>>
>> I'm thinking this is going to involve some sort of extension to the
>> docker.py script to feed the Makefile.
>>
>> A number of the prerequisite patches have already been pulled in the
>> docker fixes series however I think this series is ready to go in now.
>> Unless there are any objections I'll send a pull on Monday.
>>
>> Current unreviewed patches:
>>
>>   patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review
>>   patch 0039/docker move debian powerpc cross to sid based bui.patch needs 
>> review
>>   patch 0040/tests tcg enable building for PowerPC.patch needs review
>>   patch 0042/Makefile.target add clean build guest tests targe.patch needs 
>> review
>>   patch 0044/tests tcg add run diff and skip helper macros.patch needs review
>>   patch 0045/tests tcg override runners for broken tests.patch needs review
>>   patch 0046/target sh4 Fix translator.c assertion failure for.patch needs 
>> review
>
> Is this patch related/required to this series?
> It looks it should enter via another tree.
>
> The SH4 tests pass without it:
>
> $ make run-tcg-tests-sh4-linux-user -j1
>   ...
>   RUN-TESTS for sh4
>   TESTtest-mmap (default) on sh4
>   TESTsha1 on sh4
>   TESTlinux-test on sh4
>   TESTtestthread on sh4
>   TESTtest-mmap (4096 byte pages) on sh4

Not with --enable-debug, but yeah I'll drop as it should come via Rich's
TCG tree.

>
>>   patch 0047/tests add top level make dependency for docker bu.patch needs 
>> review
>>   patch 0048/tests docker prevent sub makes re building debian.patch needs 
>> review
>>   patch 0049/.travis.yml add check tcg test.patch needs review
>>
>>
>> Alex Bennée (46):
>>   configure: add support for --cross-cc-FOO
>>   configure: move i386_cc to cross_cc_i386
>>   configure: allow user to specify --cross-cc-cflags-foo=
>>   configure: set cross_cc_FOO for host compiler
>>   docker: Add "cc" subcommand
>>   docker: extend "cc" command to accept compiler
>>   docker: allow "cc" command to run in user context
>>   docker: Makefile.include introduce DOCKER_SCRIPT
>>   tests/tcg: move architecture independent tests into subdir
>>   tests/tcg/multiarch: enable additional linux-test tests
>>   tests/tcg/multiarch: move most output to stdout
>>   tests/tcg: move i386 specific tests into subdir
>>   tests/tcg: enable building for i386
>>   tests/tcg/i386: fix test-i386
>>   tests/tcg/i386: add runner for test-i386-fprem
>>   tests/tcg/x86_64: add Makefile.target
>>   tests/tcg/i386/test-i386: use modern vector_size attributes
>>   tests/tcg/i386/test-i386: fix printf format
>>   tests/tcg: move ARM specific tests into subdir
>>   tests/tcg: enable building for ARM
>>   tests/tcg/arm: fix up test-arm-iwmmxt test
>>   tests/tcg: enable building for AArch64
>>   tests/tcg/arm: add fcvt test cases for AArch32/64
>>   tests/tcg: move MIPS specific tests into subdir
>>   tests/tcg: enable building for MIPS
>>   tests/tcg/mips: include common mips hello-mips
>>   tests/tcg: enable building for s390x
>>   tests/tcg: enable building for ppc64
>>   tests/tcg: enable building for Alpha
>>   tests/tcg/alpha: add Alpha specific tests
>>   tests/tcg: enable building for HPPA
>>   tests/tcg: enable building for m68k
>>   tests/tcg: enable building for sh4
>>   tests/tcg: enable building for sparc64
>>   tests/tcg: enable building for mips64
>>   tests/tcg: enable building for RISCV64
>>   docker: move debian-powerpc-cross to sid based build
>>   tests/tcg: enable building for PowerPC
>>   tests/tcg/Makefile: update to be called from Makefile.target
>>   Makefile.target: add (clean-/build-)guest-tests targets
>>   tests/Makefile.include: add [build|clean|check]-tcg targets
>>   tests/tcg: add run, diff, and skip helper macros
>>   tests/tcg: override runners for broken tests
>>   tests: add top-level make dependency for docker builds
>>   tests/docker: prevent sub-makes re-building debian-sid
>>   .travis.yml: add check-tcg test
>>
>> Fam Zheng (2):
>>   tests/tcg/multiarch: Build fix for linux-test
>>   tests/tcg/i386: Build fix for hello-i386
>>
>> Richard Henderson (1):
>>   target/sh4: Fix translator.c assertion failure for gUSA
>>
>>  .travis.yml   |6 +
>>  MAINTAINERS 

Re: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-10 Thread Philippe Mathieu-Daudé
Hi Alex,

On 06/08/2018 09:32 AM, Alex Bennée wrote:
> Hi,
> 
> Not a super amount has changed since the last version but review
> comments and review tags have been added. The new patches at the end
> enable a .travis.yml run and try and make the image building part of
> check-tcg -j safe. Essentially the problem is trying to avoid
> re-building the images multiple times. The additional issue is wanting
> an upto date Debian SID image whenever we actually build an image but
> not forcing a rebuild every time.
> 
> Essentially I'd like to encode a conditional dependency when:
>   - the target image doesn't exist
>   - or the target image is out of date w.r.t. the dockerfike
> 
> I'm thinking this is going to involve some sort of extension to the
> docker.py script to feed the Makefile.
> 
> A number of the prerequisite patches have already been pulled in the
> docker fixes series however I think this series is ready to go in now.
> Unless there are any objections I'll send a pull on Monday.
> 
> Current unreviewed patches:
> 
>   patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review
>   patch 0039/docker move debian powerpc cross to sid based bui.patch needs 
> review
>   patch 0040/tests tcg enable building for PowerPC.patch needs review
>   patch 0042/Makefile.target add clean build guest tests targe.patch needs 
> review
>   patch 0044/tests tcg add run diff and skip helper macros.patch needs review
>   patch 0045/tests tcg override runners for broken tests.patch needs review

No problem until here.

>   patch 0046/target sh4 Fix translator.c assertion failure for.patch needs 
> review

Probably unrelated.

>   patch 0047/tests add top level make dependency for docker bu.patch needs 
> review

I think you could add patch #47 (which is the last piece required to
test your work) removing the 'build-docker-prereqs' rule, and fix it
during the week.

>   patch 0048/tests docker prevent sub makes re building debian.patch needs 
> review

I wouldn't include this one (yet).

>   patch 0049/.travis.yml add check tcg test.patch needs review

You can include this one fixed using "-j1".

Good work! :)

Regards,

Phil.

> 
> 
> Alex Bennée (46):
>   configure: add support for --cross-cc-FOO
>   configure: move i386_cc to cross_cc_i386
>   configure: allow user to specify --cross-cc-cflags-foo=
>   configure: set cross_cc_FOO for host compiler
>   docker: Add "cc" subcommand
>   docker: extend "cc" command to accept compiler
>   docker: allow "cc" command to run in user context
>   docker: Makefile.include introduce DOCKER_SCRIPT
>   tests/tcg: move architecture independent tests into subdir
>   tests/tcg/multiarch: enable additional linux-test tests
>   tests/tcg/multiarch: move most output to stdout
>   tests/tcg: move i386 specific tests into subdir
>   tests/tcg: enable building for i386
>   tests/tcg/i386: fix test-i386
>   tests/tcg/i386: add runner for test-i386-fprem
>   tests/tcg/x86_64: add Makefile.target
>   tests/tcg/i386/test-i386: use modern vector_size attributes
>   tests/tcg/i386/test-i386: fix printf format
>   tests/tcg: move ARM specific tests into subdir
>   tests/tcg: enable building for ARM
>   tests/tcg/arm: fix up test-arm-iwmmxt test
>   tests/tcg: enable building for AArch64
>   tests/tcg/arm: add fcvt test cases for AArch32/64
>   tests/tcg: move MIPS specific tests into subdir
>   tests/tcg: enable building for MIPS
>   tests/tcg/mips: include common mips hello-mips
>   tests/tcg: enable building for s390x
>   tests/tcg: enable building for ppc64
>   tests/tcg: enable building for Alpha
>   tests/tcg/alpha: add Alpha specific tests
>   tests/tcg: enable building for HPPA
>   tests/tcg: enable building for m68k
>   tests/tcg: enable building for sh4
>   tests/tcg: enable building for sparc64
>   tests/tcg: enable building for mips64
>   tests/tcg: enable building for RISCV64
>   docker: move debian-powerpc-cross to sid based build
>   tests/tcg: enable building for PowerPC
>   tests/tcg/Makefile: update to be called from Makefile.target
>   Makefile.target: add (clean-/build-)guest-tests targets
>   tests/Makefile.include: add [build|clean|check]-tcg targets
>   tests/tcg: add run, diff, and skip helper macros
>   tests/tcg: override runners for broken tests
>   tests: add top-level make dependency for docker builds
>   tests/docker: prevent sub-makes re-building debian-sid
>   .travis.yml: add check-tcg test
> 
> Fam Zheng (2):
>   tests/tcg/multiarch: Build fix for linux-test
>   tests/tcg/i386: Build fix for hello-i386
> 
> Richard Henderson (1):
>   target/sh4: Fix translator.c assertion failure for gUSA
> 
>  .travis.yml   |6 +
>  MAINTAINERS   |   14 +
>  Makefile.target   |5 +
>  configure |  134 +-
>  target/sh4/translate.c|   81 +-
>  tests/Makefile.include|   38 +-
>  tests/d

Re: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-10 Thread Philippe Mathieu-Daudé
On 06/08/2018 09:32 AM, Alex Bennée wrote:
> Hi,
> 
> Not a super amount has changed since the last version but review
> comments and review tags have been added. The new patches at the end
> enable a .travis.yml run and try and make the image building part of
> check-tcg -j safe. Essentially the problem is trying to avoid
> re-building the images multiple times. The additional issue is wanting
> an upto date Debian SID image whenever we actually build an image but
> not forcing a rebuild every time.
> 
> Essentially I'd like to encode a conditional dependency when:
>   - the target image doesn't exist
>   - or the target image is out of date w.r.t. the dockerfike
> 
> I'm thinking this is going to involve some sort of extension to the
> docker.py script to feed the Makefile.
> 
> A number of the prerequisite patches have already been pulled in the
> docker fixes series however I think this series is ready to go in now.
> Unless there are any objections I'll send a pull on Monday.
> 
> Current unreviewed patches:
> 
>   patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review
>   patch 0039/docker move debian powerpc cross to sid based bui.patch needs 
> review
>   patch 0040/tests tcg enable building for PowerPC.patch needs review
>   patch 0042/Makefile.target add clean build guest tests targe.patch needs 
> review
>   patch 0044/tests tcg add run diff and skip helper macros.patch needs review
>   patch 0045/tests tcg override runners for broken tests.patch needs review
>   patch 0046/target sh4 Fix translator.c assertion failure for.patch needs 
> review

Is this patch related/required to this series?
It looks it should enter via another tree.

The SH4 tests pass without it:

$ make run-tcg-tests-sh4-linux-user -j1
  ...
  RUN-TESTS for sh4
  TESTtest-mmap (default) on sh4
  TESTsha1 on sh4
  TESTlinux-test on sh4
  TESTtestthread on sh4
  TESTtest-mmap (4096 byte pages) on sh4

>   patch 0047/tests add top level make dependency for docker bu.patch needs 
> review
>   patch 0048/tests docker prevent sub makes re building debian.patch needs 
> review
>   patch 0049/.travis.yml add check tcg test.patch needs review
> 
> 
> Alex Bennée (46):
>   configure: add support for --cross-cc-FOO
>   configure: move i386_cc to cross_cc_i386
>   configure: allow user to specify --cross-cc-cflags-foo=
>   configure: set cross_cc_FOO for host compiler
>   docker: Add "cc" subcommand
>   docker: extend "cc" command to accept compiler
>   docker: allow "cc" command to run in user context
>   docker: Makefile.include introduce DOCKER_SCRIPT
>   tests/tcg: move architecture independent tests into subdir
>   tests/tcg/multiarch: enable additional linux-test tests
>   tests/tcg/multiarch: move most output to stdout
>   tests/tcg: move i386 specific tests into subdir
>   tests/tcg: enable building for i386
>   tests/tcg/i386: fix test-i386
>   tests/tcg/i386: add runner for test-i386-fprem
>   tests/tcg/x86_64: add Makefile.target
>   tests/tcg/i386/test-i386: use modern vector_size attributes
>   tests/tcg/i386/test-i386: fix printf format
>   tests/tcg: move ARM specific tests into subdir
>   tests/tcg: enable building for ARM
>   tests/tcg/arm: fix up test-arm-iwmmxt test
>   tests/tcg: enable building for AArch64
>   tests/tcg/arm: add fcvt test cases for AArch32/64
>   tests/tcg: move MIPS specific tests into subdir
>   tests/tcg: enable building for MIPS
>   tests/tcg/mips: include common mips hello-mips
>   tests/tcg: enable building for s390x
>   tests/tcg: enable building for ppc64
>   tests/tcg: enable building for Alpha
>   tests/tcg/alpha: add Alpha specific tests
>   tests/tcg: enable building for HPPA
>   tests/tcg: enable building for m68k
>   tests/tcg: enable building for sh4
>   tests/tcg: enable building for sparc64
>   tests/tcg: enable building for mips64
>   tests/tcg: enable building for RISCV64
>   docker: move debian-powerpc-cross to sid based build
>   tests/tcg: enable building for PowerPC
>   tests/tcg/Makefile: update to be called from Makefile.target
>   Makefile.target: add (clean-/build-)guest-tests targets
>   tests/Makefile.include: add [build|clean|check]-tcg targets
>   tests/tcg: add run, diff, and skip helper macros
>   tests/tcg: override runners for broken tests
>   tests: add top-level make dependency for docker builds
>   tests/docker: prevent sub-makes re-building debian-sid
>   .travis.yml: add check-tcg test
> 
> Fam Zheng (2):
>   tests/tcg/multiarch: Build fix for linux-test
>   tests/tcg/i386: Build fix for hello-i386
> 
> Richard Henderson (1):
>   target/sh4: Fix translator.c assertion failure for gUSA
> 
>  .travis.yml   |6 +
>  MAINTAINERS   |   14 +
>  Makefile.target   |5 +
>  configure |  134 +-
>  target/sh4/translate.c|   81 +-
>  tests/Makefile.include  

Re: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-08 Thread no-reply
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180608123307.24773-1-alex.ben...@linaro.org
Subject: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]   
patchew/20180608123307.24773-1-alex.ben...@linaro.org -> 
patchew/20180608123307.24773-1-alex.ben...@linaro.org
Switched to a new branch 'test'
a3b42cec1c .travis.yml: add check-tcg test
9311c8f413 tests/docker: prevent sub-makes re-building debian-sid
09ca6d8e3b tests: add top-level make dependency for docker builds
2e879d658a target/sh4: Fix translator.c assertion failure for gUSA
0af702f272 tests/tcg: override runners for broken tests
7aaea5aa91 tests/tcg: add run, diff, and skip helper macros
e0eaf5b9a7 tests/Makefile.include: add [build|clean|check]-tcg targets
14fd002c16 Makefile.target: add (clean-/build-)guest-tests targets
3d0926618b tests/tcg/Makefile: update to be called from Makefile.target
c88f115914 tests/tcg: enable building for PowerPC
b563a10aac docker: move debian-powerpc-cross to sid based build
734d1f7ede tests/tcg: enable building for RISCV64
22bf732b43 tests/tcg: enable building for mips64
9b84cd6979 tests/tcg: enable building for sparc64
fefb20a640 tests/tcg: enable building for sh4
54483dadbf tests/tcg: enable building for m68k
605c4d05e0 tests/tcg: enable building for HPPA
39c366d478 tests/tcg/alpha: add Alpha specific tests
d007a1df09 tests/tcg: enable building for Alpha
da85acf3b9 tests/tcg: enable building for ppc64
275041e496 tests/tcg: enable building for s390x
76b1b57115 tests/tcg/mips: include common mips hello-mips
3001eff269 tests/tcg: enable building for MIPS
fc2f8e7d15 tests/tcg: move MIPS specific tests into subdir
68015cff55 tests/tcg/arm: add fcvt test cases for AArch32/64
6cf0b6d54f tests/tcg: enable building for AArch64
82a59304e2 tests/tcg/arm: fix up test-arm-iwmmxt test
2d3d6eb162 tests/tcg: enable building for ARM
1010d901f6 tests/tcg: move ARM specific tests into subdir
03414050fb tests/tcg/i386/test-i386: fix printf format
18dc0dd9c2 tests/tcg/i386/test-i386: use modern vector_size attributes
b1060c7415 tests/tcg/x86_64: add Makefile.target
f23ed58cdd tests/tcg/i386: add runner for test-i386-fprem
0d5ea512bb tests/tcg/i386: fix test-i386
6e69457c08 tests/tcg/i386: Build fix for hello-i386
c50f3d900e tests/tcg: enable building for i386
aab757d75e tests/tcg: move i386 specific tests into subdir
d76905d84c tests/tcg/multiarch: move most output to stdout
9138f45c68 tests/tcg/multiarch: enable additional linux-test tests
ced507e550 tests/tcg/multiarch: Build fix for linux-test
02861f0e01 tests/tcg: move architecture independent tests into subdir
2e91417605 docker: Makefile.include introduce DOCKER_SCRIPT
95e4639b49 docker: allow "cc" command to run in user context
638a3973fc docker: extend "cc" command to accept compiler
814faf606c docker: Add "cc" subcommand
cb7522263d configure: set cross_cc_FOO for host compiler
750b722573 configure: allow user to specify --cross-cc-cflags-foo=
00ce60af25 configure: move i386_cc to cross_cc_i386
badb0ec98b configure: add support for --cross-cc-FOO

=== OUTPUT BEGIN ===
Checking PATCH 1/49: configure: add support for --cross-cc-FOO...
Checking PATCH 2/49: configure: move i386_cc to cross_cc_i386...
Checking PATCH 3/49: configure: allow user to specify --cross-cc-cflags-foo=...
Checking PATCH 4/49: configure: set cross_cc_FOO for host compiler...
Checking PATCH 5/49: docker: Add "cc" subcommand...
Checking PATCH 6/49: docker: extend "cc" command to accept compiler...
Checking PATCH 7/49: docker: allow "cc" command to run in user context...
Checking PATCH 8/49: docker: Makefile.include introduce DOCKER_SCRIPT...
Checking PATCH 9/49: tests/tcg: move architecture independent tests into 
subdir...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#138: 
new file mode 100644

total: 0 errors, 1 warnings, 136 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/49: tests/tcg/multiarch: Build fix for linux-test...
ERROR: if this code is redundant consider removing it
#156: FILE: tests/tcg/multiarch/l

[Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-08 Thread Alex Bennée
Hi,

Not a super amount has changed since the last version but review
comments and review tags have been added. The new patches at the end
enable a .travis.yml run and try and make the image building part of
check-tcg -j safe. Essentially the problem is trying to avoid
re-building the images multiple times. The additional issue is wanting
an upto date Debian SID image whenever we actually build an image but
not forcing a rebuild every time.

Essentially I'd like to encode a conditional dependency when:
  - the target image doesn't exist
  - or the target image is out of date w.r.t. the dockerfike

I'm thinking this is going to involve some sort of extension to the
docker.py script to feed the Makefile.

A number of the prerequisite patches have already been pulled in the
docker fixes series however I think this series is ready to go in now.
Unless there are any objections I'll send a pull on Monday.

Current unreviewed patches:

  patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review
  patch 0039/docker move debian powerpc cross to sid based bui.patch needs 
review
  patch 0040/tests tcg enable building for PowerPC.patch needs review
  patch 0042/Makefile.target add clean build guest tests targe.patch needs 
review
  patch 0044/tests tcg add run diff and skip helper macros.patch needs review
  patch 0045/tests tcg override runners for broken tests.patch needs review
  patch 0046/target sh4 Fix translator.c assertion failure for.patch needs 
review
  patch 0047/tests add top level make dependency for docker bu.patch needs 
review
  patch 0048/tests docker prevent sub makes re building debian.patch needs 
review
  patch 0049/.travis.yml add check tcg test.patch needs review


Alex Bennée (46):
  configure: add support for --cross-cc-FOO
  configure: move i386_cc to cross_cc_i386
  configure: allow user to specify --cross-cc-cflags-foo=
  configure: set cross_cc_FOO for host compiler
  docker: Add "cc" subcommand
  docker: extend "cc" command to accept compiler
  docker: allow "cc" command to run in user context
  docker: Makefile.include introduce DOCKER_SCRIPT
  tests/tcg: move architecture independent tests into subdir
  tests/tcg/multiarch: enable additional linux-test tests
  tests/tcg/multiarch: move most output to stdout
  tests/tcg: move i386 specific tests into subdir
  tests/tcg: enable building for i386
  tests/tcg/i386: fix test-i386
  tests/tcg/i386: add runner for test-i386-fprem
  tests/tcg/x86_64: add Makefile.target
  tests/tcg/i386/test-i386: use modern vector_size attributes
  tests/tcg/i386/test-i386: fix printf format
  tests/tcg: move ARM specific tests into subdir
  tests/tcg: enable building for ARM
  tests/tcg/arm: fix up test-arm-iwmmxt test
  tests/tcg: enable building for AArch64
  tests/tcg/arm: add fcvt test cases for AArch32/64
  tests/tcg: move MIPS specific tests into subdir
  tests/tcg: enable building for MIPS
  tests/tcg/mips: include common mips hello-mips
  tests/tcg: enable building for s390x
  tests/tcg: enable building for ppc64
  tests/tcg: enable building for Alpha
  tests/tcg/alpha: add Alpha specific tests
  tests/tcg: enable building for HPPA
  tests/tcg: enable building for m68k
  tests/tcg: enable building for sh4
  tests/tcg: enable building for sparc64
  tests/tcg: enable building for mips64
  tests/tcg: enable building for RISCV64
  docker: move debian-powerpc-cross to sid based build
  tests/tcg: enable building for PowerPC
  tests/tcg/Makefile: update to be called from Makefile.target
  Makefile.target: add (clean-/build-)guest-tests targets
  tests/Makefile.include: add [build|clean|check]-tcg targets
  tests/tcg: add run, diff, and skip helper macros
  tests/tcg: override runners for broken tests
  tests: add top-level make dependency for docker builds
  tests/docker: prevent sub-makes re-building debian-sid
  .travis.yml: add check-tcg test

Fam Zheng (2):
  tests/tcg/multiarch: Build fix for linux-test
  tests/tcg/i386: Build fix for hello-i386

Richard Henderson (1):
  target/sh4: Fix translator.c assertion failure for gUSA

 .travis.yml   |6 +
 MAINTAINERS   |   14 +
 Makefile.target   |5 +
 configure |  134 +-
 target/sh4/translate.c|   81 +-
 tests/Makefile.include|   38 +-
 tests/docker/Makefile.include |   31 +-
 tests/docker/docker.py|   31 +
 .../dockerfiles/debian-alpha-cross.docker |   12 +
 tests/docker/dockerfiles/debian-apt-fake.sh   |   46 -
 .../dockerfiles/debian-hppa-cross.docker  |   12 +
 .../dockerfiles/debian-m68k-cross.docker  |   12 +
 .../dockerfiles/debian-mips64-cross.docker|   12 +
 .../dockerfiles/debian-powerpc-cross.docker   |   39 +-
 .../dockerfiles/debian-riscv64-cross.docker   |   12 +
 .../dockerfiles/debian-sh4-cross.docker   |   12 +
 tests/docker/dockerfi