Re: [Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

[Laszlo Ersek]

On 01/05/14 08:27, Qiao Nuohan wrote:
 write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to
 vmcore. Adding parameter WriteCoreDumpFunction f makes it available to 
 choose
 the method of writing elf notes
 
 Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
 ---
  dump.c |   16 
  1 files changed, 8 insertions(+), 8 deletions(-)

I assume the direct calls to fd_write_vmcore() (which we're not
replacing here) will be substituted / abstracted later on in the series.

Reviewed-by: Laszlo Ersek ler...@redhat.com

Re: [Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

[Qiao Nuohan]

On 01/07/2014 01:03 AM, Laszlo Ersek wrote:

I assume the direct calls to fd_write_vmcore() (which we're not
replacing here) will be substituted / abstracted later on in the series.


Yes, patch 6 will reuse write_elf32_notes/wirte_elf64_notes, but write notes
into buffer instead of vmcore directly.

--
Regards
Qiao Nuohan

[Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

[Qiao Nuohan]

write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to
vmcore. Adding parameter WriteCoreDumpFunction f makes it available to choose
the method of writing elf notes

Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
 dump.c |   16 
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/dump.c b/dump.c
index 80a9116..1fa12a2 100644
--- a/dump.c
+++ b/dump.c
@@ -271,7 +271,7 @@ static inline int cpu_index(CPUState *cpu)
 return cpu-cpu_index + 1;
 }
 
-static int write_elf64_notes(DumpState *s)
+static int write_elf64_notes(WriteCoreDumpFunction f, DumpState *s)
 {
 CPUState *cpu;
 int ret;
@@ -279,7 +279,7 @@ static int write_elf64_notes(DumpState *s)
 
 CPU_FOREACH(cpu) {
 id = cpu_index(cpu);
-ret = cpu_write_elf64_note(fd_write_vmcore, cpu, id, s);
+ret = cpu_write_elf64_note(f, cpu, id, s);
 if (ret  0) {
 dump_error(s, dump: failed to write elf notes.\n);
 return -1;
@@ -287,7 +287,7 @@ static int write_elf64_notes(DumpState *s)
 }
 
 CPU_FOREACH(cpu) {
-ret = cpu_write_elf64_qemunote(fd_write_vmcore, cpu, s);
+ret = cpu_write_elf64_qemunote(f, cpu, s);
 if (ret  0) {
 dump_error(s, dump: failed to write CPU status.\n);
 return -1;
@@ -321,7 +321,7 @@ static int write_elf32_note(DumpState *s)
 return 0;
 }
 
-static int write_elf32_notes(DumpState *s)
+static int write_elf32_notes(WriteCoreDumpFunction f, DumpState *s)
 {
 CPUState *cpu;
 int ret;
@@ -329,7 +329,7 @@ static int write_elf32_notes(DumpState *s)
 
 CPU_FOREACH(cpu) {
 id = cpu_index(cpu);
-ret = cpu_write_elf32_note(fd_write_vmcore, cpu, id, s);
+ret = cpu_write_elf32_note(f, cpu, id, s);
 if (ret  0) {
 dump_error(s, dump: failed to write elf notes.\n);
 return -1;
@@ -337,7 +337,7 @@ static int write_elf32_notes(DumpState *s)
 }
 
 CPU_FOREACH(cpu) {
-ret = cpu_write_elf32_qemunote(fd_write_vmcore, cpu, s);
+ret = cpu_write_elf32_qemunote(f, cpu, s);
 if (ret  0) {
 dump_error(s, dump: failed to write CPU status.\n);
 return -1;
@@ -574,7 +574,7 @@ static int dump_begin(DumpState *s)
 }
 
 /* write notes to vmcore */
-if (write_elf64_notes(s)  0) {
+if (write_elf64_notes(fd_write_vmcore, s)  0) {
 return -1;
 }
 
@@ -597,7 +597,7 @@ static int dump_begin(DumpState *s)
 }
 
 /* write notes to vmcore */
-if (write_elf32_notes(s)  0) {
+if (write_elf32_notes(fd_write_vmcore, s)  0) {
 return -1;
 }
 }
-- 
1.7.1