Re: [Qemu-devel] [PATCH v6 01/14] target/arm: Mark PMINTENCLR and PMINTENCLR_EL1 accesses as possibly doing IO

[Richard Henderson]

On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> I previously fixed this for PMINTENSET_EL1, but missed these.
> 
> Signed-off-by: Aaron Lindsay 
> Signed-off-by: Aaron Lindsay 
> ---
>  target/arm/helper.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson 


r~

[Qemu-devel] [PATCH v6 01/14] target/arm: Mark PMINTENCLR and PMINTENCLR_EL1 accesses as possibly doing IO

[Aaron Lindsay]

I previously fixed this for PMINTENSET_EL1, but missed these.

Signed-off-by: Aaron Lindsay 
Signed-off-by: Aaron Lindsay 
---
 target/arm/helper.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index c83f7c1109..52c76b7444 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -1423,12 +1423,14 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
   .writefn = pmintenset_write, .raw_writefn = raw_write,
   .resetvalue = 0x0 },
 { .name = "PMINTENCLR", .cp = 15, .crn = 9, .crm = 14, .opc1 = 0, .opc2 = 
2,
-  .access = PL1_RW, .accessfn = access_tpm, .type = ARM_CP_ALIAS,
+  .access = PL1_RW, .accessfn = access_tpm,
+  .type = ARM_CP_ALIAS | ARM_CP_IO,
   .fieldoffset = offsetof(CPUARMState, cp15.c9_pminten),
   .writefn = pmintenclr_write, },
 { .name = "PMINTENCLR_EL1", .state = ARM_CP_STATE_AA64,
   .opc0 = 3, .opc1 = 0, .crn = 9, .crm = 14, .opc2 = 2,
-  .access = PL1_RW, .accessfn = access_tpm, .type = ARM_CP_ALIAS,
+  .access = PL1_RW, .accessfn = access_tpm,
+  .type = ARM_CP_ALIAS | ARM_CP_IO,
   .fieldoffset = offsetof(CPUARMState, cp15.c9_pminten),
   .writefn = pmintenclr_write },
 { .name = "CCSIDR", .state = ARM_CP_STATE_BOTH,
-- 
2.19.1