Re: [Qemu-devel] [PATCH v6 01/32] target-arm: increase arrays of registers R13 R14

2014-10-13 Thread Peter Maydell
On 10 October 2014 18:03, Greg Bellows greg.bell...@linaro.org wrote:
 From: Fabian Aggeler aggel...@ethz.ch

 Increasing banked_r13 and banked_r14 to store LR_mon and SP_mon (bank
 index 7).

 Signed-off-by: Fabian Aggeler aggel...@ethz.ch
 Signed-off-by: Greg Bellows greg.bell...@linaro.org

Reviewed-by: Peter Maydell peter.mayd...@linaro.org

thanks
-- PMM



[Qemu-devel] [PATCH v6 01/32] target-arm: increase arrays of registers R13 R14

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler aggel...@ethz.ch

Increasing banked_r13 and banked_r14 to store LR_mon and SP_mon (bank
index 7).

Signed-off-by: Fabian Aggeler aggel...@ethz.ch
Signed-off-by: Greg Bellows greg.bell...@linaro.org

==

v5 - v6
- Updated vmstate_arm_cpu versioning from 20 to 21
---
 target-arm/cpu.h | 4 ++--
 target-arm/machine.c | 8 
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 65a3417..81fffd2 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -153,8 +153,8 @@ typedef struct CPUARMState {
 
 /* Banked registers.  */
 uint64_t banked_spsr[8];
-uint32_t banked_r13[6];
-uint32_t banked_r14[6];
+uint32_t banked_r13[8];
+uint32_t banked_r14[8];
 
 /* These hold r8-r12.  */
 uint32_t usr_regs[5];
diff --git a/target-arm/machine.c b/target-arm/machine.c
index ddb7d05..f1c903d 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -222,8 +222,8 @@ static int cpu_post_load(void *opaque, int version_id)
 
 const VMStateDescription vmstate_arm_cpu = {
 .name = cpu,
-.version_id = 20,
-.minimum_version_id = 20,
+.version_id = 21,
+.minimum_version_id = 21,
 .pre_save = cpu_pre_save,
 .post_load = cpu_post_load,
 .fields = (VMStateField[]) {
@@ -238,8 +238,8 @@ const VMStateDescription vmstate_arm_cpu = {
 },
 VMSTATE_UINT32(env.spsr, ARMCPU),
 VMSTATE_UINT64_ARRAY(env.banked_spsr, ARMCPU, 8),
-VMSTATE_UINT32_ARRAY(env.banked_r13, ARMCPU, 6),
-VMSTATE_UINT32_ARRAY(env.banked_r14, ARMCPU, 6),
+VMSTATE_UINT32_ARRAY(env.banked_r13, ARMCPU, 8),
+VMSTATE_UINT32_ARRAY(env.banked_r14, ARMCPU, 8),
 VMSTATE_UINT32_ARRAY(env.usr_regs, ARMCPU, 5),
 VMSTATE_UINT32_ARRAY(env.fiq_regs, ARMCPU, 5),
 VMSTATE_UINT64_ARRAY(env.elr_el, ARMCPU, 4),
-- 
1.8.3.2