Re: [Qemu-devel] [PATCH v6 03/32] target-arm: reject switching to monitor mode

2014-10-13 Thread Peter Maydell 
On 10 October 2014 18:03, Greg Bellows greg.bell...@linaro.org wrote:
 From: Sergey Fedorov s.fedo...@samsung.com

 Reject switching to monitor mode from non-secure state.

 Signed-off-by: Sergey Fedorov s.fedo...@samsung.com
 Signed-off-by: Fabian Aggeler aggel...@ethz.ch
 Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com
 Signed-off-by: Greg Bellows greg.bell...@linaro.org
 ---
  target-arm/helper.c | 2 ++
  1 file changed, 2 insertions(+)

Reviewed-by: Peter Maydell peter.mayd...@linaro.org

thanks
-- PMM

[Qemu-devel] [PATCH v6 03/32] target-arm: reject switching to monitor mode

2014-10-10 Thread Greg Bellows 
From: Sergey Fedorov s.fedo...@samsung.com

Reject switching to monitor mode from non-secure state.

Signed-off-by: Sergey Fedorov s.fedo...@samsung.com
Signed-off-by: Fabian Aggeler aggel...@ethz.ch
Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com
Signed-off-by: Greg Bellows greg.bell...@linaro.org
---
 target-arm/helper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target-arm/helper.c b/target-arm/helper.c
index 2669e15..d6e3b52 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -3531,6 +3531,8 @@ static int bad_mode_switch(CPUARMState *env, int mode)
 case ARM_CPU_MODE_IRQ:
 case ARM_CPU_MODE_FIQ:
 return 0;
+case ARM_CPU_MODE_MON:
+return !arm_is_secure(env);
 default:
 return 1;
 }
-- 
1.8.3.2