Re: [Qemu-devel] [PATCH v6 10/19] migration: Split migration_fd_process_incoming

[Peter Xu]

On Tue, Aug 08, 2017 at 06:26:20PM +0200, Juan Quintela wrote:
> We need that on later patches.
> 
> Signed-off-by: Juan Quintela 
> Reviewed-by: Dr. David Alan Gilbert 

Reviewed-by: Peter Xu 

-- 
Peter Xu

Re: [Qemu-devel] [PATCH v6 10/19] migration: Split migration_fd_process_incoming

[Daniel P. Berrange]

On Tue, Aug 08, 2017 at 06:26:20PM +0200, Juan Quintela wrote:
> We need that on later patches.
> 
> Signed-off-by: Juan Quintela 
> Reviewed-by: Dr. David Alan Gilbert 
> ---
>  migration/migration.c | 14 --
>  1 file changed, 12 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrange 



Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH v6 10/19] migration: Split migration_fd_process_incoming

[Juan Quintela]

We need that on later patches.

Signed-off-by: Juan Quintela 
Reviewed-by: Dr. David Alan Gilbert 
---
 migration/migration.c | 14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index d031c93..e36e880 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -366,9 +366,8 @@ static void process_incoming_migration_co(void *opaque)
 qemu_bh_schedule(mis->bh);
 }
 
-void migration_fd_process_incoming(QEMUFile *f)
+static void migration_incoming_setup(QEMUFile *f)
 {
-Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);
 MigrationIncomingState *mis = migration_incoming_get_current();
 
 if (multifd_load_setup() != 0) {
@@ -380,9 +379,20 @@ void migration_fd_process_incoming(QEMUFile *f)
 mis->from_src_file = f;
 }
 qemu_file_set_blocking(f, false);
+}
+
+static void migration_incoming_process(void)
+{
+Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);
 qemu_coroutine_enter(co);
 }
 
+void migration_fd_process_incoming(QEMUFile *f)
+{
+migration_incoming_setup(f);
+migration_incoming_process();
+}
+
 void migration_ioc_process_incoming(QIOChannel *ioc)
 {
 MigrationIncomingState *mis = migration_incoming_get_current();
-- 
2.9.4

[Qemu-devel] [PATCH v6 10/19] migration: Split migration_fd_process_incoming

[Juan Quintela]

We need that on later patches.

Signed-off-by: Juan Quintela 
Reviewed-by: Dr. David Alan Gilbert 
---
 migration/migration.c | 14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index d031c93..e36e880 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -366,9 +366,8 @@ static void process_incoming_migration_co(void *opaque)
 qemu_bh_schedule(mis->bh);
 }
 
-void migration_fd_process_incoming(QEMUFile *f)
+static void migration_incoming_setup(QEMUFile *f)
 {
-Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);
 MigrationIncomingState *mis = migration_incoming_get_current();
 
 if (multifd_load_setup() != 0) {
@@ -380,9 +379,20 @@ void migration_fd_process_incoming(QEMUFile *f)
 mis->from_src_file = f;
 }
 qemu_file_set_blocking(f, false);
+}
+
+static void migration_incoming_process(void)
+{
+Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);
 qemu_coroutine_enter(co);
 }
 
+void migration_fd_process_incoming(QEMUFile *f)
+{
+migration_incoming_setup(f);
+migration_incoming_process();
+}
+
 void migration_ioc_process_incoming(QIOChannel *ioc)
 {
 MigrationIncomingState *mis = migration_incoming_get_current();
-- 
2.9.4