Re: [Qemu-devel] [PATCH v8 5/9] linux-user: Update preprocessor constants for Mips-specific e_flags bits

2016-06-06 Thread Leon Alrae
On Fri, Jun 03, 2016 at 08:43:11PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic 
> 
> Missing values EF_MIPS_FP64 and EF_MIPS_NAN2008 added, and the format
> of the surrounding code segment adjusted.

Please don't include whitespace fixes of other lines into the same patch:
http://wiki.qemu.org/Contribute/SubmitAPatch#Don.27t_include_irrelevant_changes

If you drop the adjustment of surrounding code then feel free to add:

Reviewed-by: Leon Alrae 

Thanks,
Leon

> 
> Signed-off-by: Thomas Schwinge 
> Signed-off-by: Maciej W. Rozycki 
> Signed-off-by: Aleksandar Markovic 
> ---
>  include/elf.h | 18 ++
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/include/elf.h b/include/elf.h
> index 28d448b..b7f59e4 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -46,14 +46,16 @@ typedef int64_t  Elf64_Sxword;
>  #define EF_MIPS_ABI_O32  0x1000  /* O32 ABI.  */
>  #define EF_MIPS_ABI_O64  0x2000  /* O32 extended for 64 
> bit.  */
>  
> -#define EF_MIPS_NOREORDER 0x0001
> -#define EF_MIPS_PIC   0x0002
> -#define EF_MIPS_CPIC  0x0004
> -#define EF_MIPS_ABI2 0x0020
> -#define EF_MIPS_OPTIONS_FIRST0x0080
> -#define EF_MIPS_32BITMODE0x0100
> -#define EF_MIPS_ABI  0xf000
> -#define EF_MIPS_ARCH  0xf000
> +#define EF_MIPS_NOREORDER   0x0001
> +#define EF_MIPS_PIC 0x0002
> +#define EF_MIPS_CPIC0x0004
> +#define EF_MIPS_ABI20x0020
> +#define EF_MIPS_OPTIONS_FIRST   0x0080
> +#define EF_MIPS_32BITMODE   0x0100
> +#define EF_MIPS_FP640x0200
> +#define EF_MIPS_NAN2008 0x0400
> +#define EF_MIPS_ABI 0xf000
> +#define EF_MIPS_ARCH0xf000
>  
>  /* These constants define the different elf file types */
>  #define ET_NONE   0



[Qemu-devel] [PATCH v8 5/9] linux-user: Update preprocessor constants for Mips-specific e_flags bits

2016-06-03 Thread Aleksandar Markovic
From: Aleksandar Markovic 

Missing values EF_MIPS_FP64 and EF_MIPS_NAN2008 added, and the format
of the surrounding code segment adjusted.

Signed-off-by: Thomas Schwinge 
Signed-off-by: Maciej W. Rozycki 
Signed-off-by: Aleksandar Markovic 
---
 include/elf.h | 18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/include/elf.h b/include/elf.h
index 28d448b..b7f59e4 100644
--- a/include/elf.h
+++ b/include/elf.h
@@ -46,14 +46,16 @@ typedef int64_t  Elf64_Sxword;
 #define EF_MIPS_ABI_O320x1000  /* O32 ABI.  */
 #define EF_MIPS_ABI_O640x2000  /* O32 extended for 64 
bit.  */
 
-#define EF_MIPS_NOREORDER 0x0001
-#define EF_MIPS_PIC   0x0002
-#define EF_MIPS_CPIC  0x0004
-#define EF_MIPS_ABI2   0x0020
-#define EF_MIPS_OPTIONS_FIRST  0x0080
-#define EF_MIPS_32BITMODE  0x0100
-#define EF_MIPS_ABI0xf000
-#define EF_MIPS_ARCH  0xf000
+#define EF_MIPS_NOREORDER   0x0001
+#define EF_MIPS_PIC 0x0002
+#define EF_MIPS_CPIC0x0004
+#define EF_MIPS_ABI20x0020
+#define EF_MIPS_OPTIONS_FIRST   0x0080
+#define EF_MIPS_32BITMODE   0x0100
+#define EF_MIPS_FP640x0200
+#define EF_MIPS_NAN2008 0x0400
+#define EF_MIPS_ABI 0xf000
+#define EF_MIPS_ARCH0xf000
 
 /* These constants define the different elf file types */
 #define ET_NONE   0
-- 
1.9.1