Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-02-25 Thread Stefan Hajnoczi
On Mon, Feb 24, 2014 at 09:21:38PM +0100, Peter Lieven wrote:
 Am 24.02.2014 13:54, schrieb Stefan Hajnoczi:
  On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote:
  In order to proceed with the integration of the NFS protocol driver into
  qemu I was asked by Stefan to add integration for NFS into the 
  qemu-iotests.
 
  Unfortunately, this became more complex than I had expected because most
  of the tests for non RAW formats only work with the file protocol because
  they use shell commands like cp, rm or mv which obviously don't work
  on nfs:// URLs.
 
  This series first changes all those tests that are not working out of the
  box to support only the file protocol.
 
  After the NFS protocol is introduced in Patch 2 I fix most of them
  to work with any protocol.
 
  After this series the qemu-iotests for NFS run through gracefully with
  the RAW, QCOW2 and VMDK formats.
 
  There are 3 topics open:
   - test 051 fails regardless which protocol is used (I already send a msg
 to the list)
   - test 052 should work, but it seems there is a bug in the bdrv_open
 logic if the BDRV_O_SNAPSHOT flag is set and the protocol is anything
 else than file. Maybe someone with more understanding of the whole
 open logic could look at this. I do not believe that its sth which
 has to do with the NFS driver since the test fails while opening the
 backing file and other backing file tests run without problems.
   - other protocols like sheepdog or ssh that are allowed to use other 
  formats
 than raw should be tested. they actually can't never have run 
  qemu-iotests
 with qcow2 protocol for instance.
 
  If you want to do your tests please make sure to have
 [PATCHv5] block: add native support for NFS
 [PATCH v2] vmdk: Allow vmdk_create to work with protocol
  Going through my email backlog.  What is the status of this series?
 The NFS driver and bare qemu-iotests support is merged. All the patches
 that try to fix the limit for protocol != file where left out because there
 was no consensus how the filename construction etc. should be handled.

Okay, it's the latter I was wondering about.  Let's leave it for now.

Stefan



Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-02-24 Thread Stefan Hajnoczi
On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote:
 In order to proceed with the integration of the NFS protocol driver into
 qemu I was asked by Stefan to add integration for NFS into the qemu-iotests.
 
 Unfortunately, this became more complex than I had expected because most
 of the tests for non RAW formats only work with the file protocol because
 they use shell commands like cp, rm or mv which obviously don't work
 on nfs:// URLs.
 
 This series first changes all those tests that are not working out of the
 box to support only the file protocol.
 
 After the NFS protocol is introduced in Patch 2 I fix most of them
 to work with any protocol.
 
 After this series the qemu-iotests for NFS run through gracefully with
 the RAW, QCOW2 and VMDK formats.
 
 There are 3 topics open:
  - test 051 fails regardless which protocol is used (I already send a msg
to the list)
  - test 052 should work, but it seems there is a bug in the bdrv_open
logic if the BDRV_O_SNAPSHOT flag is set and the protocol is anything
else than file. Maybe someone with more understanding of the whole
open logic could look at this. I do not believe that its sth which
has to do with the NFS driver since the test fails while opening the
backing file and other backing file tests run without problems.
  - other protocols like sheepdog or ssh that are allowed to use other formats
than raw should be tested. they actually can't never have run qemu-iotests
with qcow2 protocol for instance.
 
 If you want to do your tests please make sure to have
[PATCHv5] block: add native support for NFS
[PATCH v2] vmdk: Allow vmdk_create to work with protocol

Going through my email backlog.  What is the status of this series?

Stefan



Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-02-24 Thread Peter Lieven
Am 24.02.2014 13:54, schrieb Stefan Hajnoczi:
 On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote:
 In order to proceed with the integration of the NFS protocol driver into
 qemu I was asked by Stefan to add integration for NFS into the qemu-iotests.

 Unfortunately, this became more complex than I had expected because most
 of the tests for non RAW formats only work with the file protocol because
 they use shell commands like cp, rm or mv which obviously don't work
 on nfs:// URLs.

 This series first changes all those tests that are not working out of the
 box to support only the file protocol.

 After the NFS protocol is introduced in Patch 2 I fix most of them
 to work with any protocol.

 After this series the qemu-iotests for NFS run through gracefully with
 the RAW, QCOW2 and VMDK formats.

 There are 3 topics open:
  - test 051 fails regardless which protocol is used (I already send a msg
to the list)
  - test 052 should work, but it seems there is a bug in the bdrv_open
logic if the BDRV_O_SNAPSHOT flag is set and the protocol is anything
else than file. Maybe someone with more understanding of the whole
open logic could look at this. I do not believe that its sth which
has to do with the NFS driver since the test fails while opening the
backing file and other backing file tests run without problems.
  - other protocols like sheepdog or ssh that are allowed to use other formats
than raw should be tested. they actually can't never have run qemu-iotests
with qcow2 protocol for instance.

 If you want to do your tests please make sure to have
[PATCHv5] block: add native support for NFS
[PATCH v2] vmdk: Allow vmdk_create to work with protocol
 Going through my email backlog.  What is the status of this series?
The NFS driver and bare qemu-iotests support is merged. All the patches
that try to fix the limit for protocol != file where left out because there
was no consensus how the filename construction etc. should be handled.

Peter


 Stefan




[Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-01-05 Thread Peter Lieven
In order to proceed with the integration of the NFS protocol driver into
qemu I was asked by Stefan to add integration for NFS into the qemu-iotests.

Unfortunately, this became more complex than I had expected because most
of the tests for non RAW formats only work with the file protocol because
they use shell commands like cp, rm or mv which obviously don't work
on nfs:// URLs.

This series first changes all those tests that are not working out of the
box to support only the file protocol.

After the NFS protocol is introduced in Patch 2 I fix most of them
to work with any protocol.

After this series the qemu-iotests for NFS run through gracefully with
the RAW, QCOW2 and VMDK formats.

There are 3 topics open:
 - test 051 fails regardless which protocol is used (I already send a msg
   to the list)
 - test 052 should work, but it seems there is a bug in the bdrv_open
   logic if the BDRV_O_SNAPSHOT flag is set and the protocol is anything
   else than file. Maybe someone with more understanding of the whole
   open logic could look at this. I do not believe that its sth which
   has to do with the NFS driver since the test fails while opening the
   backing file and other backing file tests run without problems.
 - other protocols like sheepdog or ssh that are allowed to use other formats
   than raw should be tested. they actually can't never have run qemu-iotests
   with qcow2 protocol for instance.

If you want to do your tests please make sure to have
   [PATCHv5] block: add native support for NFS
   [PATCH v2] vmdk: Allow vmdk_create to work with protocol

Peter

Peter Lieven (18):
  qemu-iotests: change _supported_proto to file for various tests
  qemu-iotests: enable support for NFS protocol
  qemu-iotests: enable test 016 and 025 to work with NFS protocol
  qemu-iotests: fix test 013 to work with any protocol
  qemu-iotests: fix tests 014 and 023 to work with any protocol
  qemu-iotests: fix test 018 to work with any protocol
  qemu-iotests: fix test 019 to work with any protocol
  qemu-iotests: fix test 020 to work with any protocol
  qemu-iotests: fix test 024 to work with any protocol
  qemu-iotests: fix test 028 to work with any protocol
  qemu-iotests: fix test 034 to work with any protocol
  qemu-iotests: fix test 037 to work with any protocol
  qemu-iotests: fix test 038 to work with any protocol
  qemu-iotests: fix test 043 to work with any protocol
  qemu-iotests: fix test 046 to work with any protocol
  qemu-iotests: fix expected output of test 067
  qemu-iotests: blacklist test 020 for NFS protocol
  qemu-iotests: test 026 store blkdebug.cfg locally

 tests/qemu-iotests/013|7 +++
 tests/qemu-iotests/013.out|2 +-
 tests/qemu-iotests/014|2 +-
 tests/qemu-iotests/014.out|2 +-
 tests/qemu-iotests/016|2 +-
 tests/qemu-iotests/018|   20 
 tests/qemu-iotests/018.out|4 ++--
 tests/qemu-iotests/019|   28 +---
 tests/qemu-iotests/019.out|4 ++--
 tests/qemu-iotests/020|   27 +++
 tests/qemu-iotests/020.out|2 +-
 tests/qemu-iotests/023|9 -
 tests/qemu-iotests/023.out|   16 
 tests/qemu-iotests/024|   10 --
 tests/qemu-iotests/024.out|4 ++--
 tests/qemu-iotests/025|2 +-
 tests/qemu-iotests/026|   18 --
 tests/qemu-iotests/028|7 +++
 tests/qemu-iotests/028.out|2 +-
 tests/qemu-iotests/031|2 +-
 tests/qemu-iotests/034|5 ++---
 tests/qemu-iotests/034.out|2 +-
 tests/qemu-iotests/036|2 +-
 tests/qemu-iotests/037|7 ++-
 tests/qemu-iotests/037.out|2 +-
 tests/qemu-iotests/038|7 +++
 tests/qemu-iotests/038.out|2 +-
 tests/qemu-iotests/039|2 +-
 tests/qemu-iotests/043|   22 +-
 tests/qemu-iotests/043.out|   12 ++--
 tests/qemu-iotests/046|7 ++-
 tests/qemu-iotests/046.out|2 +-
 tests/qemu-iotests/052|2 +-
 tests/qemu-iotests/054|2 +-
 tests/qemu-iotests/059|2 +-
 tests/qemu-iotests/060|2 +-
 tests/qemu-iotests/061|2 +-
 tests/qemu-iotests/063|2 +-
 tests/qemu-iotests/067.out|8 
 tests/qemu-iotests/069|2 +-
 tests/qemu-iotests/common |   22 +++---
 tests/qemu-iotests/common.pattern |7 +++
 tests/qemu-iotests/common.rc  |3 +++
 43 files changed, 150 insertions(+), 146 deletions(-)

-- 
1.7.9.5